react-native

Commit Graph

Author	SHA1	Message	Date
Janic Duplessis	4807290442	Fix cli config file on Windows Summary:The local-cli didn't pickup the `rn-cli.config.js` file on Windows because the root of a path is not 1 character long since it is 'C:/' and broke the path operations. This just substrings the root length instead of hard coding 1. Also fix a lint warning in the file about path concatenation but using string interpolation. Fixes #5686 Test plan (required) Tested that the `findParentDirectory` function returns the path of `rn-cli.config.js` if present or null if not on both windows and mac. Closes https://github.com/facebook/react-native/pull/6553 Differential Revision: D3075196 Pulled By: mkonicek fb-gh-sync-id: a19ab4030ec22d85bef40d7d91de53bc1da072ca shipit-source-id: a19ab4030ec22d85bef40d7d91de53bc1da072ca	2016-03-20 18:09:20 -07:00
Martín Bigio	849aa4dae6	Move `private-cli` commands to `local-cli` Summary: public We cannot remove `local-cli` because is referenced by the global cli explicitly. If we do so, people would have to upgrate this global thin cli which will cause some pain. So, lets move `private-cli` commands into `local-cli` instead. Reviewed By: frantic Differential Revision: D2571983 fb-gh-sync-id: 712c29430203660fb6f0d5f23813cb2a7156ee48	2015-10-26 15:36:04 -07:00

Author

SHA1

Message

Date

Janic Duplessis

4807290442

Fix cli config file on Windows

Summary:The local-cli didn't pickup the `rn-cli.config.js` file on Windows because the root of a path is not 1 character long since it is 'C:/' and broke the path operations. This just substrings the root length instead of hard coding 1.

Also fix a lint warning in the file about path concatenation but using string interpolation.

Fixes  #5686

**Test plan (required)**

Tested that the `findParentDirectory` function returns the path of `rn-cli.config.js` if present or null if not on both windows and mac.
Closes https://github.com/facebook/react-native/pull/6553

Differential Revision: D3075196

Pulled By: mkonicek

fb-gh-sync-id: a19ab4030ec22d85bef40d7d91de53bc1da072ca
shipit-source-id: a19ab4030ec22d85bef40d7d91de53bc1da072ca

2016-03-20 18:09:20 -07:00

Martín Bigio

849aa4dae6

Move `private-cli` commands to `local-cli`

Summary: public

We cannot remove `local-cli` because is referenced by the global cli explicitly. If we do so, people would have to upgrate this global thin cli which will cause some pain. So, lets move `private-cli` commands into `local-cli` instead.

Reviewed By: frantic

Differential Revision: D2571983

fb-gh-sync-id: 712c29430203660fb6f0d5f23813cb2a7156ee48

2015-10-26 15:36:04 -07:00

2 Commits