react-native

Commit Graph

Author	SHA1	Message	Date
Tim Yung	e8198aed8d	Cleanup: Prefer `React.Element` over `React$?Element` Reviewed By: vjeux Differential Revision: D4013049 fbshipit-source-id: 18a447fdbc584418d6a51770363bcd221e7fb7dc	2016-10-14 08:59:37 -07:00
Richard Evans	0cf9505630	Allow the disabling of navigation gestures. Summary: During development of an app I decided upon NavigationExperimental as I found it easily configurable with my Redux stores and make it work the way I wanted. One thing I found missing was the ability to decide if gestures were on or not for the card stack. In my case I need the gestures off as they conflict with what I am trying to do. This PR simply opens up the ability to turn the gestures for a CardStack off. Testing was completed via UI Explorer. An additional example replicating the existing one with the new setting set to false was created. To ensure nothing broke I tested both the original example and new example to ensure gestures worked (and didn't work) when expected. I did not see any unit tests around NavigationExperimental but if I simply missed them I would be more then happy to update/add any. Closes https://github.com/facebook/react-native/pull/9505 Differential Revision: D3749880 Pulled By: ericvicenti fbshipit-source-id: dfa42ff8b6c8b41490ad1efc931b364e47058243	2016-08-21 13:13:46 -07:00

Author

SHA1

Message

Date

Tim Yung

e8198aed8d

Cleanup: Prefer `React.Element` over `React$?Element`

Reviewed By: vjeux

Differential Revision: D4013049

fbshipit-source-id: 18a447fdbc584418d6a51770363bcd221e7fb7dc

2016-10-14 08:59:37 -07:00

Richard Evans

0cf9505630

Allow the disabling of navigation gestures.

Summary:
During development of an app I decided upon NavigationExperimental as I found it easily configurable with my Redux stores and make it work the way I wanted. One thing I found missing was the ability to decide if gestures were on or not for the card stack. In my case I need the gestures off as they conflict with what I am trying to do. This PR simply opens up the ability to turn the gestures for a CardStack off.

Testing was completed via UI Explorer. An additional example replicating the existing one with the new setting set to false was created. To ensure nothing broke I tested both the original example and new example to ensure gestures worked (and didn't work) when expected.

I did not see any unit tests around NavigationExperimental but if I simply missed them I would be more then happy to update/add any.
Closes https://github.com/facebook/react-native/pull/9505

Differential Revision: D3749880

Pulled By: ericvicenti

fbshipit-source-id: dfa42ff8b6c8b41490ad1efc931b364e47058243

2016-08-21 13:13:46 -07:00

2 Commits