5354 Commits

Author SHA1 Message Date
cclv
9c26742743 missing #import "RCTLog.h" 2015-04-01 21:41:39 +08:00
tako-black
399ace3733 change singular 2015-04-01 18:56:10 +09:00
Spencer Ahrens
89f52893cd Merge pull request #515 from daviskoh/fix-readme-typo
fix objc syntax error
2015-04-01 00:08:38 -07:00
Justin Carmony
b6503ba431 Packager status page & build validating against it.
Summary:
Creating a packager status page so React can validate a proper packager instance is running on 8081.

See #257 for details on this bug.

The biggest thing in this PR is I have it perform an exit 2 in the build script if the check fails. This will cause the build to fail, they can click on the error and see a nice message. Not sure if there is a way to throw a warning instead.

Also, I broke the bash script into several lines, in the Xcode editor it looks fine but in the source code it looks less than ideal. We might want to break that out into it's own bash script that is called. Let me know if you want to do that.
Closes https://github.com/facebook/react-native/pull/308
Github Author: Justin Carmony <justin@justincarmony.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 23:01:04 -08:00
Spencer Ahrens
d71c079dde Merge pull request #469 from tjwudi/master
Document supported CSS properties
2015-03-31 23:42:09 -07:00
Spencer Ahrens
5ec33d48d6 Merge pull request #451 from Rudimental/patch-3
(cleanup/ fix grammer & typos) packager/README.md
2015-03-31 23:37:13 -07:00
Jacob Gable
63c2f80a7c Do not expose define references in require polyfill
Summary:
See #406

Made sure the jest tests pass but didn't know a good unit test to add for this.
Closes https://github.com/facebook/react-native/pull/427
Github Author: Jacob Gable <jacob.gable@gmail.com>

Test Plan:
* ./runJestTests
* start app and click around
2015-03-31 22:32:39 -08:00
Spencer Ahrens
9b9afb56f5 Merge pull request #569 from sahrens/updates1
Updates from Tue 31 Mar (2)
2015-03-31 23:10:05 -07:00
Spencer Ahrens
d679cb4986 Merge pull request #296 from ide/touchable-default
[Touchable] Change default `activeOpacity` to 0.2 to match iOS
2015-03-31 22:55:15 -07:00
Spencer Ahrens
2cced4b940 - [react-packager] Switch from Q to Bluebird as promises library | Pilwon Huh
- [Touchable] Change default `activeOpacity` to 0.2 to match iOS | James Ide
- [ReactNative] Normalize name for examples | Christopher Chedeau
- [ReactNative] Added support for 3 digit hex colors | Arthur Lee
- [react-packager] Fix EISDIR error | Amjad Masad
- make renderError and renderLoading props optional for WebView | Don Yu
2015-03-31 22:48:18 -07:00
Pilwon Huh
87599bfcd1 [react-packager] Switch from Q to Bluebird as promises library
Summary:
This PR improves performance of `react-packager` by switching the promises library from the [Q](https://github.com/kriskowal/q) to [Bluebird](https://github.com/petkaantonov/bluebird).

[Here is the test result](https://github.com/facebook/react-native/issues/361#issuecomment-87829808) showing a noticeable difference. (2x speed improvement)

Please refer to [this issue](https://github.com/facebook/react-native/issues/361) for more details.
Closes https://github.com/facebook/react-native/pull/516
Github Author: Pilwon Huh <pilwon@gmail.com>

Test Plan:
./runJestTests
start app and click around
2015-03-31 21:24:13 -08:00
James Ide
6638713d3c [Touchable] Change default activeOpacity to 0.2 to match iOS
Summary:
Closes https://github.com/facebook/react-native/pull/296
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 21:09:22 -08:00
Spencer Ahrens
b66710c6ed Merge pull request #314 from jordanna/issue/251
Fix WebView automaticallyAdjustContentInsets error
2015-03-31 21:53:44 -07:00
Christopher Chedeau
e8155c94dd [ReactNative] Normalize name for examples 2015-03-31 20:49:24 -08:00
Arthur Lee
2d42c9eb4a [ReactNative] Added support for 3 digit hex colors | Arthur Lee
Summary:
This addition adds a check for whether a hex color is 3 or 6 digits. If it is 3 digits, it will expand the short form into 6 digits, just like in CSS. The additional benefit of having the length check is that hex colors of invalid lengths (like 4 digits) will be considered invalid. In CSS, invalid length hex colors returns white, but here I have logged an error through `RCTLogError`.
Closes https://github.com/facebook/react-native/pull/455
Github Author: Arthur Lee <arthur@arthurlee.me>

Test Plan: Tried a couple of colors in the sample app, like `#FACEB0`, `#F00`, etc.
2015-03-31 20:05:14 -08:00
Amjad Masad
92a6c3e004 [react-packager] Fix EISDIR error 2015-03-31 19:49:05 -08:00
Don Yu
414d975370 make renderError and renderLoading props optional for WebView
Summary:
@vjeux Making the renderError and renderLoading props optional for WebView by setting the default to be what's shown for the WebView example in UIExplorer. issue #349
Closes https://github.com/facebook/react-native/pull/512
Github Author: Don Yu <donyu8@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 18:54:47 -08:00
Za1batsu
e49a0f0c57 Fixed image link for AddToSearchPaths.png
AddToSearchPaths.png failed to load properly. Fixed link to load same image from "react-native/website/src/react-native/img". Did not touch source code.
2015-03-31 19:27:54 -07:00
Za1batsu
5d2e3126ad Fixed broken image for AddToBuildPhases.png
Image for AddToBuildPhases.png failed to load. Fixed link to load same image from "react-native/website/src/react-native/img". Did not touch source code.
2015-03-31 19:21:29 -07:00
Christopher Chedeau
2bb10cdaf9 Merge pull request #557 from vjeux/update15
Updates from Tue 31 Mar
2015-03-31 19:07:28 -07:00
Amjad Masad
2ed74ef583 Merge pull request #533 from bretrouse/master
language fixes
2015-03-31 19:07:19 -07:00
Za1batsu
760aa0d1f1 Fixed broken image link for EmbeddedAppExample.png
Image link for EmbeddedAppExample.png failed to load. Fixed link to load original image. Did not touch source code.
2015-03-31 19:04:07 -07:00
Christopher Chedeau
18cb5d0711 Updates from Tue 31 Mar
- Bugfix/require module regexp | Amjad Masad
- [ReactNative] RCTView's shadowOffset is of float type, not CGFloat | Kevin Gozali
- Fix WebView automaticallyAdjustContentInsets error | Spencer Ahrens
- [react-native] map view - add onTouch** props | Jiajie Zhu
- [react-native] Fix documentation extraction for View | Ben Alpert
- [ReactNative] Add few hints in the UI | Alex Kotliarskyi
- Adding `scrollWithoutAnimationTo` method for ScrollViews | Felix Oghina
- [ScrollView] Add "bounces" property to ScrollView propTypes | Spencer Ahrens
- Fix a crash in RCTAsyncLocalStorage when the value is not a string. | Spencer Ahrens
- [ReactNative] Remove global MutationObserver to fix Bluebird feature detection | Christopher Chedeau
- [catalyst] fix typo | Jiajie Zhu
- [react-packager] check-in bluebird | Amjad Masad
- [react-native] v0.3.1 | Amjad Masad
- [Pod] Preserve header directory structure | Alex Akers
- [react-native] Bring React.render behavior in line with web | Ben Alpert
- Expose html prop on WebView | Spencer Ahrens
- missing '.' in ListView.DataSource example | Christopher Chedeau
- [react-native] Support returning null from a component | Ben Alpert
- [react-native] Fix race condition in removeSubviewsFromContainerWithID: | Ben Alpert
2015-03-31 19:01:48 -07:00
Za1batsu
6f5534eeea Fixed broken image link
Original link to image for EmbeddedAppContainerViewExample.png failed. Fixed link to load same image. Did not touch source code.
2015-03-31 18:57:25 -07:00
daviskoh
0ca3136371 Bugfix/require module regexp
Summary:
Resolves https://github.com/facebook/react-native/issues/316. Also updated the spec for the Haste Dependency Resolver. Not sure if these changes are the ones desired so feedback would be welcome!
Closes https://github.com/facebook/react-native/pull/368
Github Author: daviskoh <koh.davis.0@gmail.com>

Test Plan: ./runJestTests
2015-03-31 17:37:39 -08:00
Kevin Gozali
bb9c647c2b [ReactNative] RCTView's shadowOffset is of float type, not CGFloat 2015-03-31 17:18:20 -08:00
Jordanna Kwok
6870c27283 Fix WebView automaticallyAdjustContentInsets error
Summary:
WebView component's automaticallyAdjustContentInsets prop should be type BOOL. Fixes #251.
Closes https://github.com/facebook/react-native/pull/314
Github Author: Jordanna Kwok <jordannakwok@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 17:17:49 -08:00
Jiajie Zhu
571ade3ffc [react-native] map view - add onTouch** props 2015-03-31 16:52:49 -08:00
Ben Alpert
b2fc956858 [react-native] Fix documentation extraction for View 2015-03-31 16:20:14 -08:00
Alex Kotliarskyi
9e931e9d36 [ReactNative] Add few hints in the UI 2015-03-31 16:15:40 -08:00
Charlie Cheever
774442efd2 Adding scrollWithoutAnimationTo method for ScrollViews
Summary:
Implementing the consensus approach from the comments on
this PR:
https://github.com/facebook/react-native/pull/486

We use a boolean flag in the Obj-C code to determine whether
to animate or not, and then provide two public JS functions
that call the Obj-C with or without the flag.
Closes https://github.com/facebook/react-native/pull/509
Github Author: Charlie Cheever <ccheever@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 16:11:40 -08:00
tako-black
80baec3bb6 change words 2015-04-01 08:17:13 +09:00
James Ide
2f00cb05bd [ScrollView] Add "bounces" property to ScrollView propTypes
Summary:
The `bounces` property lets you disable rubber-banding. It was already exposed on the native side so this diff is just documenting it in JS.
Closes https://github.com/facebook/react-native/pull/264
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 15:15:17 -08:00
Janic Duplessis
8d7b6d9a99 Fix a crash in RCTAsyncLocalStorage when the value is not a string.
Summary:
When you forget to pass the value parameter to AsyncStorage.setItem the entire app would crash instead of showing a useful error message. The problem was that the error function used in the file expected a dictionary but was passed the value of the key which caused the crash.
Closes https://github.com/facebook/react-native/pull/535
Github Author: Janic Duplessis <janicduplessis@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-03-31 15:09:05 -08:00
Christopher Chedeau
c82893be8a [ReactNative] Remove global MutationObserver to fix Bluebird feature detection 2015-03-31 15:07:17 -08:00
Jiajie Zhu
a0998abd19 [catalyst] fix typo 2015-03-31 14:57:45 -08:00
Spencer Ahrens
e90ede3ce2 Merge pull request #317 from jcouyang/typos
fix typos, wrong closing tags
2015-03-31 15:20:38 -07:00
Christopher Chedeau
99b2a10afc Merge pull request #552 from andrewsardone/aps-embedded-app
Improve EmbeddedApp.md docs wrt location of ReactComponent (also minor formatting)
2015-03-31 14:45:45 -07:00
Andrew Sardone
2536716727 Fix some pissing a’s and the’s 2015-03-31 17:41:59 -04:00
Andrew Sardone
539ff6476a Fix some ‘CocoaPods’ capitalization 2015-03-31 17:40:59 -04:00
Amjad Masad
23e992a0a5 [react-packager] check-in bluebird 2015-03-31 13:35:18 -08:00
Andrew Sardone
1c3dd29c92 Tweak some concluding EmbeddedApp language 2015-03-31 17:34:09 -04:00
Andrew Sardone
3a6e4305ca Add instructions for pre-bundled JS in EmbeddedApp 2015-03-31 17:34:09 -04:00
Andrew Sardone
2ec88bdd8b Tweak copy around adding an outlet for ReactView 2015-03-31 17:34:09 -04:00
Andrew Sardone
5dac2cb093 Add concluding statement about React behind a UIView 2015-03-31 17:34:08 -04:00
Andrew Sardone
67a2790521 Tweak formatting to note class names in code blocks
I think this helps identify classes and code files as opposed to
emphasized prose.
2015-03-31 17:34:08 -04:00
Andrew Sardone
47f3a77227 Tweak some formatting of example index.ios.js 2015-03-31 17:34:08 -04:00
Andrew Sardone
f3ddef0ff3 Move ReactComponent out of Pods directory in EmbeddableApp
It doesn’t seem like a good practice to tell people to create their custom
ReactComponent directory inside of the Pods/ directory. The Pods/ directory
should be limited to CocoaPods installed content, and it’s not even
accepted across the board to [check this stuff into git][1]

Therefore, let’s tune the EmbeddableApp tutorial to instruct users to
create a ReactComponent directory at the root of their project. From there,
we’ll start the development server packager to source that directory as
a JS files root. This change also improves starting this packager server,
proxying the command through npm.

[1]: 5883804e6c/Objective-C.gitignore (L20-L26)
2015-03-31 17:34:08 -04:00
Andrew Sardone
48bcbecf8c Set demo script to 'use strict' for EmbeddedApp 2015-03-31 17:34:08 -04:00
Andrew Sardone
af8edb8e40 Add overview to ‘Create Your React Native App’ section
Hopefully this helps people how simple the process is!
2015-03-31 17:34:08 -04:00