react-native

Commit Graph

Author	SHA1	Message	Date
Kevin Cooper	e443b7379e	More verbose error messages for iOS Summary: Output the reason for the error when failing to load source code. This was a big help when trying to diagnose https://github.com/facebook/react-native/issues/13299. ~~Unfortunately there still seems to be no way to get the offending line number (because `loadError.userInfo[RCTJSStackTraceKey]` is empty), but this is good enough.~~ Before: ``` [warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError ``` After: ``` [warn][tid:com.facebook.react.JavaScript][RCTJSCErrorHandling.mm:30] Couldn't get stack trace for http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:81886 [warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError Unexpected keyword 'var' ``` Closes https://github.com/facebook/react-native/pull/13561 Differential Revision: D4908501 Pulled By: javache fbshipit-source-id: a316dc70739b917b3cc690309d0ff37a8bb5d412	2017-04-18 14:19:13 -07:00
Marc Horowitz	ba149d7277	Tease apart React and RCTBatchedBridge targets Reviewed By: javache Differential Revision: D4679655 fbshipit-source-id: 8123488c2d50dd7cc2329b5131e99998fe1f1e2f	2017-03-21 18:31:23 -07:00

Author

SHA1

Message

Date

Kevin Cooper

e443b7379e

More verbose error messages for iOS

Summary:
Output the reason for the error when failing to load source code. This was a big help when trying to diagnose https://github.com/facebook/react-native/issues/13299.

~~Unfortunately there still seems to be no way to get the offending line number (because `loadError.userInfo[RCTJSStackTraceKey]` is empty), but this is good enough.~~

Before:

```
[warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError
```

After:

```
[warn][tid:com.facebook.react.JavaScript][RCTJSCErrorHandling.mm:30] Couldn't get stack trace for http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:81886
[warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError Unexpected keyword 'var'
```
Closes https://github.com/facebook/react-native/pull/13561

Differential Revision: D4908501

Pulled By: javache

fbshipit-source-id: a316dc70739b917b3cc690309d0ff37a8bb5d412

2017-04-18 14:19:13 -07:00

Marc Horowitz

ba149d7277

Tease apart React and RCTBatchedBridge targets

Reviewed By: javache

Differential Revision: D4679655

fbshipit-source-id: 8123488c2d50dd7cc2329b5131e99998fe1f1e2f

2017-03-21 18:31:23 -07:00

2 Commits