status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-01 20:28:06 +00:00
Code Issues Projects Releases Wiki Activity
13,198 Commits 61 Branches 315 Tags 184 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Valentin Shergin
ee0cc6bbe7 Fabric: Implementing cloneAndReplaceChild() for ViewShadowNode 
Summary:
First, LayoutableShadowNode::cloneAndReplaceChild() is now pure virtual. The default implementation was useless and confusing.
Second, cloneAndReplaceChild() is now fully implemented for ViewShadowNode, so fancy Yoga Concurrent layout *should* work now.

Reviewed By: mdvacca

Differential Revision: D7376352

fbshipit-source-id: 1199a37e64535c8592a2a5480e60139f61d02006
 2018-03-25 22:48:18 -07:00
Valentin Shergin
a5a34565e0 Fabric: Proper return value of LayoutableShadowNode::setLayoutMetrics() 
Summary: `LayoutableShadowNode::setLayoutMetrics()` must return `false` is nothing was changes.

Reviewed By: fkgozali

Differential Revision: D7330334

fbshipit-source-id: 700d50b0047919fa2b919acfa72825f100cd496f
 2018-03-19 17:08:31 -07:00
Valentin Shergin
811d5bfc73 Introducing LayoutableShadowNode 
Summary: LayoutableShadowNode defines a unified interface (and set of primitives) essential for laying out shadow nodes.

Reviewed By: fkgozali

Differential Revision: D7230668

fbshipit-source-id: d8c1772d4c3bd1f87c41f7240a39aecebf3696ae
 2018-03-18 19:17:39 -07:00