react-native

Commit Graph

Author	SHA1	Message	Date
Eric Vicenti	65513e501a	Bug fix for nil TVView on pop Summary: Explain the motivation for making this change. What existing problem does the pull request solve? This change is required when you try to set a focus on a view that doesn't exist and thus cannot be focused. In my specific use case, this occurred when trying to set a focus on a list item in a setInterval when the View (with the specific list item) had been popped. The while loop ran infinitely (eventually freezing the app) since the rootView doesn't exist. This adds that check and breaks out if so. All obj-c tests ran successfully. dlowder-salesforce Closes https://github.com/facebook/react-native/pull/12073 Differential Revision: D4468989 Pulled By: ericvicenti fbshipit-source-id: 7926c887035722c983c41cb6b6d9df567010c2ee	2017-01-26 09:43:32 -08:00
Pieter De Baets	c92ad5f6ae	Apple TV support 4: support for input (tvOS focus engine) Reviewed By: shergin Differential Revision: D4333546 fbshipit-source-id: 8655070e81dbb62a80ab1f00a43ef6c2d9654618	2016-12-19 06:28:40 -08:00

Author

SHA1

Message

Date

Eric Vicenti

65513e501a

Bug fix for nil TVView on pop

Summary:
Explain the **motivation** for making this change. What existing problem does the pull request solve?

This change is required when you try to set a focus on a view that doesn't exist and thus cannot be focused. In my specific use case, this occurred when trying to set a focus on a list item in a setInterval when the View (with the specific list item) had been popped. The while loop ran infinitely (eventually freezing the app) since the rootView doesn't exist. This adds that check and breaks out if so.

All obj-c tests ran successfully.

dlowder-salesforce
Closes https://github.com/facebook/react-native/pull/12073

Differential Revision: D4468989

Pulled By: ericvicenti

fbshipit-source-id: 7926c887035722c983c41cb6b6d9df567010c2ee

2017-01-26 09:43:32 -08:00

Pieter De Baets

c92ad5f6ae

Apple TV support 4: support for input (tvOS focus engine)

Reviewed By: shergin

Differential Revision: D4333546

fbshipit-source-id: 8655070e81dbb62a80ab1f00a43ef6c2d9654618

2016-12-19 06:28:40 -08:00

2 Commits