b437d61475
Fix text node rounding with fractional dimensions matching the rounding factor
...
Summary:
If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction.
Fixes facebook/yoga#580 .
Closes https://github.com/facebook/yoga/pull/583
Reviewed By: marco-cova
Differential Revision: D5274212
Pulled By: emilsjolander
fbshipit-source-id: 1febf9194210437ab77f91319d10d4da9b284b79
2017-07-04 06:29:59 -07:00
ecd5829bf8
Overflow detection in Yoga
...
Reviewed By: gkassabli
Differential Revision: D5336645
fbshipit-source-id: c4f87d1754d7bac848e8d347b31d619393b94d2c
2017-06-30 09:33:52 -07:00
14538aa038
Export some more symbols
...
Reviewed By: alexeylang
Differential Revision: D5328772
fbshipit-source-id: 7122af7e9bcb14ecdb224fd63ea1be57e4c7f20e
2017-06-27 11:16:13 -07:00
83faa4b608
Simplify Catalyst handleMemoryPressure
...
Reviewed By: cwdick
Differential Revision: D5200555
fbshipit-source-id: 86f12acca33ece265d3482ba52de9afcc83173cd
2017-06-26 06:01:14 -07:00
e2dff82160
Fix visibility of installGlobalFunction(..)
...
Reviewed By: javache
Differential Revision: D5319733
fbshipit-source-id: cfe796f13920924bbdbdd2a2741a70f492a141f9
2017-06-26 05:15:42 -07:00
e2628f93b5
Rename Executor to JSExecutor
...
Summary:
* Cleanup some header files so we use more forward declarations
* Rename Executor to JSExecutor.h
* Move some typedefs to more appropriate locations
Reviewed By: mhorowitz
Differential Revision: D5301913
fbshipit-source-id: e75154797eb3f531d2f42a5e95409f4062b85f91
2017-06-23 17:01:25 -07:00
5c5410459e
Setting bridge up for sharing: allowing native modules to register after init
...
Reviewed By: javache
Differential Revision: D4945784
fbshipit-source-id: 80e7236e9ccd5d5c9a7fba7c96b98fc38b43a2fc
2017-06-21 12:08:45 -07:00
3b93ba9af7
The total flex factores need to be a minimum of 1 if any
...
Summary:
The only thing I found in the spec for this change is the following. Not exactly sure if this is the thing this PR is about:
> For each flex item, subtract its outer flex base size from its max-content contribution size. If that result is not zero, divide it by (if the result was positive) its **flex grow factor floored at 1** or (if the result was negative) by its scaled flex shrink factor, having **floored the flex shrink factor at 1**. This is the item’s max-content flex fraction.
But at least it seems a required change.
Fixes facebook/yoga#566
Closes https://github.com/facebook/yoga/pull/572
Differential Revision: D5264388
Pulled By: emilsjolander
fbshipit-source-id: 0004d1c3b9bad070a98cd6766c1adc06a54475f8
2017-06-16 07:46:28 -07:00
534bbfac8f
Report Java stack from errors from sync native module calls
...
Reviewed By: mhorowitz
Differential Revision: D5069794
fbshipit-source-id: ede314034a2eb6b063a22dbd6e5d13c8ad66e20c
2017-06-14 09:32:37 -07:00
c25f356675
Avoid crash when accessing jsContextRef without an executor
...
Reviewed By: adamjernst
Differential Revision: D5237039
fbshipit-source-id: 6a86da90605b896093e0ef99b0fcf079bf9854bf
2017-06-14 05:32:27 -07:00
f908cce679
Rounding error in width/height fixed
...
Reviewed By: emilsjolander
Differential Revision:
D5209073
Tags: accept2ship
fbshipit-source-id: a3a6a43767aa707ebfa5eee62a83adcdd88d7ce6
2017-06-10 05:35:55 -07:00
2984628357
add marker surrounding entire native module creation
...
Reviewed By: javache
Differential Revision: D5200856
fbshipit-source-id: 35b0e627224d518126a1cfdd36d6af264dd186cf
2017-06-09 06:22:39 -07:00
d062cc252e
Promise support for C++ bridge
...
Summary: Looks like `CxxModule::Method` already supports 0..2 callbacks. Based on Obj-C implementation (RCTModuleMethod.m:492) and JS bridge code (NativeModules.js:76), 2 callbacks native method is transformed to JS promise by JS part of the bridge.
Reviewed By: javache
Differential Revision: D5207852
fbshipit-source-id: 5aad86d45b97397f2bc3a4dbc648a60d96a4689e
2017-06-08 11:47:26 -07:00
ba2e486b33
Connection management
...
Reviewed By: javache
Differential Revision: D5171773
fbshipit-source-id: 6421739736f732e021e85474253ab0ddb3804b0a
2017-06-08 07:45:53 -07:00
81c2f3b189
Cleanup Platform
...
Reviewed By: dcaspi
Differential Revision: D5185504
fbshipit-source-id: 4f7e9f9068598418b346a7370f6be241a0784b60
2017-06-07 10:19:01 -07:00
63ffa7c2f6
Fixing a race condition that may be caused by the reloadable executor.
...
Reviewed By: javache
Differential Revision: D5139379
fbshipit-source-id: 24aa820caacfe3780d0e5a2f5868cdc46cefc3fb
2017-06-06 11:35:38 -07:00
7081391c3d
Simplify Value.fromJSON API
...
Reviewed By: mhorowitz
Differential Revision: D5154478
fbshipit-source-id: 3f9528a6401d89df7e170d55da9c0327db5f4f3e
2017-06-06 03:20:14 -07:00
79500f81a9
Fix Travis CI runs
...
Summary: Closes https://github.com/facebook/react-native/pull/14286
Differential Revision: D5164925
Pulled By: javache
fbshipit-source-id: 0ebe028ab58f37a9afc8b615fe346d7af9180040
2017-06-02 09:03:18 -07:00
bd5051adeb
Move xreact/jni to react/jni
...
Reviewed By: mhorowitz
Differential Revision: D5155612
fbshipit-source-id: 871a23916c0069498691dc0dd3c94fd2e404cec9
2017-06-01 05:53:25 -07:00
7c980c5ba5
Fix absolute position if wrap-reverse and align-items: flex-end
...
Summary:
This is a fix on top of 56b10fc. It takes the case into account were you have `wrap-reverse` and `align-items: flex-end` set.
Closes https://github.com/facebook/yoga/pull/568
Differential Revision: D5155521
Pulled By: emilsjolander
fbshipit-source-id: 7e5fcfa2fbb48b6c6279da46cc648a071ff2b079
2017-06-01 05:53:25 -07:00
ae49713342
Export more symbols on React Native
...
Reviewed By: skotchvail
Differential Revision: D5157649
fbshipit-source-id: 8d04dff3a8564d3a095591aa982c9b72ace9a8b7
2017-05-31 21:02:01 -07:00
b61999cf03
Make isCustomJSCWrapperSet and setCustomJSCWrapper visible when using arc focus --dylib
...
Reviewed By: skotchvail, javache
Differential Revision: D5148545
fbshipit-source-id: db6e595325d5275b5d5fdce4c4047965dc97125e
2017-05-31 12:48:20 -07:00
578227d83b
Adding the ability to run GC on a different thread than the one JSContext was created in
...
Reviewed By: javache
Differential Revision: D5121232
fbshipit-source-id: 28df89271c9d3f421ca27cf309ca0d3c756beba2
2017-05-31 11:17:41 -07:00
2766103291
Don't use folly::stringPrintf in jschelpers
...
Reviewed By: mhorowitz
Differential Revision: D5146873
fbshipit-source-id: 99224b0091ee0ea28e5dd132bcc65203d2dc43a6
2017-05-30 15:01:02 -07:00
fff3ad1336
Fix confusing variable name
...
Reviewed By: gkassabli
Differential Revision: D5144146
fbshipit-source-id: a5d711f8ad7049b0d96ee0f0f3eef1165ab3b4e8
2017-05-29 08:00:26 -07:00
adaa966272
Fix absolute positioning in reverse wrapping container
...
Reviewed By: gkassabli
Differential Revision: D5144145
fbshipit-source-id: da6ef999ec0aabacf499017d1cfa81fc8f66e4bd
2017-05-29 08:00:23 -07:00
6be550d85c
Changed pointScaleFactor usage to avoid accumulating error
...
Reviewed By: shergin
Differential Revision: D5137923
fbshipit-source-id: 652b59bc3da3f35ee93ffa3695936f623298a023
2017-05-26 11:03:06 -07:00
03e1f40c1e
Cleanup and document Value wrapper (retry)
...
Reviewed By: mhorowitz
Differential Revision: D5120975
fbshipit-source-id: 6e9c80a57fdcf7f3dad21d5521fb928b52c924c7
2017-05-26 04:17:19 -07:00
35b888dc11
Fix making loadScriptFromString always synchronous
...
Reviewed By: javache
Differential Revision: D5129620
fbshipit-source-id: a0ad5e2704fc38f4cdfe29187a2b59ba4b0ff61b
2017-05-25 16:47:06 -07:00
9f81baa834
Switch ComponentScript/iOS to new Buck integration
...
Reviewed By: adamjernst
Differential Revision: D5121635
fbshipit-source-id: 7b7aaf70c54c1c232130afd34071adff9cbe54e1
2017-05-25 15:35:05 -07:00
f46eaa30cf
Provide sync vs async interface for bundle loading via parameter
...
Reviewed By: javache
Differential Revision: D5104317
fbshipit-source-id: ffacb57d85c24795a3acc2faba2ff5824cc739b2
2017-05-24 07:31:36 -07:00
d59fd9e419
Revert D5087565: Cleanup and document Value wrapper
...
Differential Revision: D5087565
fbshipit-source-id: 8168bda39fac9384264e9d849b205a2c1d37dcfa
2017-05-24 07:31:36 -07:00
374d08b8e4
Cleanup and document Value wrapper
...
Reviewed By: mhorowitz
Differential Revision: D5087565
fbshipit-source-id: 21b15dc4c476d6ecd7c42f9334c6995fa43810c2
2017-05-24 06:30:51 -07:00
2e24197da3
Fixing potential measure call with negative size value
...
Reviewed By: emilsjolander
Differential Revision: D5111534
fbshipit-source-id: 99f09b85f0c6a0e5dec89a26baba8f9d560100da
2017-05-23 11:16:27 -07:00
130a82101c
Fix right/bottom in absolute layout.
...
Summary:
1, Change bottom to be based� on height of parent.
2, Respect margin value when layout with right/bottom.
Closes https://github.com/facebook/yoga/pull/552
Differential Revision: D5102090
Pulled By: emilsjolander
fbshipit-source-id: dca291413ffc2027d7628f4c8b8eeeb0b4823bc2
2017-05-22 03:01:27 -07:00
cf5535b86f
fix print edge value.
...
Summary: Closes https://github.com/facebook/yoga/pull/551
Differential Revision: D5069358
Pulled By: emilsjolander
fbshipit-source-id: 8a8f07043d43f9f2d846a645217a52913cffe31b
2017-05-21 06:50:00 -07:00
f98518c5f9
Add setPropertyAtIndex
...
Reviewed By: mhorowitz
Differential Revision: D5069708
fbshipit-source-id: f81542f9d752ff53acf3fb9d96bf71e60acecac3
2017-05-19 07:15:42 -07:00
056d075ef2
Fixing up header namespaces in ReactCommon
...
Reviewed By: mzlee
Differential Revision: D5079295
fbshipit-source-id: 03b848dedb41da900bb6ac69112bbb973a8a2595
2017-05-17 14:21:59 -07:00
c785763773
Fixing using flex in root node
...
Reviewed By: emilsjolander
Differential Revision: D5071164
fbshipit-source-id: b8afef42477d0ed87d0c9fcfd26349e0a0babd6e
2017-05-17 07:32:40 -07:00
f8b683b3ee
Copy-free Source loading implementation
...
Reviewed By: amnn
Differential Revision: D4914165
fbshipit-source-id: 38851679cb696c41f59edfd0d2005faf37813b23
2017-05-15 09:15:29 -07:00
c4fb32fa40
Correct YGNodeCanUseCachedMeasurement to account for non-existent scale factor
...
Reviewed By: emilsjolander
Differential Revision: D5061016
fbshipit-source-id: 907ef987bd0ead29cf02f6945a3f03d4ffb58a2e
2017-05-15 08:49:38 -07:00
baf93e46d0
Adding ability to account for rounding in YGNodeCanUseCachedMeasurement
...
Reviewed By: emilsjolander
Differential Revision: D5059560
fbshipit-source-id: d729e991758a8c668a4b373105b71337961875cd
2017-05-15 06:23:45 -07:00
6221053179
Improve systrace markers
...
Reviewed By: mhorowitz
Differential Revision: D4860135
fbshipit-source-id: ce963010883e6b9cc8e34f7ff01b4018cd195eba
2017-05-12 18:07:49 -07:00
fb99f55939
Fix compilation due to missing flag
...
Reviewed By: mhorowitz
Differential Revision: D5053975
fbshipit-source-id: cfb5e71d7c9c318fa1942ce9d4dc72b4f7c1e054
2017-05-12 13:31:24 -07:00
0a4ce80868
Fix typo causing wrapped children to be sized by wrong axis margin
...
Reviewed By: passy
Differential Revision: D5044470
fbshipit-source-id: 7d203dd48b258a5fe5c4b3c493099092a1d334db
2017-05-12 09:18:56 -07:00
67b96fc0ce
Include margin when calculating if children overflow
...
Reviewed By: passy
Differential Revision: D5044471
fbshipit-source-id: e7c1eb694445ffb898bcf375d9deefc558c49f11
2017-05-12 09:18:56 -07:00
54548894d0
Fix flex basis not accounting for max size constraint
...
Reviewed By: gkassabli
Differential Revision: D5044314
fbshipit-source-id: d9f9db832e4943a57a89c9d162ff6077b709795a
2017-05-12 09:18:56 -07:00
6e2c07534e
Fix Circle CI builds
...
Summary: Closes https://github.com/facebook/react-native/pull/13945
Differential Revision: D5052083
Pulled By: javache
fbshipit-source-id: eeda8253d26c2dfd0d20b93b238377fe92e3ca3c
2017-05-12 08:35:30 -07:00
afbab66a44
Define rn_xplat_cxx_library for OSS builds
...
Reviewed By: bestander
Differential Revision: D5044673
fbshipit-source-id: 41c9fe4b2ae128eed6f299dd8ea9dbfc4ca75917
2017-05-12 02:45:19 -07:00
103f4ee01f
Move JSBigString its own cxxreact target
...
Reviewed By: amnn
Differential Revision: D5020584
fbshipit-source-id: 9ba21c0231c3bb77973620669727205231a0b7a8
2017-05-11 09:01:30 -07:00
Lukas Wöhrl
Andrey Mishanin
Pieter De Baets
Alexey Lang
Kathy Gray
Marco Cova
Ben Nham
Alex Kotliarskyi
Theo Yaung
Dan Caspi
Pieter De Baets
Hoa Dinh
Emil Sjolander
Georgiy Kassabli
David Aurelio
yihuang
Ashok Menon
Dmitry Zakharov
Michael Lee