5 Commits

Author	SHA1	Message	Date
Valentin Shergin	2bb41031ba	Fabric: Introducing RootShadowNode ... Summary: `RootShadowNode` is a dedicated class for managing the root node. Reviewed By: mdvacca Differential Revision: D7857050 fbshipit-source-id: f15f4b177f03cea4c0fd5a60d761ee2745319d77	2018-05-08 23:03:36 -07:00
Valentin Shergin	6bbc2ec921	Fabric: Introcucing ConcreteComponentDescriptor::adopt() ... Summary: Overriding `adopt` method allows subclasses to configure just created or cloned shadow nodes without overriding `create` and `clone` methods. Reviewed By: mdvacca Differential Revision: D7738581 fbshipit-source-id: bfe4e4e2d3d448591a3267b5ea7ca4e0800f5ba0	2018-04-26 18:03:07 -07:00
Valentin Shergin	bd91eaf664	Fabric/Text: ShadowNode::clone() - dynamic self-cloning mechanism ... Summary: The previous approach simply didn't work. :( As you might notice, in previous implementation of ViewShadowNode::cloneAndReplaceChild we used `ViewShadowNode` class for cloning `childNode`, and this is incorrect becasue `childNode` might be instance of any class. Reviewed By: fkgozali Differential Revision: D7595016 fbshipit-source-id: 2215414926f2f7a2e2fd05ca2d065f10d6d32b74	2018-04-26 18:03:06 -07:00
Valentin Shergin	6924d44b20	Fabric: Fixed ConcreteShadowNode::getProps() ... Summary: Apparently, there is no point to return a reference from this method because the struct (std::shared_ptr) is allocated on stack. The test is also updated. allow-large-files Reviewed By: fkgozali Differential Revision: D7557749 fbshipit-source-id: aa74146322c6d340256752586f05fc672024038e	2018-04-10 17:15:08 -07:00
Valentin Shergin	6b0960cbdb	Introducing ConcreteShadowNode ... Summary: ConcreteShadowNode defines a template which connects typed Props and typed ShadowNode. Reviewed By: fkgozali Differential Revision: D7230667 fbshipit-source-id: be28314d6846d69960e921da852f01232951f965	2018-03-18 19:17:39 -07:00