5da0a9909e
Reset the hadOverflow flag at the beginning of the algorithm
...
Summary:
This fixes the case where we change the layout, so that it doesn't overflow anymore.
This also improves the readability by using `|=` instead of referencing the value twice.
Closes https://github.com/facebook/yoga/pull/587
Differential Revision: D5388657
Pulled By: emilsjolander
fbshipit-source-id: ce1b1ded1feed7314a2c16bf695f62b866c19ea0
2017-07-10 12:08:32 -07:00
79bf089bc5
Make visible to fix build when focusing on ReactKit
...
Reviewed By: dinhviethoa
Differential Revision: D5372827
fbshipit-source-id: 4cc718e88bc2da08b104d22ffc83691a62b1de4e
2017-07-06 19:46:45 -07:00
465a68db1f
Remove xcode_public_headers_symlinks from RN BUCK files
...
Reviewed By: dinhviethoa
Differential Revision: D5321259
fbshipit-source-id: b07ff4a01280251deb2113a62197d96d5c2e37a1
2017-07-06 12:16:20 -07:00
51afde821d
Remove some outdated references to xreact
...
Reviewed By: kathryngray
Differential Revision: D5339824
fbshipit-source-id: 486212dcf0e80036fa548a139e38358ae251ef2a
2017-07-04 08:00:44 -07:00
b437d61475
Fix text node rounding with fractional dimensions matching the rounding factor
...
Summary:
If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction.
Fixes facebook/yoga#580 .
Closes https://github.com/facebook/yoga/pull/583
Reviewed By: marco-cova
Differential Revision: D5274212
Pulled By: emilsjolander
fbshipit-source-id: 1febf9194210437ab77f91319d10d4da9b284b79
2017-07-04 06:29:59 -07:00
ecd5829bf8
Overflow detection in Yoga
...
Reviewed By: gkassabli
Differential Revision: D5336645
fbshipit-source-id: c4f87d1754d7bac848e8d347b31d619393b94d2c
2017-06-30 09:33:52 -07:00
14538aa038
Export some more symbols
...
Reviewed By: alexeylang
Differential Revision: D5328772
fbshipit-source-id: 7122af7e9bcb14ecdb224fd63ea1be57e4c7f20e
2017-06-27 11:16:13 -07:00
83faa4b608
Simplify Catalyst handleMemoryPressure
...
Reviewed By: cwdick
Differential Revision: D5200555
fbshipit-source-id: 86f12acca33ece265d3482ba52de9afcc83173cd
2017-06-26 06:01:14 -07:00
e2dff82160
Fix visibility of installGlobalFunction(..)
...
Reviewed By: javache
Differential Revision: D5319733
fbshipit-source-id: cfe796f13920924bbdbdd2a2741a70f492a141f9
2017-06-26 05:15:42 -07:00
e2628f93b5
Rename Executor to JSExecutor
...
Summary:
* Cleanup some header files so we use more forward declarations
* Rename Executor to JSExecutor.h
* Move some typedefs to more appropriate locations
Reviewed By: mhorowitz
Differential Revision: D5301913
fbshipit-source-id: e75154797eb3f531d2f42a5e95409f4062b85f91
2017-06-23 17:01:25 -07:00
5c5410459e
Setting bridge up for sharing: allowing native modules to register after init
...
Reviewed By: javache
Differential Revision: D4945784
fbshipit-source-id: 80e7236e9ccd5d5c9a7fba7c96b98fc38b43a2fc
2017-06-21 12:08:45 -07:00
3b93ba9af7
The total flex factores need to be a minimum of 1 if any
...
Summary:
The only thing I found in the spec for this change is the following. Not exactly sure if this is the thing this PR is about:
> For each flex item, subtract its outer flex base size from its max-content contribution size. If that result is not zero, divide it by (if the result was positive) its **flex grow factor floored at 1** or (if the result was negative) by its scaled flex shrink factor, having **floored the flex shrink factor at 1**. This is the item’s max-content flex fraction.
But at least it seems a required change.
Fixes facebook/yoga#566
Closes https://github.com/facebook/yoga/pull/572
Differential Revision: D5264388
Pulled By: emilsjolander
fbshipit-source-id: 0004d1c3b9bad070a98cd6766c1adc06a54475f8
2017-06-16 07:46:28 -07:00
534bbfac8f
Report Java stack from errors from sync native module calls
...
Reviewed By: mhorowitz
Differential Revision: D5069794
fbshipit-source-id: ede314034a2eb6b063a22dbd6e5d13c8ad66e20c
2017-06-14 09:32:37 -07:00
c25f356675
Avoid crash when accessing jsContextRef without an executor
...
Reviewed By: adamjernst
Differential Revision: D5237039
fbshipit-source-id: 6a86da90605b896093e0ef99b0fcf079bf9854bf
2017-06-14 05:32:27 -07:00
f908cce679
Rounding error in width/height fixed
...
Reviewed By: emilsjolander
Differential Revision:
D5209073
Tags: accept2ship
fbshipit-source-id: a3a6a43767aa707ebfa5eee62a83adcdd88d7ce6
2017-06-10 05:35:55 -07:00
2984628357
add marker surrounding entire native module creation
...
Reviewed By: javache
Differential Revision: D5200856
fbshipit-source-id: 35b0e627224d518126a1cfdd36d6af264dd186cf
2017-06-09 06:22:39 -07:00
d062cc252e
Promise support for C++ bridge
...
Summary: Looks like `CxxModule::Method` already supports 0..2 callbacks. Based on Obj-C implementation (RCTModuleMethod.m:492) and JS bridge code (NativeModules.js:76), 2 callbacks native method is transformed to JS promise by JS part of the bridge.
Reviewed By: javache
Differential Revision: D5207852
fbshipit-source-id: 5aad86d45b97397f2bc3a4dbc648a60d96a4689e
2017-06-08 11:47:26 -07:00
ba2e486b33
Connection management
...
Reviewed By: javache
Differential Revision: D5171773
fbshipit-source-id: 6421739736f732e021e85474253ab0ddb3804b0a
2017-06-08 07:45:53 -07:00
81c2f3b189
Cleanup Platform
...
Reviewed By: dcaspi
Differential Revision: D5185504
fbshipit-source-id: 4f7e9f9068598418b346a7370f6be241a0784b60
2017-06-07 10:19:01 -07:00
63ffa7c2f6
Fixing a race condition that may be caused by the reloadable executor.
...
Reviewed By: javache
Differential Revision: D5139379
fbshipit-source-id: 24aa820caacfe3780d0e5a2f5868cdc46cefc3fb
2017-06-06 11:35:38 -07:00
7081391c3d
Simplify Value.fromJSON API
...
Reviewed By: mhorowitz
Differential Revision: D5154478
fbshipit-source-id: 3f9528a6401d89df7e170d55da9c0327db5f4f3e
2017-06-06 03:20:14 -07:00
79500f81a9
Fix Travis CI runs
...
Summary: Closes https://github.com/facebook/react-native/pull/14286
Differential Revision: D5164925
Pulled By: javache
fbshipit-source-id: 0ebe028ab58f37a9afc8b615fe346d7af9180040
2017-06-02 09:03:18 -07:00
bd5051adeb
Move xreact/jni to react/jni
...
Reviewed By: mhorowitz
Differential Revision: D5155612
fbshipit-source-id: 871a23916c0069498691dc0dd3c94fd2e404cec9
2017-06-01 05:53:25 -07:00
7c980c5ba5
Fix absolute position if wrap-reverse and align-items: flex-end
...
Summary:
This is a fix on top of 56b10fc. It takes the case into account were you have `wrap-reverse` and `align-items: flex-end` set.
Closes https://github.com/facebook/yoga/pull/568
Differential Revision: D5155521
Pulled By: emilsjolander
fbshipit-source-id: 7e5fcfa2fbb48b6c6279da46cc648a071ff2b079
2017-06-01 05:53:25 -07:00
ae49713342
Export more symbols on React Native
...
Reviewed By: skotchvail
Differential Revision: D5157649
fbshipit-source-id: 8d04dff3a8564d3a095591aa982c9b72ace9a8b7
2017-05-31 21:02:01 -07:00
b61999cf03
Make isCustomJSCWrapperSet and setCustomJSCWrapper visible when using arc focus --dylib
...
Reviewed By: skotchvail, javache
Differential Revision: D5148545
fbshipit-source-id: db6e595325d5275b5d5fdce4c4047965dc97125e
2017-05-31 12:48:20 -07:00
578227d83b
Adding the ability to run GC on a different thread than the one JSContext was created in
...
Reviewed By: javache
Differential Revision: D5121232
fbshipit-source-id: 28df89271c9d3f421ca27cf309ca0d3c756beba2
2017-05-31 11:17:41 -07:00
2766103291
Don't use folly::stringPrintf in jschelpers
...
Reviewed By: mhorowitz
Differential Revision: D5146873
fbshipit-source-id: 99224b0091ee0ea28e5dd132bcc65203d2dc43a6
2017-05-30 15:01:02 -07:00
fff3ad1336
Fix confusing variable name
...
Reviewed By: gkassabli
Differential Revision: D5144146
fbshipit-source-id: a5d711f8ad7049b0d96ee0f0f3eef1165ab3b4e8
2017-05-29 08:00:26 -07:00
adaa966272
Fix absolute positioning in reverse wrapping container
...
Reviewed By: gkassabli
Differential Revision: D5144145
fbshipit-source-id: da6ef999ec0aabacf499017d1cfa81fc8f66e4bd
2017-05-29 08:00:23 -07:00
6be550d85c
Changed pointScaleFactor usage to avoid accumulating error
...
Reviewed By: shergin
Differential Revision: D5137923
fbshipit-source-id: 652b59bc3da3f35ee93ffa3695936f623298a023
2017-05-26 11:03:06 -07:00
03e1f40c1e
Cleanup and document Value wrapper (retry)
...
Reviewed By: mhorowitz
Differential Revision: D5120975
fbshipit-source-id: 6e9c80a57fdcf7f3dad21d5521fb928b52c924c7
2017-05-26 04:17:19 -07:00
35b888dc11
Fix making loadScriptFromString always synchronous
...
Reviewed By: javache
Differential Revision: D5129620
fbshipit-source-id: a0ad5e2704fc38f4cdfe29187a2b59ba4b0ff61b
2017-05-25 16:47:06 -07:00
9f81baa834
Switch ComponentScript/iOS to new Buck integration
...
Reviewed By: adamjernst
Differential Revision: D5121635
fbshipit-source-id: 7b7aaf70c54c1c232130afd34071adff9cbe54e1
2017-05-25 15:35:05 -07:00
f46eaa30cf
Provide sync vs async interface for bundle loading via parameter
...
Reviewed By: javache
Differential Revision: D5104317
fbshipit-source-id: ffacb57d85c24795a3acc2faba2ff5824cc739b2
2017-05-24 07:31:36 -07:00
d59fd9e419
Revert D5087565: Cleanup and document Value wrapper
...
Differential Revision: D5087565
fbshipit-source-id: 8168bda39fac9384264e9d849b205a2c1d37dcfa
2017-05-24 07:31:36 -07:00
374d08b8e4
Cleanup and document Value wrapper
...
Reviewed By: mhorowitz
Differential Revision: D5087565
fbshipit-source-id: 21b15dc4c476d6ecd7c42f9334c6995fa43810c2
2017-05-24 06:30:51 -07:00
2e24197da3
Fixing potential measure call with negative size value
...
Reviewed By: emilsjolander
Differential Revision: D5111534
fbshipit-source-id: 99f09b85f0c6a0e5dec89a26baba8f9d560100da
2017-05-23 11:16:27 -07:00
130a82101c
Fix right/bottom in absolute layout.
...
Summary:
1, Change bottom to be based� on height of parent.
2, Respect margin value when layout with right/bottom.
Closes https://github.com/facebook/yoga/pull/552
Differential Revision: D5102090
Pulled By: emilsjolander
fbshipit-source-id: dca291413ffc2027d7628f4c8b8eeeb0b4823bc2
2017-05-22 03:01:27 -07:00
cf5535b86f
fix print edge value.
...
Summary: Closes https://github.com/facebook/yoga/pull/551
Differential Revision: D5069358
Pulled By: emilsjolander
fbshipit-source-id: 8a8f07043d43f9f2d846a645217a52913cffe31b
2017-05-21 06:50:00 -07:00
f98518c5f9
Add setPropertyAtIndex
...
Reviewed By: mhorowitz
Differential Revision: D5069708
fbshipit-source-id: f81542f9d752ff53acf3fb9d96bf71e60acecac3
2017-05-19 07:15:42 -07:00
056d075ef2
Fixing up header namespaces in ReactCommon
...
Reviewed By: mzlee
Differential Revision: D5079295
fbshipit-source-id: 03b848dedb41da900bb6ac69112bbb973a8a2595
2017-05-17 14:21:59 -07:00
c785763773
Fixing using flex in root node
...
Reviewed By: emilsjolander
Differential Revision: D5071164
fbshipit-source-id: b8afef42477d0ed87d0c9fcfd26349e0a0babd6e
2017-05-17 07:32:40 -07:00
f8b683b3ee
Copy-free Source loading implementation
...
Reviewed By: amnn
Differential Revision: D4914165
fbshipit-source-id: 38851679cb696c41f59edfd0d2005faf37813b23
2017-05-15 09:15:29 -07:00
c4fb32fa40
Correct YGNodeCanUseCachedMeasurement to account for non-existent scale factor
...
Reviewed By: emilsjolander
Differential Revision: D5061016
fbshipit-source-id: 907ef987bd0ead29cf02f6945a3f03d4ffb58a2e
2017-05-15 08:49:38 -07:00
baf93e46d0
Adding ability to account for rounding in YGNodeCanUseCachedMeasurement
...
Reviewed By: emilsjolander
Differential Revision: D5059560
fbshipit-source-id: d729e991758a8c668a4b373105b71337961875cd
2017-05-15 06:23:45 -07:00
6221053179
Improve systrace markers
...
Reviewed By: mhorowitz
Differential Revision: D4860135
fbshipit-source-id: ce963010883e6b9cc8e34f7ff01b4018cd195eba
2017-05-12 18:07:49 -07:00
fb99f55939
Fix compilation due to missing flag
...
Reviewed By: mhorowitz
Differential Revision: D5053975
fbshipit-source-id: cfb5e71d7c9c318fa1942ce9d4dc72b4f7c1e054
2017-05-12 13:31:24 -07:00
0a4ce80868
Fix typo causing wrapped children to be sized by wrong axis margin
...
Reviewed By: passy
Differential Revision: D5044470
fbshipit-source-id: 7d203dd48b258a5fe5c4b3c493099092a1d334db
2017-05-12 09:18:56 -07:00
67b96fc0ce
Include margin when calculating if children overflow
...
Reviewed By: passy
Differential Revision: D5044471
fbshipit-source-id: e7c1eb694445ffb898bcf375d9deefc558c49f11
2017-05-12 09:18:56 -07:00
54548894d0
Fix flex basis not accounting for max size constraint
...
Reviewed By: gkassabli
Differential Revision: D5044314
fbshipit-source-id: d9f9db832e4943a57a89c9d162ff6077b709795a
2017-05-12 09:18:56 -07:00
6e2c07534e
Fix Circle CI builds
...
Summary: Closes https://github.com/facebook/react-native/pull/13945
Differential Revision: D5052083
Pulled By: javache
fbshipit-source-id: eeda8253d26c2dfd0d20b93b238377fe92e3ca3c
2017-05-12 08:35:30 -07:00
afbab66a44
Define rn_xplat_cxx_library for OSS builds
...
Reviewed By: bestander
Differential Revision: D5044673
fbshipit-source-id: 41c9fe4b2ae128eed6f299dd8ea9dbfc4ca75917
2017-05-12 02:45:19 -07:00
103f4ee01f
Move JSBigString its own cxxreact target
...
Reviewed By: amnn
Differential Revision: D5020584
fbshipit-source-id: 9ba21c0231c3bb77973620669727205231a0b7a8
2017-05-11 09:01:30 -07:00
70b7488f97
Adding node type and moving rounding dependency to rely on that type
...
Reviewed By: emilsjolander
Differential Revision: D5025107
fbshipit-source-id: a8d66e2f9c5d02ab080784cc474be583a09b92e2
2017-05-11 08:17:58 -07:00
01460873da
Move jschelpers to fb_xplat_cxx_library
...
Reviewed By: bestander
Differential Revision: D5035858
fbshipit-source-id: 110fc5140ee4930634ef2ac3453d0a84124516f9
2017-05-11 06:35:36 -07:00
19e6557d2e
Cleanup cxxreact BUCK file
...
Reviewed By: mzlee
Differential Revision: D5020563
fbshipit-source-id: 286a2d1c44623b5b9fd923ef8684d263500791b3
2017-05-11 05:04:02 -07:00
65f22a5190
log script name with bundle loading perf event
...
Reviewed By: javache
Differential Revision: D5010638
fbshipit-source-id: 2e139201a8374245fa1dedc4f11a716dcf700fd7
2017-05-10 04:09:19 -07:00
3dfed2e865
Explicitely export some symbols since they can be referenced from outside that library.
...
Differential Revision: D5024612
fbshipit-source-id: 6d75ebce9422c879bfc0acdb1159be72756a2f15
2017-05-08 19:48:47 -07:00
7876ffec5e
Fixes Travis error reporting
...
Summary:
Just cherry-picked my commit from #508
Closes https://github.com/facebook/yoga/pull/542
Differential Revision: D5002335
Pulled By: emilsjolander
fbshipit-source-id: 3f61a235c41627e9cfb90dce150323f11892e65f
2017-05-04 07:43:24 -07:00
5f2edfcca5
Move YGLogger into YGConfig and associate YGNodeRef with log events
...
Summary:
Moves the `YGLogger` into `YGConfig` and pass the `YGNodeRef` into the logger to be able to associate the log messages and assertions with the specific node.
Tackles facebook/yoga#530 and facebook/yoga#446
Closes https://github.com/facebook/yoga/pull/531
Reviewed By: astreet
Differential Revision: D4970149
Pulled By: emilsjolander
fbshipit-source-id: b7fcdaa273143ea2fa35861620b2e4d79f04f0af
2017-05-03 09:30:55 -07:00
ac74d2a38b
Refactor interfaces
...
Reviewed By: johnislarry
Differential Revision: D4844786
fbshipit-source-id: f348b8d5078643636343f6ea099b200f519fbc40
2017-05-02 21:31:41 -07:00
d199d1d65a
Fix useLegacyStretchBehaviour flag by simplifying its usage
...
Reviewed By: gkassabli
Differential Revision: D4977923
fbshipit-source-id: cb488e63c7c2e15e4c0f0133a16df36580c646fd
2017-05-01 04:45:20 -07:00
1c0e3b8b5b
Treat measured nodes size as a minimun contraint when rounding
...
Reviewed By: shergin
Differential Revision: D4972290
fbshipit-source-id: 0a7bcc7f47b3e5acb8745da5286abcb9c4e44a38
2017-04-30 03:16:37 -07:00
992e37c8bc
Fix sizing of non strech items
...
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. This introduces a new useLegacyStretchBehaviour flag on the config to opt out of this change as it is breaking.
See facebook/yoga#505
Closes https://github.com/facebook/yoga/pull/506
Reviewed By: astreet
Differential Revision: D4954016
Pulled By: emilsjolander
fbshipit-source-id: d28bd5d174cd76951fb94df85e3b0cfab7f81ff7
2017-04-28 06:18:30 -07:00
00a0343a6d
Revert D4957570: [yoga] Consolidate measure cache for layout nodes and leaf nodes
...
Differential Revision: D4957570
fbshipit-source-id: 4d30de37c6911aac2dc1243a54914515aabfb229
2017-04-28 04:04:14 -07:00
6272ef87bc
Consolidate measure cache for layout nodes and leaf nodes
...
Reviewed By: astreet
Differential Revision: D4957570
fbshipit-source-id: 5c5f39b67bd3f72d92b939ecee2d9a46c80b583f
2017-04-27 13:15:56 -07:00
1a72d91cb2
Remove rounding from experimental features
...
Reviewed By: gkassabli
Differential Revision: D4953838
fbshipit-source-id: 3ee5f27d92f95b3ed4a01c98bc35e9157f2e91c5
2017-04-27 07:27:26 -07:00
925ec01e01
Let measure behave more like on the web
...
Summary:
Nodes with a measure function needs to be measured even so it seems there is no available space. So it behaves more like on the web. Fix facebook/yoga#488
Closes https://github.com/facebook/yoga/pull/499
Reviewed By: astreet
Differential Revision: D4954008
Pulled By: emilsjolander
fbshipit-source-id: 5b6d9afae0cdebe33f8b82b67620b3b4527d1efc
2017-04-27 07:27:26 -07:00
f71e3b80b9
Add YGConfigCopy
...
Summary: Closes https://github.com/facebook/yoga/pull/525
Differential Revision: D4953723
Pulled By: emilsjolander
fbshipit-source-id: 1c54f40dfae5054822a440edf9d0aafb22a465d9
2017-04-26 12:00:49 -07:00
c660d0c836
Fix flex-wrap with max constraint
...
Summary:
Fixes `flex-wrap` with a max constraint and `justify-content`. Fixes facebook/yoga#514 .
Closes https://github.com/facebook/yoga/pull/519
Differential Revision: D4953727
Pulled By: emilsjolander
fbshipit-source-id: 32dec48220be1392ea8dac5f34871d407eb8d49b
2017-04-26 11:31:56 -07:00
a8fa904179
New round-to-pixel-grid algorithm that fixes possible subpixel gaps between sibling nodes
...
Reviewed By: emilsjolander
Differential Revision: D4941266
fbshipit-source-id: 07500f5cc93c628219500e9e07291438e9d5d36c
2017-04-25 17:30:40 -07:00
34bc6bd2ae
Drop support for webworkers
...
Reviewed By: AaaChiuuu
Differential Revision: D4916449
fbshipit-source-id: a447233d3b7cfee98db2ce00f1c0505d513e2429
2017-04-25 05:37:54 -07:00
1bc9d448f5
Port perf metrics used in RCTBatchedBridge
...
Reviewed By: javache
Differential Revision: D4938279
fbshipit-source-id: c927261ff96c2eb07b7303ae96aae7600f2947f1
2017-04-25 02:32:25 -07:00
6b0c72fa82
Correcting Flex fix within Experimental feature
...
Reviewed By: emilsjolander
Differential Revision: D4915189
fbshipit-source-id: efccee2fe39ed0f474a41dc3250d24c546f3f5d9
2017-04-19 13:29:59 -07:00
c29449d573
Revert D4875343: Correct fix for flexing grandchildren
...
Differential Revision: D4875343
fbshipit-source-id: 2949762bf47e151c8c0ff923d501859b3e0a567a
2017-04-13 18:09:30 -07:00
569525d6e4
Revert D4850458: [yoga][PR] Let measure behave more like on the web
...
Differential Revision: D4850458
fbshipit-source-id: 2ecb6c8627a84b52ade968fd18331a7473369ebe
2017-04-13 15:45:37 -07:00
c3dc6a0f0e
Revert D4878875: [yoga][PR] Fix sizing of non strech items
...
Differential Revision: D4878875
fbshipit-source-id: 8927438e7a1969deb617434369af53f71f625638
2017-04-13 10:01:55 -07:00
62360e8981
Let measure behave more like on the web
...
Summary:
Nodes with a measure function needs to be measured even so it seems there is no available space. So it behaves more like on the web. Fix facebook/yoga#488
Closes https://github.com/facebook/yoga/pull/499
Differential Revision: D4850458
Pulled By: emilsjolander
fbshipit-source-id: be5e35a670ddcbf3cd426fc3c2a0c9b60a874cdc
2017-04-13 08:49:43 -07:00
831ad4adc6
Correct fix for flexing grandchildren
...
Reviewed By: emilsjolander
Differential Revision: D4875343
fbshipit-source-id: 634e961f9798dff43eae2c6564b28c6629b816e0
2017-04-13 08:49:43 -07:00
a82de9509f
Fix sizing of non strech items
...
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See facebook/yoga#505
Closes https://github.com/facebook/yoga/pull/506
Differential Revision: D4878875
Pulled By: emilsjolander
fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
2017-04-13 07:57:21 -07:00
f26a99764a
Fix min constraint incorrectly reducing available space
...
Summary:
If a min constraint exists. It incorrectly reduces the available space by that amount. This adds a test and fix for this.
Closes https://github.com/facebook/yoga/pull/501
Differential Revision: D4867146
Pulled By: emilsjolander
fbshipit-source-id: ceafe070bfe7f501929d316656ac44c4e1753059
2017-04-11 13:09:38 -07:00
f7fe9a6219
Fix position on root node with RTL direction
...
Summary:
If the root node has a position and we have a RTL layout, that position must be like LTR direction. See #477 .
Closes https://github.com/facebook/yoga/pull/502
Differential Revision: D4867144
Pulled By: emilsjolander
fbshipit-source-id: b5ad3d87e7054090da12d7665a3d1abe8496a548
2017-04-11 13:09:38 -07:00
ecd0df01af
Add YGConfigGetInstanceCount
...
Summary:
- depends on #496
- For memory leak unit test
- Expose the API for C#
Closes https://github.com/facebook/yoga/pull/497
Reviewed By: emilsjolander
Differential Revision: D4796190
Pulled By: splhack
fbshipit-source-id: 99e4e78e8dfb3d459cf6cd7103ab252c3748e5a6
2017-04-10 14:24:25 -07:00
f3dfd616f4
Allow lazy Cxx modules to not initialize
...
Reviewed By: mhorowitz
Differential Revision: D4851596
fbshipit-source-id: cf5f5c51b9aaa0da96f7ab6fba1277b72c988400
2017-04-08 15:18:08 -07:00
b2647ea335
Allow ModuleRegistry initialization to complete lazily
...
Reviewed By: mhorowitz
Differential Revision: D4794794
fbshipit-source-id: f3b7a5d02587b4cd4e214aa6b0368a0d214fb63f
2017-04-07 09:30:33 -07:00
5f37483466
Revert D4840716: Refactor interfaces
...
Differential Revision: D4840716
fbshipit-source-id: 1b6a6050d78ccbbd3c817621df1c1c989594fdb1
2017-04-06 06:03:10 -07:00
fd99330b6c
Refactor interfaces
...
Reviewed By: johnislarry
Differential Revision: D4840716
fbshipit-source-id: 1a82437c81ce5b767efd39ab0716998bab4f5363
2017-04-06 00:04:06 -07:00
67e54f8bdb
Add YGEnums to fix gradle build
...
Summary:
Attempt to fix CircleCI build by adding YGEnums to the yoga gradle file
Closes https://github.com/facebook/react-native/pull/13296
Differential Revision: D4827856
Pulled By: ericvicenti
fbshipit-source-id: cb03af77919c811d06352fbe0b77084e97d2e6c1
2017-04-04 12:01:43 -07:00
c128612c5c
A proxy so a singleton CxxModule can be shared by multiple ModuleRegistry instances.
...
Reviewed By: mhorowitz
Differential Revision: D4814438
fbshipit-source-id: db6cdd9e948643bb24a443bd45b7b0843a0a86c2
2017-04-04 10:36:19 -07:00
0ec984e69a
Optimize log print by using html format
...
Summary:
See facebook/yoga#453 . Optimizes the node log print by generating some enum text via ```enum.py``` and moving printing to new functions to reduce boilerplate code.
Changes the log output to format the nodes in html to be able to copy paste it into browsers for quick debugging.
Hides all default values.
Closes https://github.com/facebook/yoga/pull/479
Reviewed By: gkassabli
Differential Revision: D4802184
Pulled By: emilsjolander
fbshipit-source-id: 143bd63cbc31fb0755d711062cb4e6a448049ba3
2017-04-03 09:45:47 -07:00
673093eed0
Set web defaults when resetting
...
Reviewed By: astreet
Differential Revision: D4779742
fbshipit-source-id: 5b8c5d7bd432a12984e4ebfd3187da3d680272cd
2017-03-29 03:17:28 -07:00
4bf2d8cb7d
Set hasNewLayout on children when changing their layout due to display none parent
...
Reviewed By: astreet
Differential Revision: D4786615
fbshipit-source-id: 2f3a16661d37bc37939e8e7a551445886a06524e
2017-03-28 12:47:51 -07:00
ff7fb6efda
Allow overrides of NativeModules
...
Reviewed By: mhorowitz
Differential Revision: D4764126
fbshipit-source-id: 036f848f8b3debbb3cc4a34fc99044304615760e
2017-03-24 05:04:05 -07:00
dcf3cbeb31
Clean up some of the ReactNative Buck rules
...
Reviewed By: yangchi
Differential Revision: D4739284
fbshipit-source-id: 0ee335df0d114631e5fc60d5d6e51547e5312d39
2017-03-23 12:02:25 -07:00
9d377e98a0
Fix warnings in React.xcodeproj
...
Summary:
Various fixes of xcode projects and cleaning up some warnings
Closes https://github.com/facebook/react-native/pull/13109
Differential Revision: D4762652
Pulled By: lacker
fbshipit-source-id: b452976a58962439de4adecc8e703264af40cb38
2017-03-23 11:36:17 -07:00
314ec87269
Remove unused CxxMessageQueue
...
Differential Revision: D4713064
fbshipit-source-id: 511b782279b89076228f00290e78ed155e2e723e
2017-03-21 12:46:27 -07:00
6dc3a83e88
Don't load native module support as part of the initial CS bundle
...
Reviewed By: javache
Differential Revision: D4720386
fbshipit-source-id: cd8b6137aaff2d907adf089060bf7d356cd2f437
2017-03-20 13:25:33 -07:00
47d2cfeac5
Whitelist some stuff in React
...
Reviewed By: mzlee
Differential Revision: D4731968
fbshipit-source-id: 1d1ae12a50beef4cd024a467427ec3b6cd446f4c
2017-03-19 14:01:09 -07:00
09b8ef41e1
Fix issue with whitespace in path to source and stabilise CI.
...
Summary:
* Fixes issue where headers could not be found due to whitespace in an unquoted header search path. https://github.com/facebook/react-native/issues/11781#issuecomment-287176373
* Stabilises CI but not needing to download the source for Yoga, but use the existing cloned repo instead.
/cc mkonicek
Closes https://github.com/facebook/react-native/pull/13007
Differential Revision: D4735347
fbshipit-source-id: 933aefcb0e65537d2e759d25f4e3b81cdf4b8cb5
2017-03-18 12:31:37 -07:00
Lukas Wöhrl
Grace Ku
Pieter De Baets
Andrey Mishanin
Alexey Lang
Kathy Gray
Marco Cova
Ben Nham
Alex Kotliarskyi
Theo Yaung
Dan Caspi
Pieter De Baets
Hoa Dinh
Emil Sjolander
Georgiy Kassabli
David Aurelio
yihuang
Ashok Menon
Dmitry Zakharov
Michael Lee
Maël Nison
Cheng Zhao
Valentin Shergin
George Xu
Kazuki Sakamoto
Martin Kralik
Eric Vicenti
Marc Horowitz
Adam Ernst
Eloy Durán