Commit Graph

31 Commits

Author SHA1 Message Date
Kenji Miwa 08b8216e4f Uninstall app before testing the production build
Summary:
Otherwise you may get the error `"Package <package_name> signatures do not match the previously installed version; ignoring!`

<details>
  Thanks for submitting a PR! Please read these instructions carefully:

  - [ ] Explain the **motivation** for making this change.
  - [ ] Provide a **test plan** demonstrating that the code is solid.
  - [ ] Match the **code formatting** of the rest of the codebase.
  - [ ] Target the `master` branch, NOT a "stable" branch.

  Please read the [Contribution Guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md) to learn more about contributing to React Native.
</details>

_What existing problem does the pull request solve?_

_A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website._
Closes https://github.com/facebook/react-native/pull/14577

Differential Revision: D5272060

Pulled By: AaaChiuuu

fbshipit-source-id: 23d88b8dddc4a7d8c6f58361a1cbcd8e6bb750d3
2017-06-23 20:31:17 -07:00
Brian Kabiro 42acab9bd2 Corrected a minor error
Summary:
Not sure if that is how it's supposed to read but tried to correct it

Thanks for submitting a PR! Please read these instructions carefully:

- [ ] Explain the **motivation** for making this change.
- [x] Provide a **test plan** demonstrating that the code is solid.
- [x] Match the **code formatting** of the rest of the codebase.
- [x] Target the `master` branch, NOT a "stable" branch.

What existing problem does the pull request solve?

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.

If you have added code that should be tested, add tests.

Sign the [CLA][2], if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged.

For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines.

[1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9
[2]: https://code.facebook.com/cla
[3]: https://travis-ci.org/facebook/react-native
[4]: http://circleci.com/gh/facebook/react-native
[5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests
Closes https://github.com/facebook/react-native/pull/14085

Differential Revision: D5103609

Pulled By: javache

fbshipit-source-id: 483661b149761cf6d27fb43990272312d781cc6f
2017-05-22 07:01:51 -07:00
Hector Ramos c503dae446 Merge Android UI Performance into Performance doc, reorder sidebar
Summary:
Doing some cleanup in preparation for CRNA.
Recommend `FlatList` and React Navigation for perf.
Tag docs that may only apply to apps ejected from CRNA. Currently has no effect.
Closes https://github.com/facebook/react-native/pull/12692

Differential Revision: D4654077

Pulled By: hramos

fbshipit-source-id: 1245d80d66e37d9dca9e9daf23e8b93c65cd1bf7
2017-03-06 10:10:04 -08:00
Sung Won Cho 7e2d7f0c98 Replace the outdated flag
Summary:
**Motivation**

Documentation was referring to an outdated command line flag for building a signed APK. https://github.com/facebook/react-native/issues/12698

**Test plan**

This PR does not contain any code changes.
Closes https://github.com/facebook/react-native/pull/12699

Differential Revision: D4655915

fbshipit-source-id: fdad86e0be60929525172022980f1950c8b0188d
2017-03-04 00:16:29 -08:00
C. T. Lin 29a996c83e variant -> configuration
Summary: Closes https://github.com/facebook/react-native/pull/11909

Differential Revision: D4432605

Pulled By: hramos

fbshipit-source-id: 760d043da383aa14a331d8420f6f28647edb046c
2017-01-23 11:28:51 -08:00
Yao Bin 69b17ff48e Update SignedAPKAndroid.md
Summary:
Update docs to prevent build process from failing when collaborators do not have MYAPP_RELEASE_STORE_FILE in their env.

Build process often fails when following the existing documentation on setting the signingConfigs in build.gradle, as not all collaborators have the required ENV set in their gradle.properties
Closes https://github.com/facebook/react-native/pull/11716

Differential Revision: D4389150

Pulled By: hramos

fbshipit-source-id: 37941382950fac41f19d19317f49769588b135b4
2017-01-06 15:43:29 -08:00
Jacob Jimenez e7e65a36b9 Updated a command
Summary:
The command at line 90 does not work anymore, updated to reflect current revision.
Closes https://github.com/facebook/react-native/pull/11635

Differential Revision: D4389138

Pulled By: hramos

fbshipit-source-id: 4ac071ba2d47aa6bfbe7fb2ccaaf9800aa9e7e68
2017-01-06 15:13:29 -08:00
Héctor Ramos 72369ee4d2 Consolidate Running on Device (Android|iOS) Guides into one
Summary:
The RunningOnDeviceAndroid doc had some Linux-specific instructions that are not relevant to macOS/Windows users.
Closes https://github.com/facebook/react-native/pull/10726

Differential Revision: D4139089

Pulled By: JoelMarcey

fbshipit-source-id: cc57c1d7e3c9dec94e123c3597ac78b3efb15dd0
2016-11-06 21:13:32 -08:00
Ben Bodenmiller c2fd4d48bf add keytool for Windows details
Summary:
Specify where to find `keytool` on Windows as current command does not normally work.
Closes https://github.com/facebook/react-native/pull/10215

Differential Revision: D4049285

Pulled By: lacker

fbshipit-source-id: f7033e9a596c472181ca75c927cd1efb4b6cf35d
2016-10-19 18:58:45 -07:00
YuTin Liu ce82428b15 docs(android): install release for android
Summary:
maybe, it is a better command.
Closes https://github.com/facebook/react-native/pull/9057

Differential Revision: D3674229

fbshipit-source-id: 0767371646c75c5743214b2695064fb61666c7c4
2016-08-04 22:13:29 -07:00
Joel Marcey b1e49832ef Make prev links work in guides and APIs.
Summary:
We had rendering support for prev links, but we never had any previous links in our metadata. Only next links. This adds that support to both Guides and APIs.

**For guides**: `previous` is manually inserted into the metadata of the actual markdown file.
**For APIs/Components**: `previous` is established via code within `extractDocs.js`

> This isn't totally perfect. For example, the transition from the last guide to the first API/component has a next link from the guide, but not a previous link from the API since the way you get the previous links are different from guides and APIs. But this gets us really close.
Closes https://github.com/facebook/react-native/pull/8754

Differential Revision: D3557972

Pulled By: hramos

fbshipit-source-id: e270bb51e7a4f59f61dad28ae0928d27d0af3d4a
2016-07-13 14:58:27 -07:00
Tom Walters 4e3a8343b3 Convert warning about keystore into warning block in SignedAPKAndroid.md
Summary:
The current docs page [Generating a Signed APK](https://facebook.github.io/react-native/docs/signed-apk-android.html) contains a note about keeping your generated keystore safe, but this isn't well highlighted.

This commit highlights the notice in a warning blockquote to ensure people following the guide don't miss the importance of keeping the keystore safe as shown below:

<img width="666" alt="screen shot 2016-06-06 at 10 01 25" src="https://cloud.githubusercontent.com/assets/1863808/15817245/10e4e6d2-2bcf-11e6-9fe8-defc8a6ec93c.png">
Closes https://github.com/facebook/react-native/pull/7948

Differential Revision: D3393005

fbshipit-source-id: e9c2666a79134eccc1b1868fe850ee896e63266e
2016-06-06 10:28:33 -07:00
Viktor Eriksson 8b314726e9 Option to not store credentials in file
Summary:**Motivation:** I don't like storing credentials in config files and a safer solution is to store them in the Keychain Access app.

Therefore I added a link that describes how one may go about to store the passwords in the Keychain Access app in OSX instead.

Found a [stackoverflow post](http://stackoverflow.com/a/24480579/1836121) but it wasn't very detailed so I decided to write it up myself. I understand if you have some policy against external links to blogs and I guess we could link to the stackoverflow explanation then instead.
Closes https://github.com/facebook/react-native/pull/7089

Differential Revision: D3207215

fb-gh-sync-id: 8011b55efe41ec6d54ad665e0e6a79cb9d806779
fbshipit-source-id: 8011b55efe41ec6d54ad665e0e6a79cb9d806779
2016-04-21 04:08:23 -07:00
Marcelo Kanzaki 37caef246d Update SignedAPKAndroid.md
Summary:From the documentation I thought I only had to sign an application if I intended to publish it to the Play Store. Turns out this is not true. Signing is still required if you want to install the APK on any device at all. Unsigned APK's are for simulators only.
Closes https://github.com/facebook/react-native/pull/6795

Differential Revision: D3133747

fb-gh-sync-id: ae91111cb20984ebe8ac2443971b373a3f4c848e
fbshipit-source-id: ae91111cb20984ebe8ac2443971b373a3f4c848e
2016-04-06 09:04:20 -07:00
Pimm Hogeling c2c71ca21c "loosing"→"losing" (typo)
Summary:♥
Closes https://github.com/facebook/react-native/pull/6273

Differential Revision: D3006141

fb-gh-sync-id: 393e05b3a747cc905a1aae1505ed8c7e770f7835
shipit-source-id: 393e05b3a747cc905a1aae1505ed8c7e770f7835
2016-03-03 09:30:36 -08:00
Martin Konicek 41789e7929 Simplify docs on generating Android release APK
Reviewed By: mkonicek

Differential Revision:D2939525
Ninja: Open source docs only

fb-gh-sync-id: bf5d0cd84a148bf366e15d22f934721151a35ef4
shipit-source-id: bf5d0cd84a148bf366e15d22f934721151a35ef4
2016-02-16 10:56:55 -08:00
Konstantin Raev 6f1417c849 CI now builds docs website and deploys it to /%version% path
Summary:
Copy of #5760 reverted merge.

We need to preserve history of docs changes on the webserver.
The goal is to allow users to browse outdated versions of docs.
To make things simple all websites will be released to https://facebook.github.io/react-native/releases/version/XX folder when there is a branch cut.

I switched from Travis CI to Cirle CI because it works faster and I am more familiar with it.

How it works:

1. If code is pushed to `master` branch then CI will build a fresh version of docs and put it in https://github.com/facebook/react-native/tree/gh-pages/releases/next folder.
Github will serve this website from https://facebook.github.io/react-native/releases/version/next URL.
All relative URLs will work within that website

2. If code is pushed to `0.20-stable` branch then CI will build a fresh version of docs and put it in https://github.com/facebook/react-native/tree/gh-pages/releases/0.20 folder.
Github will serve this website from https://facebook.github.io/react-native/releases/v
Closes https://github.com/facebook/react-native/pull/5873

Reviewed By: svcscm

Differential Revision: D2926901

Pulled By: androidtrunkagent

fb-gh-sync-id: 16aea430bac815933d9c603f03921cc6353906f1
shipit-source-id: 16aea430bac815933d9c603f03921cc6353906f1
2016-02-11 06:17:42 -08:00
Satyajit Sahoo c4f882a59f [Docs] Syntax highlight gradle code 2015-11-29 10:13:06 +05:30
Andy Street d2c50451f9 Add documentation for systrace 2015-11-10 16:50:38 +00:00
Felix Oghină 880a06a4b2 [docs] add bundle and upgrade docs 2015-10-22 19:11:38 +01:00
Martin Konicek 3fce0a9d61 Update SignedAPKAndroid.md 2015-10-09 17:12:05 +01:00
Martin Konicek c5af96b471 Update SignedAPKAndroid.md 2015-10-09 17:11:25 +01:00
Martin Konicek fcf1103b95 Update SignedAPKAndroid.md 2015-10-09 17:10:43 +01:00
Martin Konicek 87ae707985 Update SignedAPKAndroid.md 2015-10-09 17:08:34 +01:00
Martin Konicek 2d206f7286 Update SignedAPKAndroid.md 2015-10-09 17:06:55 +01:00
Martin Konicek 5209114534 Update SignedAPKAndroid.md 2015-10-09 17:00:12 +01:00
Martin Konicek faeeb1567e Update SignedAPKAndroid.md 2015-10-09 16:55:07 +01:00
Martin Konicek 26f5f1ffc8 Update SignedAPKAndroid.md 2015-10-09 15:37:06 +01:00
Martin Konicek de0e039898 Update SignedAPKAndroid.md 2015-10-09 14:30:58 +01:00
Satyajit Sahoo c22e143a1d Fix typos 2015-09-27 00:03:41 +05:30
Satyajit Sahoo fba9fbbced Added docs about generating a signed APK 2015-09-27 00:01:10 +05:30