4 Commits

Author	SHA1	Message	Date
Valentin Shergin	7e84cadc9c	Fabric: Refined conception and usage of Sealable ... Summary: Slightly new approach: Some non-const methods might not always mutate objects, so sometimes we should call `ensureUnsealed()` only inside conditional branches where we actually mutate an instance. Reviewed By: fkgozali Differential Revision: D7467793 fbshipit-source-id: 1b9f229cf6816e54e0df36699a571fdb612d3c3c	2018-04-10 12:59:50 -07:00
Valentin Shergin	ee0cc6bbe7	Fabric: Implementing cloneAndReplaceChild() for ViewShadowNode ... Summary: First, LayoutableShadowNode::cloneAndReplaceChild() is now pure virtual. The default implementation was useless and confusing. Second, cloneAndReplaceChild() is now fully implemented for ViewShadowNode, so fancy Yoga Concurrent layout *should* work now. Reviewed By: mdvacca Differential Revision: D7376352 fbshipit-source-id: 1199a37e64535c8592a2a5480e60139f61d02006	2018-03-25 22:48:18 -07:00
Valentin Shergin	a5a34565e0	Fabric: Proper return value of LayoutableShadowNode::setLayoutMetrics() ... Summary: `LayoutableShadowNode::setLayoutMetrics()` must return `false` is nothing was changes. Reviewed By: fkgozali Differential Revision: D7330334 fbshipit-source-id: 700d50b0047919fa2b919acfa72825f100cd496f	2018-03-19 17:08:31 -07:00
Valentin Shergin	811d5bfc73	Introducing LayoutableShadowNode ... Summary: LayoutableShadowNode defines a unified interface (and set of primitives) essential for laying out shadow nodes. Reviewed By: fkgozali Differential Revision: D7230668 fbshipit-source-id: d8c1772d4c3bd1f87c41f7240a39aecebf3696ae	2018-03-18 19:17:39 -07:00