react-native

Commit Graph

Author	SHA1	Message	Date
Adam Comella	9304df3e3d	For file uploads, don't stomp on developer's Content-Type header Summary: Currently when doing a file upload, the Content-Type header gets set to whatever MIME type iOS computed for the file. The Content-Type header the developer provided never takes precedence. For example, when uploading an image, iOS might determine that the MIME type is "image/jpeg" and so this would be the Content-Type of the HTTP request. But the developer might need the Content-Type to be "application/octet-stream". With this change, if the developer provides a Content-Type header, it will not be overriden. There is only one exception to this rule which is for "multipart" requests. In this case, the developer's Content-Type header is always ignored. This is because the Content-Type header needs to contain the boundary string and that information is not available to the developer in JavaScript. This change makes iOS's behavior more consistent with Android's. Test plan (required) In a small test app, verified that the developer's Content-Type header takes precedence when it's provided. Verif Closes https://github.com/facebook/react-native/pull/9651 Differential Revision: D3820001 Pulled By: mkonicek fbshipit-source-id: fdb8871f88a0d0db1ae59f75bb62b896fe69542d	2016-09-05 14:58:40 -07:00
Marc Horowitz	a8cf12a932	Fix some unsafe thread behavior Reviewed By: javache Differential Revision: D3789293 fbshipit-source-id: 80118c7f8faf487fe35d4d83a91f023219f6bf80	2016-09-01 19:58:58 -07:00

Author

SHA1

Message

Date

Adam Comella

9304df3e3d

For file uploads, don't stomp on developer's Content-Type header

Summary:
Currently when doing a file upload, the Content-Type header gets set to whatever MIME type iOS computed for the file. The Content-Type header the developer provided never takes precedence.

For example, when uploading an image, iOS might determine that the MIME type is "image/jpeg" and so this would be the Content-Type of the HTTP request. But the developer might need the Content-Type to be "application/octet-stream". With this change, if the developer provides a Content-Type header, it will not be overriden.

There is only one exception to this rule which is for "multipart" requests. In this case, the developer's Content-Type header is always ignored. This is because the Content-Type header needs to contain the boundary string and that information is not available to the developer in JavaScript.

This change makes iOS's behavior more consistent with Android's.

**Test plan (required)**

In a small test app, verified that the developer's Content-Type header takes precedence when it's provided. Verif
Closes https://github.com/facebook/react-native/pull/9651

Differential Revision: D3820001

Pulled By: mkonicek

fbshipit-source-id: fdb8871f88a0d0db1ae59f75bb62b896fe69542d

2016-09-05 14:58:40 -07:00

Marc Horowitz

a8cf12a932

Fix some unsafe thread behavior

Reviewed By: javache

Differential Revision: D3789293

fbshipit-source-id: 80118c7f8faf487fe35d4d83a91f023219f6bf80

2016-09-01 19:58:58 -07:00

2 Commits