react-native

Commit Graph

Author	SHA1	Message	Date
Valentin Shergin	9ea7957958	Fabric: Do not crash in attempt to mount layout-only components Summary: We do not have a clear strategy how to deal with layout-only (view-less) components. Even if this particular solution is not so fancy, it prevents crashing during text rendering. Reviewed By: mdvacca Differential Revision: D7785885 fbshipit-source-id: f3ed8988aa2b41349fd1693c2a7f8c9368daee43	2018-05-08 19:24:10 -07:00
Valentin Shergin	11833714d9	Fabric: RCTMountItemProtocol and five base mount items Summary: MountItem is a small granular light-weight instruction describing a change in the component view tree. All instruction are supposed to be small and standard. All additional logic must be implemented in component view subclasses. No more opaque and untyped objcblocks. All that allows mounting manager to control and optimize an execution of those items (eventually). Besides that five we probably will need `perform imperative instruction` (for execution something like `scrollTo`) and `update local data` (for updating local state of something like text input). Reviewed By: mdvacca Differential Revision: D7507518 fbshipit-source-id: 745b93125231a02cbc152cfa6c6baf423d100f81	2018-04-10 17:15:07 -07:00

Author

SHA1

Message

Date

Valentin Shergin

9ea7957958

Fabric: Do not crash in attempt to mount layout-only components

Summary: We do not have a clear strategy how to deal with layout-only (view-less) components. Even if this particular solution is not so fancy, it prevents crashing during text rendering.

Reviewed By: mdvacca

Differential Revision: D7785885

fbshipit-source-id: f3ed8988aa2b41349fd1693c2a7f8c9368daee43

2018-05-08 19:24:10 -07:00

Valentin Shergin

11833714d9

Fabric: RCTMountItemProtocol and five base mount items

Summary:
MountItem is a small granular light-weight instruction describing a change in the component view tree.
All instruction are supposed to be small and standard. All additional logic must be implemented in component view subclasses.
No more opaque and untyped objcblocks.
All that allows mounting manager to control and optimize an execution of those items (eventually).

Besides that five we probably will need `perform imperative instruction` (for execution something like `scrollTo`) and `update local data` (for updating local state of something like text input).

Reviewed By: mdvacca

Differential Revision: D7507518

fbshipit-source-id: 745b93125231a02cbc152cfa6c6baf423d100f81

2018-04-10 17:15:07 -07:00

2 Commits