Summary:Version exposes the sdk level (which TBH is more useful anyways), not a version string.
Closes https://github.com/facebook/react-native/pull/6068
Differential Revision: D2971198
fb-gh-sync-id: 0ba1e10e48b2ca51c7b0cebcc1ec13d0b69df783
shipit-source-id: 0ba1e10e48b2ca51c7b0cebcc1ec13d0b69df783
Summary:There is no toTime method on a Date object, It should be getTime.
Closes https://github.com/facebook/react-native/pull/6054
Differential Revision: D2971217
fb-gh-sync-id: 4140be25f0704f251cc0e2f47db8fa83992dc0f0
shipit-source-id: 4140be25f0704f251cc0e2f47db8fa83992dc0f0
Summary:This is meant to help people who are just quickly scanning through the docs.
Please let me know of other ways this could be formatted to be more readable.
Closes https://github.com/facebook/react-native/pull/6102
Differential Revision: D2965869
fb-gh-sync-id: 00b9a29444709d409d34a1c016b52a03bf18d116
shipit-source-id: 00b9a29444709d409d34a1c016b52a03bf18d116
Summary:This clarifies where the configuration goes, saves a few clicks.
Closes https://github.com/facebook/react-native/pull/6034
Differential Revision: D2965844
fb-gh-sync-id: d6ea469ead0dc380f1686e62a2211e8736c75516
shipit-source-id: d6ea469ead0dc380f1686e62a2211e8736c75516
Summary:The version of 0.17 will cause error ("undefined is not an object (evaluating 'screenPhysicalPixels.width')") when run to devices/simulator.
also see https://github.com/facebook/react-native/issues/5963
Closes https://github.com/facebook/react-native/pull/6076
Differential Revision: D2960511
fb-gh-sync-id: bd71de789fa1501b285b9bde01cf12ab9ce75888
shipit-source-id: bd71de789fa1501b285b9bde01cf12ab9ce75888
Summary:Turns out we had two guides for the same thing.
Closes#6007
Reviewed By: mkonicek
Differential Revision:D2949234
Ninja: oss-only
fb-gh-sync-id: eda3a904ce8d8e7213a39021eb60b52449b20a43
shipit-source-id: eda3a904ce8d8e7213a39021eb60b52449b20a43
Summary:
We should use 4 spaces of indentation in the MainActivity template as this
is the most common setting outside fb.
public
Reviewed By: bestander
Differential Revision: D2911952
fb-gh-sync-id: 3b5285945f0033d7342348b7a7cbafa32809f7dc
shipit-source-id: 3b5285945f0033d7342348b7a7cbafa32809f7dc
Summary:
Put the transform list up to date and add a polyfill section
Closes https://github.com/facebook/react-native/pull/5793
Reviewed By: svcscm
Differential Revision: D2910585
Pulled By: vjeux
fb-gh-sync-id: c67852654241def4a826d6d694ad6fc9cb849264
Summary:
public
Due to the cross-platform polyfills we have added (and will add in future) to `UIManager.js`, accessing UIManager directly via NativeModules instead of importing the wrapper is discouraged.
This diff fixes a few places where we were doing this inside our own modules.
Note: As a general policy, we should avoid accessing modules via NativeModules anyway. Using wrapper classes allows us to provide static declarations for all the native methods and properties, which can be checked at build time by flow. If we access the modules directly, those interfaces are only known at runtime.
Reviewed By: vjeux
Differential Revision: D2881300
fb-gh-sync-id: 6737358ea8ea6d722cc1941a4b9fa0123a87fc29
Summary:
We no longer need to manually build JS bundle, everything should be integrated into Xcode.
Closes https://github.com/facebook/react-native/pull/5521
Reviewed By: svcscm
Differential Revision: D2860511
Pulled By: martinbigio
fb-gh-sync-id: fdde6b39aabccd5a39c140d431acbbbe5af71ec4
Summary:
maybe it is a bug when migrating from es5 to es6
Closes https://github.com/facebook/react-native/pull/5526
Reviewed By: svcscm
Differential Revision: D2860047
Pulled By: androidtrunkagent
fb-gh-sync-id: d8be261eea08ec659999fe8c714f33aca6fe3a60
Summary:
Didn't found someone that updated that, feel free to close if that is the case.
Closes https://github.com/facebook/react-native/pull/5415
Reviewed By: svcscm
Differential Revision: D2841576
Pulled By: androidtrunkagent
fb-gh-sync-id: 99b37fcb370453ce71fa83434f7c72b598375ef0
Summary:
npm 3 is working fine especially if you use shrinkwrap at the end. we've been using it for a month+ and the dependency deduping works well.
Closes https://github.com/facebook/react-native/pull/5391
Reviewed By: svcscm
Differential Revision: D2839472
Pulled By: androidtrunkagent
fb-gh-sync-id: 33e551185236694ee5979da701312f12e2582f3c
The error message wasn't very helpful. I didn't understand the problem
until I debugged the `RCTJavaScriptLoader`. So this might be to help for
others.
Squashed commits by @andrewsardone into @hfossli’s [original
commit][oc]:
[oc]: 39fa5ca95b
- Expand App Transport Security docs w/ localhost tip
- Tweak ATS error note in EmbeddedAppIOS docs
- Per @satya164’s [recommendation][r], using the exact copy he
recommended.
[r]: https://github.com/facebook/react-native/pull/5290#discussion_r49843876
Lucas Feliciano
Martin Konicek
Peter Piekarczyk
Daniel Friesen
Xing Zheng
Jason Axelson
Dotan J. Nahum
DebbieFire
Janic Duplessis
briancaw
sunnylqm
Mateusz Zatorski
David Young-chan Kay
Konstantin Raev
Alex Krolick
Thomas Parslow
Kevin Johnson
Konstantin Raev
Corentin Smith
Christopher Chedeau
Christopher Chedeau
Richard Lai
Ahmed Abbas
Nick Lockwood
Harry Moreno
Alexander Kotliarskyi
张亦驰
Moz Morris
Satyajit Sahoo
Jean-Richard Lai
James Ide
Martin Konicek
Håvard Fossli
Oleg Lokhvitsky
Brent Vatne
BerndWessels
Seth Ladd
Jack Hsu
