752863629d
RN: Fix Type for ReactNative.NativeComponent (2/2)
...
Reviewed By: TheSavior
Differential Revision: D7984936
fbshipit-source-id: d0477c54420b49220e9529fa70c2b2babce0b409
2018-05-13 01:05:57 -07:00
de11ba2a5e
RN: Fix Type for ReactNative.NativeComponent (1/2)
...
Reviewed By: TheSavior
Differential Revision: D7984814
fbshipit-source-id: 0097819128b7f82267bceeb9d5e1b5057c5129ec
2018-05-13 01:05:56 -07:00
41a940392c
RN: Add Missing Events to ViewPropTypes
...
Reviewed By: TheSavior
Differential Revision: D7984937
fbshipit-source-id: fc2703e3382a7515b71f8a634aca5b6d7a5b25b4
2018-05-13 01:05:56 -07:00
3d3edfc3da
Replace magic numbers with `safeAreaInsets` in `RCTDevLoadingView`
...
Summary:
This PR replaces magic numbers used for offsetting `RCTDevLoadingView` when running on iPhone X, in favour of `safeAreaInsets`.
Tested on iPhone X and iPhone 8. Here is a screenshot showing how it looks on iPhone X.
Closes https://github.com/facebook/react-native/pull/19119
Differential Revision: D7984823
Pulled By: hramos
fbshipit-source-id: 0c7c3ba0fa258a64f6c4a1e0620f87bf0620984c
2018-05-12 23:25:09 -07:00
870775ee73
Stop expose Image.resizeMode
...
Summary:
Exposing this enum is essentially useless and at worst is a runtime cost that isn't necessary by just using the string.
The value of this enum, as far as I understand it, is to enforce that only valid options are used. We can enforce this at build time with Flow.
I was able to migrate our codebase with a few Find and Replace for things like
```
resizeMode={Image.resizeMode.contain}
```
Reviewed By: yungsters
Differential Revision: D7983982
fbshipit-source-id: ddd7024023f8d2f01aad1fff6c8103983a1bec1a
2018-05-12 23:25:09 -07:00
a9a612bfb6
Making ImageURISource exact
...
Reviewed By: yungsters
Differential Revision: D7984204
fbshipit-source-id: ccd2627b72da5c97f046c895652fdf7cc0b3db40
2018-05-12 23:25:09 -07:00
0fe72579be
Image cleanup
...
Reviewed By: yungsters
Differential Revision: D7983744
fbshipit-source-id: c6c1c78fd93b40553688f1444b57074802520f7e
2018-05-12 23:25:09 -07:00
44743c07ad
Flow Type TouchableOpacity
...
Reviewed By: yungsters
Differential Revision: D7983709
fbshipit-source-id: 0f664c831b754277e344aa53b2dbed6b4f720cd5
2018-05-12 23:25:09 -07:00
6cfa4a360d
TouchableOpacity @noflow -> @flow
...
Reviewed By: yungsters
Differential Revision: D7983644
fbshipit-source-id: bf4a0ba600ac51ef07ac12927eed29eeb92ffb2a
2018-05-12 23:25:09 -07:00
f0c18dc820
Flow type TouchableHighlight
...
Reviewed By: yungsters
Differential Revision: D7983631
fbshipit-source-id: 98b3708b26e2bf96426d5acaa5c7e2311a3a34f6
2018-05-12 23:25:09 -07:00
6b3aad31f6
Remove unused suppressions
...
Reviewed By: yungsters
Differential Revision: D7983271
fbshipit-source-id: ee64e2dacbc8a1b75915b825f7bf0621a121422d
2018-05-12 23:25:08 -07:00
0b79d1faa2
Type TouchableWithoutFeedback
...
Reviewed By: yungsters
Differential Revision: D7982348
fbshipit-source-id: 409ce4a5ea8c09e58c42caf9db60117253503c4c
2018-05-12 23:25:08 -07:00
91c4b0357a
Remove unused suppressions
...
Reviewed By: yungsters
Differential Revision: D7982027
fbshipit-source-id: 00e538dc678275495e097d9cd14a0a2643ebaefd
2018-05-12 10:35:27 -07:00
b127662279
Flow Type ScrollView
...
Reviewed By: yungsters
Differential Revision: D7981073
fbshipit-source-id: 38c100f37e46683da1e34b335d476e706baae238
2018-05-12 10:35:27 -07:00
188b118b60
Flow Type KeyboardAvoidingView
...
Reviewed By: yungsters
Differential Revision: D7978494
fbshipit-source-id: e21b4910470d3dc3fd35027f2f975b6842baa6ab
2018-05-12 10:35:27 -07:00
97e572ea6d
Flow Type DatePickerIOS.ios.js
...
Reviewed By: yungsters
Differential Revision: D7978090
fbshipit-source-id: 65da360f34f4b6d9240a8343c89be66404767474
2018-05-12 10:35:27 -07:00
0b71d1ddb0
Flow Typing ActivityIndicator
...
Reviewed By: yungsters
Differential Revision: D7977834
fbshipit-source-id: 62e54f98ee8f9e7d5189fc19c803a95f5c4c43aa
2018-05-12 10:35:27 -07:00
f19ee28e7d
Adding $FlowFixMe to invalid prop accesses
...
Reviewed By: yungsters
Differential Revision: D7977387
fbshipit-source-id: 442e7445be62f78bdf166a2b97ef031e39877355
2018-05-12 10:35:27 -07:00
7ba7acdee7
Surfacing Flow issues around invalid props
...
Reviewed By: yungsters
Differential Revision: D7977386
fbshipit-source-id: a6df2d75e0caa55a84f9c9c6860f622942955dfc
2018-05-12 10:35:27 -07:00
65c336f38f
Make ViewProps Exact
...
Reviewed By: yungsters
Differential Revision: D7976755
fbshipit-source-id: f6a0da1023a9235763c7ecb3ca7a9238887d0471
2018-05-12 10:35:27 -07:00
bc658d3c44
Spread TVViewProps into ViewProps instead of intersection
...
Reviewed By: yungsters
Differential Revision: D7976556
fbshipit-source-id: ca2f6bcac249a937523c4b50add8960085a8be49
2018-05-12 10:35:26 -07:00
dbc9364b21
Fabric FB4A integration
...
Reviewed By: fkgozali
Differential Revision: D7953706
fbshipit-source-id: 406f8340eb3706dc07dcd32dcfaa5bdc06981aa1
2018-05-11 19:16:14 -07:00
4767f9be45
v0.72.0 in xplat/js
...
Reviewed By: gabelevi
Differential Revision: D7956747
fbshipit-source-id: b1993de405c273b3cc1ed74f994e8e75bda0a985
2018-05-11 17:50:35 -07:00
c1e6f27823
Bump to Node 8
...
Summary:
Moving to Node 8 in React Native will allow us to be consistent with Facebook, e.g. trailing commas.
As of April 30, Node 4.x is end of life, and Node 6.x entered maintenance mode (see https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742 ).
This will require our docs to be updated to require Node 8 as a minimum. This should be done as part of the following PR: https://github.com/facebook/react-native-website/pull/355
Circle CI already runs all JS tests using Node 8, and it has an extra compatibility check that uses Node 6. This workflow is dropped as we no longer need to check for failures when Node 6 is used.
See https://github.com/facebook/react-native/issues/19226
[GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8
Closes https://github.com/facebook/react-native/pull/19230
Differential Revision: D7979478
Pulled By: hramos
fbshipit-source-id: c91ec118f0a59c4daae5fcdbfc822ccead591304
2018-05-11 17:32:19 -07:00
75ff136f03
Load 'ReactFabric' only when it is required to render a Fabric component
...
Reviewed By: yungsters
Differential Revision: D7970603
fbshipit-source-id: 34676b9e174bc1e1141f4f435aa2c8e2b62cd5b9
2018-05-11 17:18:03 -07:00
b762f5293e
Decouple the Worker options from the Babel Transformer options
...
Reviewed By: jeanlauliac
Differential Revision: D7894079
fbshipit-source-id: 40cbd991690f25f8c0f045c42a0105d74d516803
2018-05-11 15:18:53 -07:00
8125be942b
Reland prevent console logging on iOS 11.3+ within WebSocket
...
Reviewed By: shergin
Differential Revision: D7953765
fbshipit-source-id: 6b259d10c719e9ad6b2cfdbf1ebb883dacf08353
2018-05-11 14:30:54 -07:00
0e5c2633ee
Prettier files with shebang
...
Reviewed By: yungsters
Differential Revision: D7974564
fbshipit-source-id: 00db563ce24868c0fde117e981936b83cec30e48
2018-05-11 13:52:30 -07:00
36fcbaa56d
Prettier the rest of ReactNative
...
Reviewed By: yungsters
Differential Revision: D7974340
fbshipit-source-id: 5fe457a8a9be4bd360fc3af9acb5c1136b2be0d7
2018-05-11 13:52:30 -07:00
aba4ec0c09
Prettier RN local-cli
...
Reviewed By: yungsters
Differential Revision: D7962462
fbshipit-source-id: 0afe2092af8703895de91a6d1400315c3173aa6d
2018-05-11 13:00:50 -07:00
680fb50040
Add missing copyright headers
...
Reviewed By: hramos, yungsters
Differential Revision: D7962391
fbshipit-source-id: 958a24e1cb190fc7c4ee0ba058ba88f03cc1a13b
2018-05-11 13:00:50 -07:00
a5a4facac3
Fix ReactShadowNodeTest
...
Reviewed By: mdvacca
Differential Revision: D7944803
fbshipit-source-id: 6d3b10004d478ad75942af96603c899f44a2e711
2018-05-11 13:00:50 -07:00
166264d63b
Back out "React sync for revisions 0887c7d...25dda90"
...
Reviewed By: acdlite
Differential Revision: D7973856
fbshipit-source-id: c9c687651ca752541b80693e2af2f07b31bbabad
2018-05-11 12:17:43 -07:00
194bd88052
Fix RootViewTest
...
Reviewed By: fkgozali
Differential Revision: D7944946
fbshipit-source-id: a8dbceba060b22ac4bc4728fb342372c437a0733
2018-05-11 11:17:31 -07:00
a93e281428
Detach RN Bridge and CS
...
Reviewed By: danzimm
Differential Revision: D7833851
fbshipit-source-id: 14533c519f08bd39d69f5203040ad54415228f9f
2018-05-11 10:57:53 -07:00
d01ab66b47
Prettier React Native Libraries
...
Reviewed By: sahrens
Differential Revision: D7961488
fbshipit-source-id: 05f9b8b0b91ae77f9040a5321ccc18f7c3c1ce9a
2018-05-10 19:10:38 -07:00
1e2de71290
Allow trailing commas
...
Summary: This was previously set to disallow trailing commas on function arguments which prettier would add. Since we are dropping support for node < 8, we can now change this setting to require trailing commas everywhere and be consistent with the prettier config at Facebook.
Reviewed By: hramos
Differential Revision: D7961098
fbshipit-source-id: fbe49513183a8c8e027bb05467a767235dbfb15b
2018-05-10 19:10:38 -07:00
cd7c91f35d
Convert react-native-github/Libraries to let/const
...
Reviewed By: sahrens
Differential Revision: D7961763
fbshipit-source-id: ff7dd1d2c7101c8019e0b4f844d8c377b4d13a13
2018-05-10 19:10:38 -07:00
dca21c8f23
Prettier IntegrationTests
...
Reviewed By: sahrens
Differential Revision: D7958195
fbshipit-source-id: 253c0eec593228e7b6bc66606584877161c6bfc2
2018-05-10 16:16:35 -07:00
86b6f5d39e
Add Prettier to some files
...
Reviewed By: sahrens
Differential Revision: D7958196
fbshipit-source-id: 05a04380a4a1f3abd4cc3a9034fc70deaa4a444b
2018-05-10 16:16:35 -07:00
8f5ebe5952
Convert react-native-github/Libraries to let/const
...
Reviewed By: sahrens
Differential Revision: D7956042
fbshipit-source-id: 221851aa311f3cdd6326497352b366048db0a1bb
2018-05-10 16:16:35 -07:00
266016c521
iOS: Mark Scheduler class as final
...
Summary:
This fixes some build flavor:
```
error: destructor called on non-final 'facebook::react::Scheduler' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
```
Reviewed By: shergin
Differential Revision: D7958022
fbshipit-source-id: 6ff64bdaa221b5c6430a98244d40d6d3789ba937
2018-05-10 15:17:53 -07:00
d4d515cdc3
MessageQueue not initializing inCall
...
Reviewed By: yungsters
Differential Revision: D7898700
fbshipit-source-id: c2b4d6e75e7f5871cd40b00bd173e6f1a929b26a
2018-05-10 11:02:45 -07:00
c2c352024f
Back out "[react-native][PR] Prevent console logging on iOS 11.3+ within WebSocket"
...
Differential Revision:
D7947829
Ninja: master broken
fbshipit-source-id: 282c574897684ce48e9e7461067805a3ec5c1de1
2018-05-10 02:08:35 -07:00
3bc2696d65
Update Android docker images
...
Summary:
Quick update to switch to a new React Native CI org on Docker Hub. Note that the images are not yet automatically generated on CI. We could do this on Circle CI in certain scenarios:
- Base image needs to be updated whenever the Android development environment has changed (e.g. switch to a new SDK version, build tools, etc)
- Tests image should ideally be updated on each commit
This PR should be safe to land as Circle CI is not yet using these images.
Closes https://github.com/facebook/react-native/pull/19192
Differential Revision: D7939209
Pulled By: hramos
fbshipit-source-id: 0f845a8fffbf8f5b9cecef4fa0ba802bc755f7aa
2018-05-09 23:32:14 -07:00
9d0b7d8f31
Fix BUCK bugs which were breaking tests after refactoring
...
Reviewed By: johnislarry
Differential Revision: D7874275
fbshipit-source-id: 7f9c8648571bc7f41649ec4ef547e7c34b479221
2018-05-09 22:12:03 -07:00
a810e6875f
move nativeLoggingHook into AndroidJSCFactory
...
Reviewed By: fromcelticpark
Differential Revision: D7803905
fbshipit-source-id: 797f5250a4a129a8dff3fb447c01837d68bea452
2018-05-09 22:12:03 -07:00
a363a7b501
Refactor ReactMarker out of Platform
...
Reviewed By: fromcelticpark
Differential Revision: D7803908
fbshipit-source-id: 957e80519c209732b163ece2bccb7c8c36ff8107
2018-05-09 22:12:03 -07:00
042449f24a
simplify handleMemoryPressure conditionalization, delete some dead code
...
Reviewed By: javache
Differential Revision: D7803912
fbshipit-source-id: 0bab4be07fc006a208caa75f94b5716c99b5d265
2018-05-09 22:12:03 -07:00
09f3d7ab49
reformat JSCExecutor.cpp
...
Reviewed By: fromcelticpark
Differential Revision: D7803913
fbshipit-source-id: fc4637d0f9ab8c01f2f257e34e435c9573ecf948
2018-05-09 22:12:03 -07:00
Tim Yung
Federico Trimboli
Eli White
David Vacca
Panagiotis Vekris
Héctor Ramos
Rafael Oleza
Mehdi Mulani
Andrew Chen (Eng)
Irene Feng
Dmitry Zakharov
Kevin Gozali
Riley Dulin
Andrey Mishanin
Marc Horowitz
