Commit Graph

16 Commits

Author SHA1 Message Date
Héctor Ramos bfece1d800 Update ISSUE_TEMPLATE.md
Summary: Closes https://github.com/facebook/react-native/pull/14990

Differential Revision: D5411770

Pulled By: hramos

fbshipit-source-id: ddabba4ec7ce83a19eeadecae41ce11004e36e4e
2017-07-12 16:50:38 -07:00
Hector Ramos 22ab231c2e Update templates, CONTRIBUTING
Summary:
Continuation of #14730 which didn't land cleanly.
Closes https://github.com/facebook/react-native/pull/14753

Differential Revision: D5329443

Pulled By: hramos

fbshipit-source-id: 2abb94d2aeaeb8694bebdc2dc0319520635d43cd
2017-06-27 09:40:24 -07:00
Hector Ramos 0d3b7fe472 Update guidelines.
Summary:
Consolidate tips on CONTRIBUTING.md, and reduce the wall of text when opening a new issue. Hoping this will encourage more people to read through the text.
Closes https://github.com/facebook/react-native/pull/14518

Differential Revision: D5250443

Pulled By: hramos

fbshipit-source-id: 91213c4ceca12225d9f54d1e1e81e020c6e463b3
2017-06-14 15:16:59 -07:00
Héctor Ramos a6c9e02399 Update ISSUE_TEMPLATE.md
Summary:
Minor template updates.
Closes https://github.com/facebook/react-native/pull/14294

Differential Revision: D5167899

Pulled By: hramos

fbshipit-source-id: cef408b7d2b2ef54176177a37fc4024d1bf999c6
2017-06-01 15:02:04 -07:00
Pavlos Vinieratos 867a6dbd27 MacOS -> macOS
Summary:
Thanks for submitting a PR! Please read these instructions carefully:

- [X] Explain the **motivation** for making this change.
- [X] Provide a **test plan** demonstrating that the code is solid.
- [X] Match the **code formatting** of the rest of the codebase.
- [X] Target the `master` branch, NOT a "stable" branch.

it has been just annoying me for a long time.
its `Mac` but its `macOS`.
https://www.apple.com/macos/sierra/

no testing needed

o be merged.

For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines.

[1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9
[2]: https://code.facebook.com/cla
[3]: https://travis-ci.org/facebook/react-native
[4]: http://circleci.com/gh/facebook/react-native
[5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests
Closes https://github.com/facebook/react-native/pull/13896

Differential Revision: D5036473

Pulled By: javache

fbshipit-source-id: e8f0813d67648da27af932a72e84e744c5ae84da
2017-05-10 08:31:36 -07:00
Héctor Ramos 597c8c7700 Update ISSUE_TEMPLATE.md
Summary:
Thanks for submitting a PR! Please read these instructions carefully:

- [ ] Explain the **motivation** for making this change.
- [ ] Provide a **test plan** demonstrating that the code is solid.
- [ ] Match the **code formatting** of the rest of the codebase.
- [ ] Target the `master` branch, NOT a "stable" branch.

What existing problem does the pull request solve?

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.

If you have added code that should be tested, add tests.

Sign the [CLA][2], if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged.
Closes https://github.com/facebook/react-native/pull/13385

Differential Revision: D4852068

Pulled By: hramos

fbshipit-source-id: ff193a7c90aa8b00c248575ae647f1fb14eb261f
2017-04-07 11:16:59 -07:00
Brent Vatne b31704bcfb Update issue template for Sketch -> Snack rename
Summary:
[We changed the name from Sketch to Snack](https://blog.expo.io/expo-sketch-expo-snack-a444f8dec72b)

It's just some text in the issue template :)

- Make it clear on the Snack website which version of react-native you are using. Right now we make it possible to pick SDK versions but it's not at all obvious which react-native version that maps to.
Closes https://github.com/facebook/react-native/pull/13304

Differential Revision: D4833399

Pulled By: ericvicenti

fbshipit-source-id: 25b1fe8b4b1ac7db6737e1ba8f611ad4d8dc3804
2017-04-04 22:03:40 -07:00
Héctor Ramos 53f9e6a659 Update ISSUE_TEMPLATE.md
Summary:
Thanks for submitting a PR! Please read these instructions carefully:

- [ ] Explain the **motivation** for making this change.
- [ ] Provide a **test plan** demonstrating that the code is solid.
- [ ] Match the **code formatting** of the rest of the codebase.
- [ ] Target the `master` branch, NOT a "stable" branch.

What existing problem does the pull request solve?

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.

If you have added code that should be tested, add tests.

Sign the [CLA][2], if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged.
Closes https://github.com/facebook/react-native/pull/13122

Differential Revision: D4763115

Pulled By: hramos

fbshipit-source-id: 5d4852a133d42e3fd6eb084cf491a672cf075c29
2017-03-23 11:20:46 -07:00
Héctor Ramos 68c655a2fd Update ISSUE_TEMPLATE.md
Summary:
Some quick copy changes.
Closes https://github.com/facebook/react-native/pull/13061

Differential Revision: D4749511

Pulled By: hramos

fbshipit-source-id: 5b6f67be40ed071367507ac3c87f7ac67a0584e7
2017-03-21 15:45:50 -07:00
Hector Ramos 6dab5dcd7c Link to Sketch and CRNA
Summary:
rnplay.org is shutting down on April 1st, 2017. Recommend instead using Expo's improved prototyping tool, Sketch.
Closes https://github.com/facebook/react-native/pull/12935

Differential Revision: D4709631

Pulled By: mkonicek

fbshipit-source-id: ebc020ca7973a23658dc3b63ad2ac81c2ecefe9c
2017-03-14 17:01:56 -07:00
Héctor Ramos 3b146cdac1 Add dev tools version to new issue template
Summary:
It's sometimes helpful to provide the Xcode version being used, as in the case of #12795.
Closes https://github.com/facebook/react-native/pull/12811

Differential Revision: D4677123

Pulled By: hramos

fbshipit-source-id: 28890d1ac65400d4e98ae2eb77e2d7a1a02b9d05
2017-03-08 16:15:02 -08:00
Héctor Ramos 152abb678e Update ISSUE_TEMPLATE.md
Summary:
Encourage people to test on the latest stable release.
Closes https://github.com/facebook/react-native/pull/12567

Differential Revision: D4629303

Pulled By: hramos

fbshipit-source-id: d3828607d5c26e562cc418cff8c51ede38d69a6b
2017-02-28 12:31:00 -08:00
Héctor Ramos 07b975248b Ask for solutions in new issue template.
Summary: Closes https://github.com/facebook/react-native/pull/10884

Differential Revision: D4167391

Pulled By: hramos

fbshipit-source-id: 278b153e9a7bf6975e4d0f23909601f78c8ab3fe
2016-11-11 09:43:48 -08:00
Kevin Lacker 2fc9d7ee43 Update the issue template
Summary:
I notice most people filing issues are ignoring the issue template. I think we should try making it more concise, in particular asking people to provide a rnplay.org reproduction if it is possible.
Closes https://github.com/facebook/react-native/pull/10526

Differential Revision: D4070980

Pulled By: hramos

fbshipit-source-id: 0781fb9e410d50f8000b6c8cacfd5e5f9e881317
2016-10-24 15:43:34 -07:00
Héctor Ramos 7a7c44f622 Update ISSUE_TEMPLATE.md
Summary:
Provide a sample new issue template to encourage people to provide additional detail as needed. This should help us reduce the number of new issues that are opened without sufficient information or actionable requests.

The minimal use of markdown is intentional, as these guidelines are more likely to be found in raw text inside the [new issue composer](https://github.com/facebook/react-native/issues/new) rather than rendered to HTML.
Closes https://github.com/facebook/react-native/pull/9074

Differential Revision: D3785606

Pulled By: hramos

fbshipit-source-id: 9982566a0f0d86c71eeface33bd0624a4a9935b2
2016-08-29 10:43:35 -07:00
Zakaria Ridouh 97cfacb5ba move templates to .github folder
Summary:
This moves the Template files to the .github folder. This helps clear up the extra files in the root of the directory.

This is my first PR 😄  and I plan to contribute more to this awesome project.
Closes https://github.com/facebook/react-native/pull/7854

Differential Revision: D3424679

fbshipit-source-id: 2baca0bb4182eb6d803836e10a5434d980e7d0c3
2016-06-13 07:43:28 -07:00