8ad09987e5
Log bundle size.
...
Reviewed By: javache
Differential Revision: D2564757
fb-gh-sync-id: c4429b735482ee6405b936e2dcdf610e9c6ad35f
2015-10-21 10:55:25 -07:00
4a3857ef1d
Use JSStringCreateWithUTF8CString and skip NSString decoding when loading the bundle
...
Summary: public
Benchmarking our startup path has shown we spend a lot of time decoding strings (iPhone 4S / iPhone 5):
* reading a 2MB JS bundle: 35ms / 15ms
* decoding is to an `NSString`: 186ms / 78ms
* transforming that to a `JSString`: 29ms / 10ms
Instead of going through an `NSString` transformation, we generate a null-terminated bundle (0.1ms / 0.05ms to copy the data) and use `JSStringCreateWithUTF8CString` (121ms / 53ms) to generate the string. That makes decoding 70% faster.
Reviewed By: javache
Differential Revision: D2541140
fb-gh-sync-id: 09a016b8edfd46a9b62682c76705564d2024e75e
2015-10-16 08:11:25 -07:00
f52cd5dc1e
Use path instead of resourceSpecifier so it unescapes.
...
Reviewed By: @nicklockwood
Differential Revision: D2526217
fb-gh-sync-id: c48af71402927b0aa4e9942e1825068af5334ab9
2015-10-09 06:39:43 -07:00
7fe7a2a26b
Improved JS bundle loading performance
...
Summary: @public
RCTJavaScriptLoader was using an NSURLSessionDataTask to load local bundle.js files. While this works, it was non-optimal from a performance point of view.
Reviewed By: @tadeuzagallo
Differential Revision: D2522598
fb-gh-sync-id: b32981b3be4c336512d1462d3f4943b5aad34ae0
2015-10-08 12:39:52 -07:00
3bef953f77
Added clarifying language to error for not finding development server
...
Summary:
Added additional check to make if seeing error message on not finding development server:
Node server URL is correctly set in AppDelegate.
Should make it easier for a developer that is not running on localhost for the first time.
Screenshot of updated error message:
Closes https://github.com/facebook/react-native/pull/2484
Github Author: futbalguy <kyle.rokita@gmail.com>
2015-09-01 05:25:56 -08:00
88e0bbc469
Ran Convert > To Modern Objective C Syntax
2015-08-25 01:08:49 -08:00
8d1e02b8bd
Convert alloc/init to new to please linter
2015-08-17 08:46:00 -07:00
127f7095dc
[ReactNative] Add RCTBridgeDelegate
...
Summary:
Add a new bridge delegate protocol to allow a more flexible bridge configuration.
For now it just support the pre-existent configurations + providing the JavaScript
source to the bridge, that should allow pre-loading sources.
2015-07-28 15:57:02 -08:00
1b7699f671
Migrate unit tests from FBReactKitModules to FBReactKit
2015-07-07 16:39:35 -08:00
650fc9de4c
Increased warning levels to -Wall -Wextra, and fixed Xcode 7 beta issues
...
Summary:
@public
I've increased the warning levels in the OSS frameworks, which caught a bunch of minor issues. I also fixed some new errors in Xcode 7 relating to designated initializers and TLS security.
Test Plan:
* Test the sample apps and make sure they still work.
* Run tests.
2015-06-15 07:52:50 -08:00
132a9170f1
[ReactNative] Create private underlying bridge to prevent retain cycles
2015-05-04 10:36:20 -08:00
8a3b0fa9e8
Fix edge cases and add tests for +[RCTConvert NSURL:]
2015-04-25 15:11:23 -08:00
34a5aa1d0a
[ReactNative][madman] Revert D2001353
2015-04-23 13:39:56 -08:00
4242bd9c83
Replace percent escapes in file URL before using as path
...
Summary:
This is to fix a bug that prevents bundling of projects that contain spaces (or other special characters) in their names.
#### Reproduction steps before the fix
1. Create a project with a space in the name:
2. Follow the steps in `OPTION 2` for running from a bundled file, i.e. create the `main.bundle` file, add it to the project if is not there already, and uncomment `jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];`
3. Run the application. This is what happens:
To prove that it has to do with a space in the name, refactor the project name to not contain a space:
Alexey Lang
Frédéric Sagnes
Uri Baghin
Nick Lockwood
futbalguy
Tadeu Zagallo
Kevin Gozali
Herman Schaaf
Spencer Ahrens
Ben Hiller
