status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-12 02:24:23 +00:00
Code Issues Projects Releases Wiki Activity
13,571 Commits 61 Branches 315 Tags 184 MiB
Commit Graph

4046 Commits

Author SHA1 Message Date
Tim Yung
2f4ca831bf React sync for revisions bde4b16...de84d5c 
Reviewed By: bvaughn

Differential Revision: D8018924

fbshipit-source-id: 1092ad70ebe95aee70ec3ea9a8edfb6ac46a66c4
 2018-05-15 16:48:49 -07:00
Tim Yung
83169c95a3 React sync for revisions 0887c7d...bde4b16 
Reviewed By: fkgozali, acdlite

Differential Revision: D7999962

fbshipit-source-id: 8ef358574244bd76fe5a67a1781d59a70fc9c449
 2018-05-15 13:16:57 -07:00
Tim Yung
70066ecd2b RN: Remove ReactPerf References 
Reviewed By: fkgozali

Differential Revision: D8002194

fbshipit-source-id: a60073698d0f348d788b5c67e1c1c0010f7ec7f1
 2018-05-15 13:16:57 -07:00
Janic Duplessis
ffe6c110f7 Fix keyboard handling with keyboardShouldPersistTaps: never 
Summary:
When `keyboardShouldPersistTaps` is `"never"` it would break when doing the following steps:

- Tap input 1, keyboard goes up
- Tap input 2, keyboard stays down (The bug I expected without the isTextInput check was that it would dismiss instead :o )
- Tap outside, keyboard stays down. It should dismiss here since it should never persist taps (unless tapping another input)

What seems to happen is that RN `currentlyFocusedTextInput` goes out of sync with the focused text input and is null even if there is still a text input focused. I haven't had time to investigate the cause of that (probably some race condition because of trying to focus and blur at the same time) but we should not try to dismiss the keyboard when tapping another TextInput in the first place.

I reproduced the bug mentioned by setting `keyboardShouldPersistTaps` to `"never"` in RNTesterPage.js and then using the steps described above. I made sure that the bug did not happen after this change.

[GENERAL][BUGFIX][ScrollResponder] - Fix keyboard handling with keyboardShouldPersistTaps: never
Closes https://github.com/facebook/react-native/pull/19255

Differential Revision: D8002818

Pulled By: mdvacca

fbshipit-source-id: 6ecb8d2c30eb9338529471a958b5dc04037c7ec6
 2018-05-14 23:46:50 -07:00
Tim Yung
a956551af7 RN: Fix $FlowFixMe in AppContainer 
Summary: Fixes the `$FlowFixMe` type errors in `AppContainer`.

Reviewed By: TheSavior

Differential Revision: D7987552

fbshipit-source-id: 5eba319aa2661c2d6d8ed24affc066504096b72c
 2018-05-14 17:52:25 -07:00
Tim Yung
6042592cf4 RN: Revise $FlowFixMe in Text 
Reviewed By: TheSavior

Differential Revision: D7987519

fbshipit-source-id: 01c389ab7c277ec8423c137e61bb94a0d3ba4669
 2018-05-14 17:52:25 -07:00
Tim Yung
c017dcb0f2 RN: Switch KeyboardAvoidingView to Class Syntax 
Summary:
Refactors `KeyboardAvoidingView` by using class syntax and fixing all Flow errors.

Note that there's still a bunch of sketchy stuff going on in this component with mutated instance variables (that are used in `render`!) and unsafe lifecycle methods. But at least now it's a little bit less painful on the eyes.

Reviewed By: TheSavior

Differential Revision: D7987443

fbshipit-source-id: f5c27a9dd383c430d9a5a9dc0b6e10e2c4fe8dd9
 2018-05-14 17:52:25 -07:00
fattahmuhyiddeen
344c205070 Fix crash during Archiving project in IOS 
Summary:
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

  To fix issue that crash on XCode 9.3

Archive the project in XCode 9.3

This does not change any documentation

 To fix issue that crash on XCode 9.3

 [IOS] [BREAKING] [RCTImageCache.m] - Crash during archiving in XCode 9.3
Closes https://github.com/facebook/react-native/pull/18682

Differential Revision: D7992071

Pulled By: hramos

fbshipit-source-id: 1089e469712b1eb2fcdd3ad59766c187e932f46c
 2018-05-14 11:49:53 -07:00
Eli White
75ad71ee24 Delete TextUpdateTest 
Reviewed By: yungsters

Differential Revision: D7985997

fbshipit-source-id: b8c1c95cdd6ead471614b37bc32d6b36280157cc
 2018-05-14 00:24:45 -07:00
Eli White
5e6c51b19e Flowtype SwipeableRow 
Reviewed By: yungsters

Differential Revision: D7985995

fbshipit-source-id: 4fd1085291c47be4a2753dc1252dc6a3c66269d9
 2018-05-14 00:24:44 -07:00
Eli White
113f009698 Flowtype SegmentedControlIOS 
Reviewed By: yungsters

Differential Revision: D7985978

fbshipit-source-id: 6579ad8dd5c5377571fd790149ea5cfc6b33939f
 2018-05-14 00:24:44 -07:00
Eli White
c87701ba05 Flowtype ProgressViewIOS 
Reviewed By: yungsters

Differential Revision: D7985969

fbshipit-source-id: d351ebc26e7be2741c93ce462ae59aa13d0c1f27
 2018-05-14 00:24:44 -07:00
Eli White
1c66cdc7e8 Flowtype PickerIOS 
Reviewed By: yungsters

Differential Revision: D7985960

fbshipit-source-id: 9fbce5fafe47bee1d2a527c72f3ebef85d26f9f1
 2018-05-14 00:24:44 -07:00
Eli White
d796129895 Delete LazyRenderer 
Summary: This isn't used internally at Facebook and we have no public documentation for this component. If people are interested in using it they can easily reproduce this function outside of core.

Reviewed By: yungsters

Differential Revision: D7985955

fbshipit-source-id: 859878a858cbcb42fec7f9bd04e5d7574801e445
 2018-05-14 00:24:44 -07:00
Eli White
06052a2330 Flowtype Switch 
Reviewed By: yungsters

Differential Revision: D7985880

fbshipit-source-id: eaaff2188b8257d09e1bf628d19dae6dfb4c2fc6
 2018-05-14 00:24:44 -07:00
Eli White
cbe045a95f Flowtype Slider 
Reviewed By: yungsters

Differential Revision: D7985857

fbshipit-source-id: 8b6b9f58aa89b898fa38d1cfc0564df5f64741a2
 2018-05-14 00:24:44 -07:00
Eli White
891dfc3da4 Flowtype RefreshControl 
Reviewed By: yungsters

Differential Revision: D7985835

fbshipit-source-id: 67a27cb99738d99959b1c795af95d0415a84f1b9
 2018-05-14 00:24:44 -07:00
Eli White
4b1ecb6204 Flowtype ListView 
Reviewed By: yungsters

Differential Revision: D7985836

fbshipit-source-id: 6e0944a8d2fb85aabc34dfd3125a07b208749f21
 2018-05-14 00:24:44 -07:00
Eli White
af6e2eb02d Removing unnecessary FlowFixMe 
Reviewed By: yungsters

Differential Revision: D7985749

fbshipit-source-id: ba7e152749c5a5cac134b51e0229dc11870bb3e0
 2018-05-14 00:24:44 -07:00
Eli White
1419c7a7fd Migrate ScrollView fake type to ReactNative.NativeComponent 
Reviewed By: yungsters

Differential Revision: D7985122

fbshipit-source-id: b78fc6ad84485e8aa42657c2b21d70c9f3a271d6
 2018-05-14 00:24:44 -07:00
Eli White
ffda017850 Removing unnecessary FlowFixMe 
Reviewed By: yungsters

Differential Revision: D7985116

fbshipit-source-id: 97a7a37b2ffe7a81669973f9dca6824a4f352a07
 2018-05-14 00:24:44 -07:00
Eli White
c8bcda8150 FlowType TextInput 
Reviewed By: yungsters

Differential Revision: D7985109

fbshipit-source-id: 294919bce64b21cab4f37262a7da9e68cb67207f
 2018-05-14 00:24:44 -07:00
Eli White
0e707ff843 Clean up TextInput 
Reviewed By: yungsters

Differential Revision: D7984843

fbshipit-source-id: 17259ade77f08d37dff9bb85984798f99885ad86
 2018-05-13 02:01:05 -07:00
Eli White
8454a36b0b Flow type TouchableBounce 
Reviewed By: yungsters

Differential Revision: D7984827

fbshipit-source-id: b0dd67b5c4d57cd9bb0339a5266a16e4565b2d54
 2018-05-13 02:01:05 -07:00
Tim Yung
752863629d RN: Fix Type for ReactNative.NativeComponent (2/2) 
Reviewed By: TheSavior

Differential Revision: D7984936

fbshipit-source-id: d0477c54420b49220e9529fa70c2b2babce0b409
 2018-05-13 01:05:57 -07:00
Tim Yung
de11ba2a5e RN: Fix Type for ReactNative.NativeComponent (1/2) 
Reviewed By: TheSavior

Differential Revision: D7984814

fbshipit-source-id: 0097819128b7f82267bceeb9d5e1b5057c5129ec
 2018-05-13 01:05:56 -07:00
Tim Yung
41a940392c RN: Add Missing Events to ViewPropTypes 
Reviewed By: TheSavior

Differential Revision: D7984937

fbshipit-source-id: fc2703e3382a7515b71f8a634aca5b6d7a5b25b4
 2018-05-13 01:05:56 -07:00
Eli White
870775ee73 Stop expose Image.resizeMode 
Summary:
Exposing this enum is essentially useless and at worst is a runtime cost that isn't necessary by just using the string.

The value of this enum, as far as I understand it, is to enforce that only valid options are used. We can enforce this at build time with Flow.

I was able to migrate our codebase with a few Find and Replace for things like

```
resizeMode={Image.resizeMode.contain}
```

Reviewed By: yungsters

Differential Revision: D7983982

fbshipit-source-id: ddd7024023f8d2f01aad1fff6c8103983a1bec1a
 2018-05-12 23:25:09 -07:00
Eli White
a9a612bfb6 Making ImageURISource exact 
Reviewed By: yungsters

Differential Revision: D7984204

fbshipit-source-id: ccd2627b72da5c97f046c895652fdf7cc0b3db40
 2018-05-12 23:25:09 -07:00
Eli White
0fe72579be Image cleanup 
Reviewed By: yungsters

Differential Revision: D7983744

fbshipit-source-id: c6c1c78fd93b40553688f1444b57074802520f7e
 2018-05-12 23:25:09 -07:00
Eli White
44743c07ad Flow Type TouchableOpacity 
Reviewed By: yungsters

Differential Revision: D7983709

fbshipit-source-id: 0f664c831b754277e344aa53b2dbed6b4f720cd5
 2018-05-12 23:25:09 -07:00
Eli White
6cfa4a360d TouchableOpacity @noflow -> @flow 
Reviewed By: yungsters

Differential Revision: D7983644

fbshipit-source-id: bf4a0ba600ac51ef07ac12927eed29eeb92ffb2a
 2018-05-12 23:25:09 -07:00
Eli White
f0c18dc820 Flow type TouchableHighlight 
Reviewed By: yungsters

Differential Revision: D7983631

fbshipit-source-id: 98b3708b26e2bf96426d5acaa5c7e2311a3a34f6
 2018-05-12 23:25:09 -07:00
Eli White
6b3aad31f6 Remove unused suppressions 
Reviewed By: yungsters

Differential Revision: D7983271

fbshipit-source-id: ee64e2dacbc8a1b75915b825f7bf0621a121422d
 2018-05-12 23:25:08 -07:00
Eli White
0b79d1faa2 Type TouchableWithoutFeedback 
Reviewed By: yungsters

Differential Revision: D7982348

fbshipit-source-id: 409ce4a5ea8c09e58c42caf9db60117253503c4c
 2018-05-12 23:25:08 -07:00
Eli White
91c4b0357a Remove unused suppressions 
Reviewed By: yungsters

Differential Revision: D7982027

fbshipit-source-id: 00e538dc678275495e097d9cd14a0a2643ebaefd
 2018-05-12 10:35:27 -07:00
Eli White
b127662279 Flow Type ScrollView 
Reviewed By: yungsters

Differential Revision: D7981073

fbshipit-source-id: 38c100f37e46683da1e34b335d476e706baae238
 2018-05-12 10:35:27 -07:00
Eli White
188b118b60 Flow Type KeyboardAvoidingView 
Reviewed By: yungsters

Differential Revision: D7978494

fbshipit-source-id: e21b4910470d3dc3fd35027f2f975b6842baa6ab
 2018-05-12 10:35:27 -07:00
Eli White
97e572ea6d Flow Type DatePickerIOS.ios.js 
Reviewed By: yungsters

Differential Revision: D7978090

fbshipit-source-id: 65da360f34f4b6d9240a8343c89be66404767474
 2018-05-12 10:35:27 -07:00
Eli White
0b71d1ddb0 Flow Typing ActivityIndicator 
Reviewed By: yungsters

Differential Revision: D7977834

fbshipit-source-id: 62e54f98ee8f9e7d5189fc19c803a95f5c4c43aa
 2018-05-12 10:35:27 -07:00
Eli White
f19ee28e7d Adding $FlowFixMe to invalid prop accesses 
Reviewed By: yungsters

Differential Revision: D7977387

fbshipit-source-id: 442e7445be62f78bdf166a2b97ef031e39877355
 2018-05-12 10:35:27 -07:00
Eli White
7ba7acdee7 Surfacing Flow issues around invalid props 
Reviewed By: yungsters

Differential Revision: D7977386

fbshipit-source-id: a6df2d75e0caa55a84f9c9c6860f622942955dfc
 2018-05-12 10:35:27 -07:00
Eli White
65c336f38f Make ViewProps Exact 
Reviewed By: yungsters

Differential Revision: D7976755

fbshipit-source-id: f6a0da1023a9235763c7ecb3ca7a9238887d0471
 2018-05-12 10:35:27 -07:00
Eli White
bc658d3c44 Spread TVViewProps into ViewProps instead of intersection 
Reviewed By: yungsters

Differential Revision: D7976556

fbshipit-source-id: ca2f6bcac249a937523c4b50add8960085a8be49
 2018-05-12 10:35:26 -07:00
Panagiotis Vekris
4767f9be45 v0.72.0 in xplat/js 
Reviewed By: gabelevi

Differential Revision: D7956747

fbshipit-source-id: b1993de405c273b3cc1ed74f994e8e75bda0a985
 2018-05-11 17:50:35 -07:00
David Vacca
75ff136f03 Load 'ReactFabric' only when it is required to render a Fabric component 
Reviewed By: yungsters

Differential Revision: D7970603

fbshipit-source-id: 34676b9e174bc1e1141f4f435aa2c8e2b62cd5b9
 2018-05-11 17:18:03 -07:00
Mehdi Mulani
8125be942b Reland prevent console logging on iOS 11.3+ within WebSocket 
Reviewed By: shergin

Differential Revision: D7953765

fbshipit-source-id: 6b259d10c719e9ad6b2cfdbf1ebb883dacf08353
 2018-05-11 14:30:54 -07:00
Eli White
680fb50040 Add missing copyright headers 
Reviewed By: hramos, yungsters

Differential Revision: D7962391

fbshipit-source-id: 958a24e1cb190fc7c4ee0ba058ba88f03cc1a13b
 2018-05-11 13:00:50 -07:00
Irene Feng
166264d63b Back out "React sync for revisions 0887c7d...25dda90" 
Reviewed By: acdlite

Differential Revision: D7973856

fbshipit-source-id: c9c687651ca752541b80693e2af2f07b31bbabad
 2018-05-11 12:17:43 -07:00
Dmitry Zakharov
a93e281428 Detach RN Bridge and CS 
Reviewed By: danzimm

Differential Revision: D7833851

fbshipit-source-id: 14533c519f08bd39d69f5203040ad54415228f9f
 2018-05-11 10:57:53 -07:00