Commit Graph

4 Commits

Author SHA1 Message Date
Héctor Ramos 241e74dc5f Close after 3 days
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/20990

Differential Revision: D9664380

Pulled By: hramos

fbshipit-source-id: 63cc205b44ed7cfb55fef64ddce579a35e082300
2018-09-05 16:33:37 -07:00
Héctor Ramos 499d654eb8 Halve the period of time until an issue is considered stale
Summary:
I propose halving the time required to flag and close an issue due to inactivity. The new time period would be 90 days (~3 months), at which point the bot will flag an issue as stale. This starts the second timer, where if the issue sees no further activity within 30 days, it will be closed by the bot.

_Extra: Do not automatically mark as stale issues labeled as regressions or "Help Wanted"_

Currently, an issue must see no activity for 180 days (~six months), at which point it is labeled stale. It will then take a further 60 days of inactivity before the issue is closed.

Take for example issue 9773. It was opened in September 2016, and closed for inactivity in November 2016. It was then resurrected February 2018. Three months later, no activity has occurred. This is, in my opinion, too lenient and the issue should be closed.

Last year, we reached a point where the repo has over 1,500 open issues. After finding some of these issues had no activity for over a year, I enabled a Stale bot on the repository which took care of closing any issue that saw no activity over a two week period. This helped us get to 200 open issues after some time.

After hearing feedback from the community that the bot was too aggressive on new issues, and considering that 200 open issues on such a broad project as React Native is not too high of a number, I dialed down the Stale bot so that it would take up to ~8 months to close a stale issue. In hindsight, I believe this was too big of an over-correction on my part. With open issues now topping 600, I think it's about time the Stale bot starts closing inactive issues again.

My view is that closing an issue does not indicate the issue is invalid. Closing an issue for inactivity is a sign that the issue is not problematic enough to inspire a member of the community to followup and/or propose a fix through a PR. Closing stale issues as soon as possible should help maintainers surface active issues with the greatest impact on users of the library.

None, configuration change.

[INTERNAL] [MINOR] [stale.yml] - Update Stale bot to halve stale closing times.
Closes https://github.com/facebook/react-native/pull/19253

Differential Revision: D8019532

Pulled By: hramos

fbshipit-source-id: 405b87ac3229c5ffb20a2ce2234cdcbec1f01c66
2018-05-15 16:48:49 -07:00
Héctor Ramos 247f32ff12 Increase n days before issue considered stale
Summary:
This repository has Probot's [Stale workflow](https://github.com/probot/stale) enabled. It is configured via the `.github/stale.yml` file.

In this PR, we increase number of days before an issue becomes stale to ~six months, and increase days until the same issue is closed after inactivity to ~2 months.

It also limits the stale bot to issues only.
Closes https://github.com/facebook/react-native/pull/18108

Differential Revision: D7105801

Pulled By: hramos

fbshipit-source-id: 23efd41f88c03cb6c0be3820a3b3ac67b3e4a6fe
2018-02-27 17:01:19 -08:00
Héctor Ramos Ortiz 3826c14c04 Configure a couple new bot integrations
Summary: Closes https://github.com/facebook/react-native/pull/16344

Differential Revision: D6044166

Pulled By: hramos

fbshipit-source-id: 651bec1c1d1afa974f5a7b285ccf8a77bf281d21
2017-10-12 17:47:31 -07:00