Summary:
When the GIF data is not a string nor NSData, `imageSource` is some unknown value set to whatever memory was on the stack. Calling `CGImageSourceGetType` on it has undefined behavior, and if it makes through to the CFRelease (maybe because it is NULL) then CFRelease will crash. This fixes a clang warning.
Closes https://github.com/facebook/react-native/pull/77
Github Author: James Ide <ide@jameside.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary:
Images whose intrinsic dimensions don't match the view's dimensions suffer from jaggies. Applying `kCAFilterTrilinear` makes this way better. If you accurately size your images then there's no difference, good job (y)
I left GIFs using the default linear filtering since they are more intensive to begin with and GIFs are generally for animation these days anyway.
Closes https://github.com/facebook/react-native/pull/95
Github Author: James Ide <ide@jameside.com>
Test Plan: Imported from GitHub, without a `Test Plan:` line.
Andrew Rasmussen
Tadeu Zagallo
Nick Lockwood
Skotch Vail
Spencer Ahrens
Christopher Chedeau
James Ide