react-native

Commit Graph

Author	SHA1	Message	Date
Kyle Corbitt	2d921eeb70	Resolve react flow definitions Summary:Currently, we're not taking advantage of Flow's built-in type definitions for the React library in all cases because Flow's definition uses `declare module react` and this file uses `import('React')`, which Flow thinks is a different library. After this change, the following starts working which didn't before: ```js import { Component } from 'react-native'; class MyText extends Component<void, {text: string}, void> { render() { return <Text>{this.props.text}</Text> } } // Correctly throws a Flow error for the missing "text" prop const renderedText = <MyText />; ``` Closes https://github.com/facebook/react-native/pull/5489 Differential Revision: D2856176 fb-gh-sync-id: 473ca188ad7d990c3e765526c4b33caf49ad9ffd shipit-source-id: 473ca188ad7d990c3e765526c4b33caf49ad9ffd	2016-02-25 02:45:34 -08:00
gitim	37b724eaa6	Fix missing keys in animation example Summary: There were two warnings about missing keys, fixed them. Closes https://github.com/facebook/react-native/pull/5153 Reviewed By: svcscm Differential Revision: D2807602 Pulled By: androidtrunkagent fb-gh-sync-id: ef7a5eecd297e89b7338fdec65639785a1232f13	2016-01-06 11:12:30 -08:00
Spencer Ahrens	fdeb6a842a	[RN] New AnimationExample	2015-09-03 12:52:56 -08:00

Author

SHA1

Message

Date

Kyle Corbitt

2d921eeb70

Resolve react flow definitions

Summary:Currently, we're not taking advantage of Flow's built-in type definitions for the React library in all cases because Flow's definition uses `declare module react` and this file uses `import('React')`, which Flow thinks is a different library. After this change, the following starts working which didn't before:

```js
import { Component } from 'react-native';

class MyText extends Component<void, {text: string}, void> {
  render() { return <Text>{this.props.text}</Text> }
}

// Correctly throws a Flow error for the missing "text" prop
const renderedText = <MyText />;
```
Closes https://github.com/facebook/react-native/pull/5489

Differential Revision: D2856176

fb-gh-sync-id: 473ca188ad7d990c3e765526c4b33caf49ad9ffd
shipit-source-id: 473ca188ad7d990c3e765526c4b33caf49ad9ffd

2016-02-25 02:45:34 -08:00

gitim

37b724eaa6

Fix missing keys in animation example

Summary:
There were two warnings about missing keys, fixed them.
Closes https://github.com/facebook/react-native/pull/5153

Reviewed By: svcscm

Differential Revision: D2807602

Pulled By: androidtrunkagent

fb-gh-sync-id: ef7a5eecd297e89b7338fdec65639785a1232f13

2016-01-06 11:12:30 -08:00

Spencer Ahrens

fdeb6a842a

[RN] New AnimationExample

2015-09-03 12:52:56 -08:00

3 Commits