Commit Graph

4 Commits

Author SHA1 Message Date
Tim Yung 23331df5a4 RN: Cleanup OSS JS & Flow Declarations
Reviewed By: vjeux

Differential Revision: D4210763

fbshipit-source-id: 5abaa547100b8badd13bcf311ceffc5b4098d252
2016-11-20 17:58:29 -08:00
Joel Marcey cb31d4cb6d Use tabIndex instead of tabindex
Summary:
There is a little bit of dogscience here, but I believe JSX is wanting
`tabIndex` instead of `tabindex`. We have `tabindex` as an attribute in
our Algolia search; changing it to `tabIndex` removes the warning.

**Before**

<img width="1262" alt="screenshot 2016-07-12 11 05 47" src="https://cloud.githubusercontent.com/assets/3757713/16772199/4bff2d0e-4821-11e6-822f-a729656fec53.png">

**After**

<img width="1254" alt="screenshot 2016-07-12 11 09 47" src="https://cloud.githubusercontent.com/assets/3757713/16772201/4e09eb34-4821-11e6-9c5e-5e3d7e21c4bd.png">
Closes https://github.com/facebook/react-native/pull/8721

Differential Revision: D3550398

fbshipit-source-id: b7821d1940cd4c7880ee6fb907bcb16b44087750
2016-07-12 12:28:22 -07:00
ColCh 6a828328e1 Add tabindex attribute to searchbar
Summary:
Explain the **motivation** for making this change. What existing problem does the pull request solve?

This is small improvement to docs webpage.
I'm tired of clicking on searchbar with mouse/touchpad, so I've added a `tabindex` attribute to it, so it can be now focused with `Tab` key.

I think this greatly improves user experience on documentation searching.

**Test plan (required)**

??? Just click on `Tab` and it will focus. Should I test it really?

**Code formatting**

Attributes are sorted alphabetically, I've inserted new attribute in this order, after `id` and before `type` attributes.
Closes https://github.com/facebook/react-native/pull/8319

Differential Revision: D3470858

fbshipit-source-id: 01240bdf1432d9873324ddee38be256dfab93df2
2016-06-22 12:28:33 -07:00
Adam Miskiewicz cc1bad54ea [Website] First pass at Algolia Doc Search
It’s not yet responsive :(
2015-12-29 12:45:33 -05:00