status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
13,887 Commits 61 Branches 315 Tags 184 MiB
Commit Graph

3 Commits

Author SHA1 Message Date
Valentin Shergin 8b62e7a550 Fabric: Using Size instead of Point as textShadowOffset's type 
Summary:
The current implementation of React Native uses `Size` as the underlying type of `textShadowOffset` which is clearly terribly wrong (especially because negative size values makes no sense). This mistake was borrowed from `NSShadow`, I believe.
I don't have time to fix this in every implementation of RN now, so let's use `Size` in Fabric as well.

Reviewed By: fkgozali

Differential Revision: D8246714

fbshipit-source-id: 1f0bf9b9dfa83802ef3faef2971fed5510494bfd
 2018-06-08 20:31:40 -07:00
Valentin Shergin 9d21e6661a Fabric: New props treatment in `attributedstring` module 
Summary:
Adopting template-generated `convertRawProp` and `debugStringConvertibleItem` functions in `attributedstring` module.
Note, to do so we have to change signatures of some conversions functions to make them more overloading-friendly.

Reviewed By: fkgozali

Differential Revision: D7958245

fbshipit-source-id: 275a58bd3955a6ceb4881bffff86bf1d4501b3d2
 2018-05-14 16:03:49 -07:00
Valentin Shergin 62576bcb78 Fabric/Text: attributedstring module, the second part 
Reviewed By: mdvacca

Differential Revision: D7748711

fbshipit-source-id: 57b37cb2eaa20b85c6f6719b38eac2a2c0479485
 2018-05-07 18:09:06 -07:00