Commit Graph

18 Commits

Author SHA1 Message Date
Taras Tsugrii 12d98db901 Fix conditional load usage.
Summary:
Conditional `load` statements are not allowed in new Buck build file parser - Skylark.
https://buckbuild.com/concept/skylark.html

Reviewed By: mzlee

Differential Revision: D8842756

fbshipit-source-id: f22dff00f594978e4cab5736268ad3225182c39b
2018-07-14 18:32:20 -07:00
Taras Tsugrii 662c5bfd26 Skylarkify ReactNative build defs.
Summary: https://buckbuild.com/concept/skylark.html

Reviewed By: mzlee

Differential Revision: D8823004

fbshipit-source-id: 164be349782862bf83f5bdf2c869bf10713d5dfe
2018-07-14 17:31:19 -07:00
Taras Tsugrii b3fe69cac2 Fix external cell reference in OSS build.
Reviewed By: hramos

Differential Revision: D8615578

fbshipit-source-id: 22a0382956adc3c2cb0d25f756cd5fad11564559
2018-06-25 11:02:18 -07:00
Taras Tsugrii fe3bd9a65c Skylarkify ReactNative OSS build defs.
Summary:
Skylark parser will not allow access to file system other
than through `glob` and environment variables. The logic was also
making assumption about `buck-out` layout structure which is not
specified and as such is subject to change at any time without any
announcement.

Differential Revision: D8604721

fbshipit-source-id: 90826b4d5709580aad3092d0331d0e84e493c3b8
2018-06-25 09:46:22 -07:00
Taras Tsugrii 71cd2d79ec Move conditional logic into corresponding build defs.
Summary:
Conditional `load`s are not allowed in Skylark. The logic
that belongs to different environments has to be part of environment
specific build defs and include as part of cell resolution or CI
configuration.
More context: https://buckbuild.com/concept/skylark.html

Differential Revision: D8604673

fbshipit-source-id: 385f2e155c4d80219e6ed3a2e0a82c909ebabb13
2018-06-24 14:46:38 -07:00
Jonathan Kim 62784f35d8 load in platform macros
Reviewed By: ttsugriy

Differential Revision: D7809673

fbshipit-source-id: aacff1a99ba50393ed8f74842afa59384b846e63
2018-04-29 16:01:17 -07:00
Jonathan Kim 7f7020a1db Fix up wrapped macros
Reviewed By: mzlee

Differential Revision: D7645524

fbshipit-source-id: e62101dac95fd7458a2519588105ce43607a9769
2018-04-17 01:28:30 -07:00
Taras Tsugrii 2ff8b7024e Replace android_library with fb_android_library.
Reviewed By: adamjernst

Differential Revision: D7393004

fbshipit-source-id: 99060333267dd6e81a41e9da52002e05152e7ccb
2018-03-26 12:17:24 -07:00
Jonathan Kim 96daf677b7 Fix OSS Android test failure
Reviewed By: fkgozali, hramos

Differential Revision: D7358801

fbshipit-source-id: 6f7979489fd7f5c9f7d9e1d7461121b7ff9f3ab0
2018-03-21 17:48:55 -07:00
Jonathan Kim ddfcaf96bc Drop fb{android|objc} prefixed keys for oss builds
Reviewed By: hramos

Differential Revision: D7329425

fbshipit-source-id: 8a2e5936991f99b0d5112a6940856e8ee1d32a55
2018-03-20 14:49:55 -07:00
Michael Lee 5d3efa7d6f Mark targets as explicitly Android
Reviewed By: mmmulani

Differential Revision: D7141568

fbshipit-source-id: 6c8679790309e72ca220443ecf693087f82ece85
2018-03-02 17:22:35 -08:00
Taras Tsugrii 574c70e771 Use only native robolectric_test rules.
Reviewed By: adamjernst

Differential Revision: D6997829

fbshipit-source-id: 5f8d41a6126f02c9fb9d0fb90d89df28eeea9653
2018-02-15 20:10:05 -08:00
Jonathan Kim e233646d09 Clean up unused macros after consolidation
Reviewed By: mzlee

Differential Revision: D6954781

fbshipit-source-id: 0ec78e6f7f2780951ac008e9b12f41cfd5441ed5
2018-02-09 16:05:29 -08:00
Taras Tsugrii 79a63d040f Skylarkify RN defs.
Reviewed By: adamjernst

Differential Revision: D6934209

fbshipit-source-id: 59f50b739482a53473c157f9e0183024dc88dc67
2018-02-08 09:47:28 -08:00
Michael Lee 869866cc5c Continue wrapping functions as we prepare for skylark
Differential Revision: D6808010

fbshipit-source-id: f24e71558baed2c2da319e20e0faf66858eb27d5
2018-01-25 09:30:00 -08:00
Jonathan Kim 4f6c157250 Fix open source build load error
Reviewed By: hramos

Differential Revision: D6785610

fbshipit-source-id: d50aab72aa51f8aa063f23fc1e328caf9c02de0c
2018-01-23 09:51:40 -08:00
Héctor Ramos f5975a97ad Add back kwargs
Summary:
Originally added in #17551 by dryganets but lost when an internal diff consolidated files into ReactNative/DEFS
Closes https://github.com/facebook/react-native/pull/17710

Differential Revision: D6778242

Pulled By: hramos

fbshipit-source-id: 22bd3348feccf1ecb53d897c84e1ca704e51fc33
2018-01-22 14:47:11 -08:00
Jonathan Kim 4f2cc42a2d Make xplat react native files buildable
Reviewed By: mzlee

Differential Revision: D6605611

fbshipit-source-id: baa33947319a27b95020924d177a9398a276dabe
2018-01-21 22:05:05 -08:00