react-native

Commit Graph

Author	SHA1	Message	Date
Martin Konicek	f0490d67ff	Git upgrade: Tweak README, bump version, fix a bug Reviewed By: mkonicek Differential Revision: D4276644 Ninja: OSS only fbshipit-source-id: 7bed331770d06addedf51e2ed09d0b9bde5b45ad	2016-12-05 05:58:29 -08:00
Martin Konicek	6bee16a63d	Use Yarn if available Summary: Motivation If the project is using yarn to manage its dependencies, we should be running 'yarn add' to upgrade the React Native dependency, rather than 'npm install'. Test plan (required) Running in a project that's in a bad state: Error: react-native version in "package.json" (0.29.2) doesn't match the installed version in "node_modules" (0.38.0). Try running "yarn" to fix this. Removed yarn.lock file, ran again: Error: react-native version in "package.json" (0.29.2) doesn't match the installed version in "node_modules" (0.38.0). Try running "npm install" to fix this. Running inside a folder that doesn't contain a `package.json` file: Error: Unable to find "/Users/mkonicek/Zero29App/package.json" or "/Users/mkonicek/Zero29App/node_modules/react-native/package.json". Make sure you ran "yarn" and that you are inside a React Native project. Removed yarn.lock file, ran again: Error: Unable to find "/Users/mkonicek/Zero29App/package.json" or "/Users/ Closes https://github.com/facebook/react-native/pull/11225 Differential Revision: D4261102 Pulled By: mkonicek fbshipit-source-id: b44ae91fe46f2c81b14616ca2868cc171692c895	2016-12-02 00:13:32 -08:00

Author

SHA1

Message

Date

Martin Konicek

f0490d67ff

Git upgrade: Tweak README, bump version, fix a bug

Reviewed By: mkonicek

Differential Revision:
D4276644
Ninja: OSS only

fbshipit-source-id: 7bed331770d06addedf51e2ed09d0b9bde5b45ad

2016-12-05 05:58:29 -08:00

Martin Konicek

6bee16a63d

Use Yarn if available

Summary:
**Motivation**

If the project is using yarn to manage its dependencies, we should be running 'yarn add' to upgrade the React Native dependency, rather than 'npm install'.

**Test plan (required)**

Running in a project that's in a bad state:

    Error: react-native version in "package.json" (0.29.2) doesn't match the installed version in "node_modules" (0.38.0).
    Try running "yarn" to fix this.

Removed yarn.lock file, ran again:

    Error: react-native version in "package.json" (0.29.2) doesn't match the installed version in "node_modules" (0.38.0).
    Try running "npm install" to fix this.

Running inside a folder that doesn't contain a `package.json` file:

    Error: Unable to find "/Users/mkonicek/Zero29App/package.json" or "/Users/mkonicek/Zero29App/node_modules/react-native/package.json". Make sure you ran "yarn" and that you are inside a React Native project.

Removed yarn.lock file, ran again:

    Error: Unable to find "/Users/mkonicek/Zero29App/package.json" or "/Users/
Closes https://github.com/facebook/react-native/pull/11225

Differential Revision: D4261102

Pulled By: mkonicek

fbshipit-source-id: b44ae91fe46f2c81b14616ca2868cc171692c895

2016-12-02 00:13:32 -08:00

2 Commits