react-native

Commit Graph

Author	SHA1	Message	Date
Janic Duplessis	19429f79b2	Use a separate babel config for the local-cli and the packager Summary: This separates the babel config of the local-cli and the packager from the one used by the transforms of the packager since it doesn't run in the same environment and the local-cli/packager doesn't require react specific transforms and runs in node 4 so we can also avoid some es2015 transforms that node already supports. I had to move the code in cli.js so it can still run in node 0.12 that doesn't support `const` since it is no longer transformed. Test plan Run the local-cli on node 0.12 and there should be a message saying that it requires at least node 4. Run the local-cli on node 4 and 5 and everything should work the same as before. I was also hoping for some perf gains but there was nothing noticeable. I did benchmark the babel-register call and it stayed pretty much the same. As for runtime performance it can help if there are optimisations for es2015 features in node. Closes https://github.com/facebook/react-native/pull/6155 Differential Revision: D3242754 Pulled By: davidaurelio fb-gh-sync-id: 02880c841c10562d5f107e1c975d668e55cc619f fbshipit-source-id: 02880c841c10562d5f107e1c975d668e55cc619f	2016-04-30 16:25:24 -07:00
Christopher Chedeau	e1f04bf2e3	Quit early if node < 4 Summary: Before we would display this warning at the top and have the packager throw thousands of lines of errors because of es6 syntax. Before: <img width="602" alt="screen shot 2016-02-04 at 1 49 27 pm" src="https://cloud.githubusercontent.com/assets/197597/12831357/a72bdc0a-cb48-11e5-9b81-dde895eaf113.png"> After: <img width="1440" alt="screen shot 2016-02-04 at 2 04 50 pm" src="https://cloud.githubusercontent.com/assets/197597/12831364/af1c16a0-cb48-11e5-949c-c470938f8b49.png"> Closes https://github.com/facebook/react-native/pull/5767 Reviewed By: svcscm Differential Revision: D2902978 Pulled By: androidtrunkagent fb-gh-sync-id: c0193c3b1e36778d61aa9013f0c294f8c3475442	2016-02-04 15:23:57 -08:00
Martín Bigio	849aa4dae6	Move `private-cli` commands to `local-cli` Summary: public We cannot remove `local-cli` because is referenced by the global cli explicitly. If we do so, people would have to upgrate this global thin cli which will cause some pain. So, lets move `private-cli` commands into `local-cli` instead. Reviewed By: frantic Differential Revision: D2571983 fb-gh-sync-id: 712c29430203660fb6f0d5f23813cb2a7156ee48	2015-10-26 15:36:04 -07:00

Author

SHA1

Message

Date

Janic Duplessis

19429f79b2

Use a separate babel config for the local-cli and the packager

Summary:
This separates the babel config of the local-cli and the packager from the one used by the transforms of the packager since it doesn't run in the same environment and the local-cli/packager doesn't require react specific transforms and runs in node 4 so we can also avoid some es2015 transforms that node already supports.

I had to move the code in cli.js so it can still run in node 0.12 that doesn't support `const` since it is no longer transformed.

**Test plan**
Run the local-cli on node 0.12 and there should be a message saying that it requires at least node 4.
Run the local-cli on node 4 and 5 and everything should work the same as before.

I was also hoping for some perf gains but there was nothing noticeable. I did benchmark the babel-register call and it stayed pretty much the same. As for runtime performance it can help if there are optimisations for es2015 features in node.
Closes https://github.com/facebook/react-native/pull/6155

Differential Revision: D3242754

Pulled By: davidaurelio

fb-gh-sync-id: 02880c841c10562d5f107e1c975d668e55cc619f
fbshipit-source-id: 02880c841c10562d5f107e1c975d668e55cc619f

2016-04-30 16:25:24 -07:00

Christopher Chedeau

e1f04bf2e3

Quit early if node < 4

Summary:
Before we would display this warning at the top and have the packager throw thousands of lines of errors because of es6 syntax.

Before:

<img width="602" alt="screen shot 2016-02-04 at 1 49 27 pm" src="https://cloud.githubusercontent.com/assets/197597/12831357/a72bdc0a-cb48-11e5-9b81-dde895eaf113.png">

After:

<img width="1440" alt="screen shot 2016-02-04 at 2 04 50 pm" src="https://cloud.githubusercontent.com/assets/197597/12831364/af1c16a0-cb48-11e5-949c-c470938f8b49.png">
Closes https://github.com/facebook/react-native/pull/5767

Reviewed By: svcscm

Differential Revision: D2902978

Pulled By: androidtrunkagent

fb-gh-sync-id: c0193c3b1e36778d61aa9013f0c294f8c3475442

2016-02-04 15:23:57 -08:00

Martín Bigio

849aa4dae6

Move `private-cli` commands to `local-cli`

Summary: public

We cannot remove `local-cli` because is referenced by the global cli explicitly. If we do so, people would have to upgrate this global thin cli which will cause some pain. So, lets move `private-cli` commands into `local-cli` instead.

Reviewed By: frantic

Differential Revision: D2571983

fb-gh-sync-id: 712c29430203660fb6f0d5f23813cb2a7156ee48

2015-10-26 15:36:04 -07:00

3 Commits