react-native

Commit Graph

Author	SHA1	Message	Date
Tomas Roos	1e32de0304	Make sure to run all subspecs, to find failing cases Summary: Thanks for submitting a PR! Please read these instructions carefully: Currently no subspecs are running on CI which causes us to find bugs in the podspec from time to time we upgrade master. In order to highlight errors for podspecs users when changes happen we should make sure to run all subspecs even though it might take a bit longer when running the CI Closes https://github.com/facebook/react-native/pull/14019 Differential Revision: D5079230 Pulled By: javache fbshipit-source-id: 7b3b5dba5ba147b1fc24e79299ed260f9fc6231b	2017-05-17 11:16:49 -07:00
Eloy Durán	09b8ef41e1	Fix issue with whitespace in path to source and stabilise CI. Summary: * Fixes issue where headers could not be found due to whitespace in an unquoted header search path. https://github.com/facebook/react-native/issues/11781#issuecomment-287176373 * Stabilises CI but not needing to download the source for Yoga, but use the existing cloned repo instead. /cc mkonicek Closes https://github.com/facebook/react-native/pull/13007 Differential Revision: D4735347 fbshipit-source-id: 933aefcb0e65537d2e759d25f4e3b81cdf4b8cb5	2017-03-18 12:31:37 -07:00
Eloy Durán	031cb2045d	Make podspec great again. Summary: Fixes #11272 Fixes #11572 Fixes #11781 The main changes here are: * This depends on the latest CocoaPods (1.2.0). It’s currently in RC, but if I’m not mistaken a proper release is expected soon. /cc dantoml * Adds required header search paths for the jschelpers and cxxreact subspecs. * Makes the jschelpers and cxxreact headers private to building React Native, not visible to the user’s project. * It uses the canonical upstream Yoga v1.0.0 podspec: https://github.com/facebook/yoga/blob/master/Yoga.podspec * Consistent styling. I have been able to get our app to build again using this https://github.com/artsy/emission/pull/437. The spec has some warnings, but otherwise fully passes lint. rh389 sjmueller Could you please test with your projects? Closes https://github.com/facebook/react-native/pull/12089 Differential Revision: D4518605 fbshipit-source-id: ecf86232d8b1af52d139eadd1acc10f5c1d42c29	2017-02-06 16:30:00 -08:00

Author

SHA1

Message

Date

Tomas Roos

1e32de0304

Make sure to run all subspecs, to find failing cases

Summary:
Thanks for submitting a PR! Please read these instructions carefully:

Currently no subspecs are running on CI which causes us to find bugs in the podspec from time to time we upgrade master.

In order to highlight errors for podspecs users when changes happen we should make sure to run all subspecs even though it might take a bit longer when running the CI
Closes https://github.com/facebook/react-native/pull/14019

Differential Revision: D5079230

Pulled By: javache

fbshipit-source-id: 7b3b5dba5ba147b1fc24e79299ed260f9fc6231b

2017-05-17 11:16:49 -07:00

Eloy Durán

09b8ef41e1

Fix issue with whitespace in path to source and stabilise CI.

Summary:
* Fixes issue where headers could not be found due to whitespace in an unquoted header search path. https://github.com/facebook/react-native/issues/11781#issuecomment-287176373
* Stabilises CI but not needing to download the source for Yoga, but use the existing cloned repo instead.

/cc mkonicek
Closes https://github.com/facebook/react-native/pull/13007

Differential Revision: D4735347

fbshipit-source-id: 933aefcb0e65537d2e759d25f4e3b81cdf4b8cb5

2017-03-18 12:31:37 -07:00

Eloy Durán

031cb2045d

Make podspec great again.

Summary:
Fixes #11272
Fixes #11572
Fixes #11781

The main changes here are:

* This depends on the latest CocoaPods (1.2.0). It’s currently in RC, but if I’m not mistaken a proper release is expected soon. /cc dantoml
* Adds required header search paths for the jschelpers and cxxreact subspecs.
* Makes the jschelpers and cxxreact headers private to building React Native, not visible to the user’s project.
* It uses the canonical upstream Yoga v1.0.0 podspec: https://github.com/facebook/yoga/blob/master/Yoga.podspec
* Consistent styling.

I have been able to get our app to build again using this https://github.com/artsy/emission/pull/437. The spec has some warnings, but otherwise fully passes lint.

rh389 sjmueller Could you please test with your projects?
Closes https://github.com/facebook/react-native/pull/12089

Differential Revision: D4518605

fbshipit-source-id: ecf86232d8b1af52d139eadd1acc10f5c1d42c29

2017-02-06 16:30:00 -08:00

3 Commits