Scott Wolchok
|
d932c96ddc
|
Don't preallocate child lists
Reviewed By: emilsjolander
Differential Revision: D4078012
fbshipit-source-id: 7cdcab03ec4067550a5fee5e1baea14344f3a8f9
|
2016-10-25 17:13:36 -07:00 |
rh389
|
d943e28bc6
|
Use quote style for local includes
Summary:
This PR changes `#include <CSSLayout/*.h>` to `#include "*.h"` within the `CSSLayout` directory.
Rationale: Quote includes are preferred for user (aka local/project) includes, whereas angle includes are preferred for standard libraries and external frameworks. In particular, XCode 7.1+ will not search user paths (even the current directory) when angle brackets are used unless "Always search user paths" is enabled - it is off by default and [Apple recommend](https://developer.apple.com/library/mac/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW110) that it is only enabled for backwards compatibility.
I think this is the best fix for https://github.com/facebook/react-native/issues/9014, and seems like good practice in any case.
Closes https://github.com/facebook/css-layout/pull/217
Reviewed By: majak
Differential Revision: D3764132
Pulled By: emilsjolander
fbshipit-source-id: c8a6e8d19db71455922e3ba8f6c72bd66018fa84
|
2016-08-24 10:43:42 -07:00 |
Emil Sjolander
|
25f2a26ce9
|
Use const where possible
Reviewed By: IanChilds
Differential Revision: D3741999
fbshipit-source-id: 1ba7da5784c3047f2d4c03746890192f724aa65e
|
2016-08-22 06:59:03 -07:00 |
|
Emil Sjolander
|
043a6cd2c1
|
Update clang-format rules
Reviewed By: IanChilds
Differential Revision: D3714510
fbshipit-source-id: f6d0436346416aab023aacbedd70ea189e583e8d
|
2016-08-15 09:28:41 -07:00 |
|
Emil Sjolander
|
4983a58d6c
|
Add and run clang format script
Reviewed By: lucasr
Differential Revision: D3662225
fbshipit-source-id: ddd4064cbf9be21ca6a97001ace1b56b4314c86f
|
2016-08-04 08:28:53 -07:00 |
|
Emil Sjolander
|
f94e4348dd
|
Implement custom assert macro
Reviewed By: javache
Differential Revision: D3648805
fbshipit-source-id: a6bf1bb55e1e0ee37284647ab76d66f3956a66c0
|
2016-08-02 08:13:58 -07:00 |
|
Emil Sjolander
|
2d168fcd61
|
use #pragma once
Reviewed By: lucasr
Differential Revision: D3648895
fbshipit-source-id: faf42cda82764adaf41cf3f3f9109d48aea203fe
|
2016-08-02 08:13:58 -07:00 |
|
Emil Sjolander
|
ef585e33b1
|
Make use of modern standard types
Reviewed By: lucasr
Differential Revision: D3649096
fbshipit-source-id: dc9fc8861c3106494c5d00d6ac337da50a4c945b
|
2016-08-02 08:13:57 -07:00 |
|
Emil Sjolander
|
0df569dc7f
|
Handle children internally in CSSLayout
Reviewed By: javache
Differential Revision: D3588205
fbshipit-source-id: 27f701a9a85cc0e86bb1d233a6bc74b529a8d4d4
|
2016-07-20 13:28:30 -07:00 |