status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fabric: Proper way to stop Fabric Surfaces 

Summary:
@public
Apparently, we have to call `ReactFabric.unmountComponentAtNode(tag)` instead of `AppRegistry.unmountApplicationComponentAtRootTag(tag)`.

Reviewed By: sahrens

Differential Revision: D9652730

fbshipit-source-id: f56dba7dbe5421a7d939b91178db5104476fe550
This commit is contained in:
Valentin Shergin 2018-09-07 23:38:53 -07:00 committed by Facebook Github Bot
parent d2186081b3
commit ff1b950e29
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
React/Fabric/RCTSurfacePresenter.mm
View File

@ -147,7 +147,7 @@ using namespace facebook::react;
- (void)stopSurface:(RCTFabricSurface *)surface - (void)stopSurface:(RCTFabricSurface *)surface
{ {
[_batchedBridge enqueueJSCall:@"AppRegistry" method:@"unmountApplicationComponentAtRootTag" args:@[@(surface.rootTag)] completion:NULL]; [_batchedBridge enqueueJSCall:@"ReactFabric" method:@"unmountComponentAtNode" args:@[@(surface.rootTag)] completion:NULL];
} }
#pragma mark - RCTMountingManagerDelegate #pragma mark - RCTMountingManagerDelegate