status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-22 22:28:09 +00:00
Code Issues Projects Releases Wiki Activity

Replace String with constants for Module names in Fb4aCoreInfraPackage

Browse Source 
Summary: Using constants is safer than using strings. More details at D12843649

Reviewed By: sahrens

Differential Revision: D8226521

fbshipit-source-id: 4c78c8dfe0bd658f46c8f81e50ceae9299fc6f3c
This commit is contained in:
Ram N 2018-11-08 12:27:12 -08:00 committed by Facebook Github Bot
parent 8d5d144046
commit fe498096b6
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/devsupport/JSDevSupport.java
View File

@ -20,7 +20,7 @@ import javax.annotation.Nullable;
@ReactModule(name = JSDevSupport.MODULE_NAME) @ReactModule(name = JSDevSupport.MODULE_NAME)
public class JSDevSupport extends ReactContextBaseJavaModule { public class JSDevSupport extends ReactContextBaseJavaModule {
static final String MODULE_NAME = "JSDevSupport"; public static final String MODULE_NAME = "JSDevSupport";
public static final int ERROR_CODE_EXCEPTION = 0; public static final int ERROR_CODE_EXCEPTION = 0;
public static final int ERROR_CODE_VIEW_NOT_FOUND = 1; public static final int ERROR_CODE_VIEW_NOT_FOUND = 1;

6
ReactAndroid/src/main/java/com/facebook/react/modules/i18nmanager/I18nManagerModule.java
View File

@ -19,9 +19,11 @@ import java.util.Map;
/** /**
* {@link NativeModule} that allows JS to set allowRTL and get isRTL status. * {@link NativeModule} that allows JS to set allowRTL and get isRTL status.
*/ */
@ReactModule(name = "I18nManager") @ReactModule(name = I18nManagerModule.NAME)
public class I18nManagerModule extends ContextBaseJavaModule { public class I18nManagerModule extends ContextBaseJavaModule {
public static final String NAME = "I18nManager";
private final I18nUtil sharedI18nUtilInstance = I18nUtil.getInstance(); private final I18nUtil sharedI18nUtilInstance = I18nUtil.getInstance();
public I18nManagerModule(Context context) { public I18nManagerModule(Context context) {
@ -30,7 +32,7 @@ public class I18nManagerModule extends ContextBaseJavaModule {
@Override @Override
public String getName() { public String getName() {
return "I18nManager"; return NAME;
} }
@Override @Override

8
ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java
View File

@ -25,10 +25,10 @@ import com.facebook.react.modules.network.ForwardingCookieHandler;
import java.io.IOException; import java.io.IOException;
import java.net.URI; import java.net.URI;
import java.net.URISyntaxException; import java.net.URISyntaxException;
import java.util.concurrent.ConcurrentHashMap;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import okhttp3.OkHttpClient; import okhttp3.OkHttpClient;
@ -38,9 +38,9 @@ import okhttp3.WebSocket;
import okhttp3.WebSocketListener; import okhttp3.WebSocketListener;
import okio.ByteString; import okio.ByteString;
@ReactModule(name = "WebSocketModule", hasConstants = false) @ReactModule(name = WebSocketModule.NAME, hasConstants = false)
public final class WebSocketModule extends ReactContextBaseJavaModule { public final class WebSocketModule extends ReactContextBaseJavaModule {
public static final String NAME="WebSocketModule";
public interface ContentHandler { public interface ContentHandler {
void onMessage(String text, WritableMap params); void onMessage(String text, WritableMap params);
@ -67,7 +67,7 @@ public final class WebSocketModule extends ReactContextBaseJavaModule {
@Override @Override
public String getName() { public String getName() {
return "WebSocketModule"; return NAME;
} }
public void setContentHandler(final int id, final ContentHandler contentHandler) { public void setContentHandler(final int id, final ContentHandler contentHandler) {