packager: JSTransform cleanup: remove options object

Summary: We can simplify as there's only one option, and it seems to me we can also make it required, as otherwise the `JSTransformer` is essentially doing nothing. I don't believe we still have use cases where no transform happens at all, even in OSS?

Reviewed By: davidaurelio

Differential Revision: D4481723

fbshipit-source-id: b2e3830b206d56242d298ff3a7b5f4587ecfd29a

packager/react-packager/src/Bundler/index.js

@@ -143,9 +143,8 @@ class Bundler {
       cacheKey: transformCacheKey,
     });
 
-    this._transformer = new Transformer({
+    /* $FlowFixMe: in practice it's always here. */
-      transformModulePath: opts.transformModulePath,
+    this._transformer = new Transformer(opts.transformModulePath);
-    });
 
     this._resolver = new Resolver({
       assetExts: opts.assetExts,

packager/react-packager/src/JSTransformer/__tests__/Transformer-test.js

@@ -25,7 +25,7 @@ var Transformer = require('../');
 const {any} = jasmine;
 
 describe('Transformer', function() {
-  let options, workers, Cache;
+  let workers, Cache;
   const fileName = '/an/arbitrary/file.js';
   const transformModulePath = __filename;
 
@@ -34,7 +34,6 @@ describe('Transformer', function() {
     Cache.prototype.get = jest.fn((a, b, c) => c());
 
     fs.writeFileSync.mockClear();
-    options = {transformModulePath};
     workerFarm.mockClear();
     workerFarm.mockImplementation((opts, path, methods) => {
       const api = workers = {};
@@ -43,11 +42,11 @@ describe('Transformer', function() {
     });
   });
 
-  it('passes transform module path, file path, source code,' +
+  it('passes transform module path, file path, source code' +
-    ' and options to the worker farm when transforming', () => {
+    ' to the worker farm when transforming', () => {
     const transformOptions = {arbitrary: 'options'};
     const code = 'arbitrary(code)';
-    new Transformer(options).transformFile(fileName, code, transformOptions);
+    new Transformer(transformModulePath).transformFile(fileName, code, transformOptions);
     expect(workers.transformAndExtractDependencies).toBeCalledWith(
       transformModulePath,
       fileName,
@@ -58,7 +57,7 @@ describe('Transformer', function() {
   });
 
   it('should add file info to parse errors', function() {
-    const transformer = new Transformer(options);
+    const transformer = new Transformer(transformModulePath);
     var message = 'message';
     var snippet = 'snippet';
 

packager/react-packager/src/JSTransformer/index.js

@@ -13,12 +13,13 @@
 
 const Logger = require('../Logger');
 
-const declareOpts = require('../lib/declareOpts');
+const debug = require('debug')('RNP:JStransformer');
 const denodeify = require('denodeify');
+const invariant = require('fbjs/lib/invariant');
 const os = require('os');
+const path = require('path');
 const util = require('util');
 const workerFarm = require('worker-farm');
-const debug = require('debug')('RNP:JStransformer');
 
 import type {Data as TransformData, Options as TransformOptions} from './worker/worker';
 import type {SourceMap} from '../lib/SourceMap';
@@ -34,17 +35,6 @@ const TRANSFORM_TIMEOUT_INTERVAL = 301000;
 // How may times can we tolerate failures from the worker.
 const MAX_RETRIES = 2;
 
-const validateOpts = declareOpts({
-  transformModulePath: {
-    type:'string',
-    required: false,
-  },
-});
-
-type Options = {
-  transformModulePath?: ?string,
-};
-
 const maxConcurrentWorkers = ((cores, override) => {
   if (override) {
     return Math.min(cores, override);
@@ -79,11 +69,8 @@ function makeFarm(worker, methods, timeout) {
 
 class Transformer {
 
-  _opts: {
-    transformModulePath?: ?string,
-  };
   _workers: {[name: string]: mixed};
-  _transformModulePath: ?string;
+  _transformModulePath: string;
   _transform: (
     transform: string,
     filename: string,
@@ -96,13 +83,9 @@ class Transformer {
     sourceMap: SourceMap,
   ) => Promise<{code: string, map: SourceMap}>;
 
-  constructor(options: Options) {
+  constructor(transformModulePath: string) {
-    const opts = this._opts = validateOpts(options);
+    invariant(path.isAbsolute(transformModulePath), 'transform module path should be absolute');
-
+    this._transformModulePath = transformModulePath;
-    const {transformModulePath} = opts;
-
-    if (transformModulePath) {
-      this._transformModulePath = require.resolve(transformModulePath);
 
     this._workers = makeFarm(
       require.resolve('./worker'),
@@ -112,7 +95,6 @@ class Transformer {
     this._transform = denodeify(this._workers.transformAndExtractDependencies);
     this.minify = denodeify(this._workers.minify);
   }
-  }
 
   kill() {
     this._workers && workerFarm.end(this._workers);
@@ -124,7 +106,6 @@ class Transformer {
     }
     debug('transforming file', fileName);
     return this
-      /* $FlowFixMe: _transformModulePath may be empty, see constructor */
       ._transform(this._transformModulePath, fileName, code, options)
       .then(data => {
         Logger.log(data.transformFileStartLogEntry);
@@ -145,8 +126,7 @@ class Transformer {
         } else if (error.type === 'ProcessTerminatedError') {
           const uncaughtError = new Error(
             'Uncaught error in the transformer worker: ' +
-            /* $FlowFixMe: _transformModulePath may be empty, see constructor */
+            this._transformModulePath
-            this._opts.transformModulePath
           );
           /* $FlowFixMe: monkey-patch Error */
           uncaughtError.type = 'ProcessTerminatedError';