status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-05 14:13:26 +00:00
Code Issues Projects Releases Wiki Activity

Fabric: Generalizing cloning of YogaLayoutable approach

Browse Source 
Summary:
@public
Non-null owner pointer in Yoga node indicates that this node is already being used by some other subtree, so it must be cloned in case of possible (re)layout.
Theoretically, this node must/can be cloned by Yoga right before applying a new layout to this node, but Yoga has a special optimization that uses that fact that Yoga always cloning *all* children of a particular node altogether. This is not true for React; to meet React and Yoga worlds we double check the owner pointer in `addChild` and clone node preliminary if needed.
See also the previous diff for more context.

Reviewed By: mdvacca

Differential Revision: D8709952

fbshipit-source-id: 84ef0faa0f1d9cc9a8136b550cf325bc20508d53
This commit is contained in:
Valentin Shergin 2018-07-15 16:46:16 -07:00 committed by Facebook Github Bot
parent e1cca18d00
commit fcd72bf34a
2 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ReactCommon/fabric/uimanager/FabricUIManager.cpp
View File

@ -230,16 +230,6 @@ SharedShadowNode FabricUIManager::cloneNodeWithNewChildrenAndProps(const SharedS
void FabricUIManager::appendChild(const SharedShadowNode &parentShadowNode, const SharedShadowNode &childShadowNode) {
isLoggingEnabled && LOG(INFO) << "FabricUIManager::appendChild(parentShadowNode: " << parentShadowNode->getDebugDescription(DebugStringConvertibleOptions {.format = false}) << ", childShadowNode: " << childShadowNode->getDebugDescription(DebugStringConvertibleOptions {.format = false}) << ")";
const SharedComponentDescriptor &componentDescriptor = (*componentDescriptorRegistry_)[parentShadowNode];
// TODO: Remove this after we move this to JS side.
if (childShadowNode->getSealed()) {
auto childComponentDescriptor = (*componentDescriptorRegistry_)[childShadowNode];
auto clonedChildShadowNode = childComponentDescriptor->cloneShadowNode(childShadowNode);
auto nonConstClonedChildShadowNode = std::const_pointer_cast<ShadowNode>(clonedChildShadowNode);
componentDescriptor->appendChild(parentShadowNode, clonedChildShadowNode);
return;
}
componentDescriptor->appendChild(parentShadowNode, childShadowNode);
}

12
ReactCommon/fabric/view/yoga/YogaLayoutableShadowNode.cpp
View File

@ -94,12 +94,16 @@ void YogaLayoutableShadowNode::appendChild(SharedYogaLayoutableShadowNode child)
auto yogaNodeRawPtr = &yogaNode_;
auto childYogaNodeRawPtr = &child->yogaNode_;
yogaNodeRawPtr->insertChild(childYogaNodeRawPtr, yogaNodeRawPtr->getChildren().size());
if (childYogaNodeRawPtr->getOwner() == nullptr) {
child->ensureUnsealed();
childYogaNodeRawPtr->setOwner(yogaNodeRawPtr);
if (childYogaNodeRawPtr->getOwner() != nullptr) {
child = std::static_pointer_cast<const YogaLayoutableShadowNode>(cloneAndReplaceChild(child));
childYogaNodeRawPtr = &child->yogaNode_;
}
child->ensureUnsealed();
childYogaNodeRawPtr->setOwner(yogaNodeRawPtr);
yogaNodeRawPtr->insertChild(childYogaNodeRawPtr, yogaNodeRawPtr->getChildren().size());
}
void YogaLayoutableShadowNode::layout(LayoutContext layoutContext) {