status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix JSX string props quote convention 

Summary:
Not sure if I misunderstand the previous JSX convention. But I found that in JSX string props, double-quote is preferred instead.

https://github.com/facebook/react-native/blob/master/.eslintrc#L182

![screen shot 2016-07-21 at 5 32 04 am](https://cloud.githubusercontent.com/assets/6204776/17006166/137db7ae-4f09-11e6-871b-2cf99960e3a1.png)
Closes https://github.com/facebook/react-native/pull/8933

Differential Revision: D3597084

fbshipit-source-id: 606a2123f1a1ff1fe2234b636b68b3273ebf6ebb
This commit is contained in:
Fadil Sutomo 2016-07-20 20:01:33 -07:00 committed by Facebook Github Bot 1
parent 700e82f663
commit faabeadebf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -101,7 +101,7 @@ Facebook has a [bounty program](https://www.facebook.com/whitehat/) for the safe
#### JSX #### JSX
* Prefer `'` over `"` for string literal props * Prefer `"` over `'` for string literal props
* When wrapping opening tags over multiple lines, place one prop per line * When wrapping opening tags over multiple lines, place one prop per line
* `{}` of props should hug their values (no spaces) * `{}` of props should hug their values (no spaces)
* Place the closing `>` of opening tags on the same line as the last prop * Place the closing `>` of opening tags on the same line as the last prop