status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-25 15:45:32 +00:00
Code Issues Projects Releases Wiki Activity

Fix rest operator syntax errors

Browse Source 
Summary:
These are caused by new [syntax checking](1285131e3e/CHANGELOG.md (v6113-2016-10-01)) introduced by babylon.

"The single rest at the end only applies to binding `let { x, ...y } = obj;` and assignment `({ x, ...y } = obj).`"

I'd say this really should be cherry picked into the stable branch.

**Test plan**
1. install babylon@6.11.3
2. see that things break
3. apply patch
4. things work
5. make sure all instances were fixed (I used `\.\.\..*,.*\n.*=` in IntelliJ regex format—find all ... followed by newline followed by =)

Issue #10199
Closes https://github.com/facebook/react-native/pull/10200

Differential Revision: D3974066

Pulled By: javache

fbshipit-source-id: 3f3c1e9df01a3b3bdd61dd3863416c638d3ed98d
This commit is contained in:
Michał Łazowik 2016-10-05 04:41:32 -07:00 committed by Facebook Github Bot
parent 1941450649
commit f77185f27e
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/BatchedBridge/BatchedBridgedModules/NativeModules.js
View File

@ -108,7 +108,7 @@ function arrayContains<T>(array: Array<T>, value: T): boolean {
function createErrorFromErrorData(errorData: {message: string}): Error { function createErrorFromErrorData(errorData: {message: string}): Error {
const { const {
message, message,
...extraErrorInfo, ...extraErrorInfo
} = errorData; } = errorData;
const error = new Error(message); const error = new Error(message);
(error:any).framesToPop = 1; (error:any).framesToPop = 1;

2
Libraries/CustomComponents/ListView/ListView.js
View File

@ -454,7 +454,7 @@ var ListView = React.createClass({
var { var {
renderScrollComponent, renderScrollComponent,
...props, ...props
} = this.props; } = this.props;
if (!props.scrollEventThrottle) { if (!props.scrollEventThrottle) {
props.scrollEventThrottle = DEFAULT_SCROLL_CALLBACK_THROTTLE; props.scrollEventThrottle = DEFAULT_SCROLL_CALLBACK_THROTTLE;

2
Libraries/CustomComponents/NavigationExperimental/NavigationCard.js
View File

@ -82,7 +82,7 @@ class NavigationCard extends React.Component<any, Props, any> {
pointerEvents, pointerEvents,
renderScene, renderScene,
style, style,
...props, /* NavigationSceneRendererProps */ ...props /* NavigationSceneRendererProps */
} = this.props; } = this.props;
const viewStyle = style === undefined ? const viewStyle = style === undefined ?