status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-12 18:44:25 +00:00
Code Issues Projects Releases Wiki Activity

End metro server gracefully when there are some edge errors

Browse Source 
Summary: This diff fixes a couple of edge cases that caused Metro to keep the process running when there were some specific errors (specially around the `dependencies` command and the transformer path).

Reviewed By: jrwats

Differential Revision: D9551834

fbshipit-source-id: 959cefcec9e2687dff89c94a871ae74c50d2dd77
This commit is contained in:
Rafael Oleza 2018-08-30 03:22:17 -07:00 committed by Facebook Github Bot
parent f9e823fb5a
commit f661e0fb6e
1 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
local-cli/dependencies/dependencies.js
View File

@ -44,29 +44,26 @@ async function dependencies(argv, configPromise, args, packagerInstance) {
? fs.createWriteStream(args.output) ? fs.createWriteStream(args.output)
: process.stdout; : process.stdout;
return Promise.resolve( const deps = packagerInstance
(packagerInstance ? await packagerInstance.getOrderedDependencyPaths(options)
? packagerInstance.getOrderedDependencyPaths(options) : await Metro.getOrderedDependencyPaths(config, options);
: Metro.getOrderedDependencyPaths(config, options)
).then(deps => {
deps.forEach(modulePath => {
// Temporary hack to disable listing dependencies not under this directory.
// Long term, we need either
// (a) JS code to not depend on anything outside this directory, or
// (b) Come up with a way to declare this dependency in Buck.
const isInsideProjectRoots =
config.watchFolders.filter(root => modulePath.startsWith(root))
.length > 0;
if (isInsideProjectRoots) { deps.forEach(modulePath => {
outStream.write(modulePath + '\n'); // Temporary hack to disable listing dependencies not under this directory.
} // Long term, we need either
}); // (a) JS code to not depend on anything outside this directory, or
return writeToFile // (b) Come up with a way to declare this dependency in Buck.
? denodeify(outStream.end).bind(outStream)() const isInsideProjectRoots =
: Promise.resolve(); config.watchFolders.filter(root => modulePath.startsWith(root)).length >
}), 0;
);
if (isInsideProjectRoots) {
outStream.write(modulePath + '\n');
}
});
return writeToFile
? denodeify(outStream.end).bind(outStream)()
: Promise.resolve();
} }
module.exports = { module.exports = {