status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert D8786185: [fabric][android] Create CXX Binding 

Differential Revision:
D8786185

Original commit changeset: d04208f07813

fbshipit-source-id: 1fc1648146ea9784bb364c4e56e8664bb8bb655f
This commit is contained in:
Ben Blackburne 2018-07-17 03:25:18 -07:00 committed by Facebook Github Bot
parent bf22d904fe
commit f5f27b3687
4 changed files with 3 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricBinder.java
View File

@ -1,14 +0,0 @@
/**
* Copyright (c) 2014-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
package com.facebook.react.fabric;
public interface FabricBinder {
void setBinding(FabricBinding binding);
}

3
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricBinding.java
View File

@ -9,11 +9,10 @@ package com.facebook.react.fabric;
import com.facebook.react.bridge.JavaScriptContextHolder;
import com.facebook.react.bridge.NativeMap;
import com.facebook.react.bridge.UIManager;
public interface FabricBinding {
void installFabric(JavaScriptContextHolder jsContext, FabricBinder fabricBinder);
void installFabric(JavaScriptContextHolder jsContext, FabricUIManager fabricModule);
void releaseEventTarget(long jsContextNativePointer, long eventTargetPointer);

3
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
View File

@ -60,7 +60,7 @@ import javax.annotation.Nullable;
*/
@SuppressWarnings("unused") // used from JNI
@DoNotStrip
public class FabricUIManager implements UIManager, JSHandler, FabricBinder {
public class FabricUIManager implements UIManager, JSHandler {
private static final String TAG = FabricUIManager.class.getSimpleName();
private static final boolean DEBUG = ReactBuildConfig.DEBUG || PrinterHolder.getPrinter().shouldDisplayLogMessage(ReactDebugOverlayTags.FABRIC_UI_MANAGER);
@ -98,7 +98,6 @@ public class FabricUIManager implements UIManager, JSHandler, FabricBinder {
mJSContext = jsContext;
}
@Override
public void setBinding(FabricBinding binding) {
mBinding = binding;
}

4
ReactAndroid/src/main/java/com/facebook/react/fabric/jsc/FabricJSCBinding.java
View File

@ -10,8 +10,6 @@ package com.facebook.react.fabric.jsc;
import com.facebook.jni.HybridData;
import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.JavaScriptContextHolder;
import com.facebook.react.bridge.UIManager;
import com.facebook.react.fabric.FabricBinder;
import com.facebook.react.fabric.FabricBinding;
import com.facebook.react.fabric.FabricUIManager;
import com.facebook.react.bridge.NativeMap;
@ -60,7 +58,7 @@ public class FabricJSCBinding implements FabricBinding {
}
@Override
public void installFabric(JavaScriptContextHolder jsContext, FabricBinder fabricModule) {
public void installFabric(JavaScriptContextHolder jsContext, FabricUIManager fabricModule) {
fabricModule.setBinding(this);
installFabric(jsContext.get(), fabricModule);
}