mirror of
https://github.com/status-im/react-native.git
synced 2025-01-14 11:34:23 +00:00
Add missing toggleElementInspector
event send when jsLoaded
Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. The PR #11613 (0.43) removed this missing `toggleElementInspector` event send when `jsLoaded` in DevMenu (Now is DevSettings), it should open the inspector if `isElementInspectorShown` is true when we reload JS. The dev menu text `Show / Hide Inspector` is dependent on `isElementInspectorShown` bool value. ([This behavior in 0.42](https://github.com/facebook/react-native/blob/0.42-stable/React/Modules/RCTDevMenu.mm#L436-L442)) Manual testing in UIExplorer: * Open the dev menu and click `Show Inspector` * Open the dev menu and click `Reload JS` * The built-in inspector should keep open (dev menu text: `Hide Inspector`) Closes https://github.com/facebook/react-native/pull/12999 Differential Revision: D4738959 Pulled By: javache fbshipit-source-id: b3f584db51aa0e1b463c52003967b00bcd81bc99
This commit is contained in:
parent
439889262c
commit
f352aa129a
@ -454,6 +454,14 @@ RCT_EXPORT_METHOD(toggleElementInspector)
|
||||
dispatch_async(dispatch_get_main_queue(), ^{
|
||||
// update state again after the bridge has finished loading
|
||||
[self _synchronizeAllSettings];
|
||||
|
||||
// Inspector can only be shown after JS has loaded
|
||||
if ([self isElementInspectorShown]) {
|
||||
#pragma clang diagnostic push
|
||||
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
||||
[self.bridge.eventDispatcher sendDeviceEventWithName:@"toggleElementInspector" body:nil];
|
||||
#pragma clang diagnostic pop
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user