status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Throw when failing to load script 

Reviewed By: AaaChiuuu

Differential Revision: D4929104

fbshipit-source-id: 115a44097b26bc11d20059c1667b9cf36fc47be9
This commit is contained in:
Pieter De Baets 2017-04-24 03:44:47 -07:00 committed by Facebook Github Bot
parent 43fd94daef
commit f09fdcbd2b
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ReactAndroid/src/main/jni/xreact/jni/JSLoader.cpp
View File

@ -2,6 +2,7 @@
#include "JSLoader.h" #include "JSLoader.h"
#include <folly/Conv.h>
#include <folly/Memory.h> #include <folly/Memory.h>
#include <android/asset_manager_jni.h> #include <android/asset_manager_jni.h>
#include <fb/fbjni.h> #include <fb/fbjni.h>
@ -77,8 +78,9 @@ std::unique_ptr<const JSBigString> loadScriptFromAssets(
} }
} }
} }
FBLOGE("Unable to load script from assets: %s", assetName.c_str());
return folly::make_unique<JSBigStdString>(""); throw std::runtime_error(folly::to<std::string>("Unable to load script from assets '", assetName,
"'. Make sure your bundle is packaged correctly or you're running a packager server."));
} }
std::string loadScriptFromFile(const std::string& fileName) { std::string loadScriptFromFile(const std::string& fileName) {
@ -98,8 +100,8 @@ std::string loadScriptFromFile(const std::string& fileName) {
return output; return output;
} }
FBLOGE("Unable to load script from file: %s", fileName.c_str()); throw std::runtime_error(folly::to<std::string>("Unable to load script from file: '", fileName,
return ""; "'. Make sure your bundle is packaged correctly or you're running a packager server."));
} }
} } } }