From ef863c06797df80e28c074ae021842a5067cae42 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 24 Sep 2018 11:16:19 -0700 Subject: [PATCH] Remove unused parameters in ReactInstanceManager methods Summary: Just a small diff to remove some unused parameters in some methods of the ReactInstnaceManager class Reviewed By: achen1 Differential Revision: D10011168 fbshipit-source-id: 2247ecd01bfc63c27837c6abad4bff1b4e590ac0 --- .../java/com/facebook/react/ReactInstanceManager.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index 1830f4538..6402c9dbe 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -49,7 +49,6 @@ import com.facebook.react.bridge.CatalystInstance; import com.facebook.react.bridge.CatalystInstanceImpl; import com.facebook.react.bridge.JSBundleLoader; import com.facebook.react.bridge.JSIModulePackage; -import com.facebook.react.bridge.JSIModuleRegistry; import com.facebook.react.bridge.JavaJSExecutor; import com.facebook.react.bridge.JavaScriptExecutor; import com.facebook.react.bridge.JavaScriptExecutorFactory; @@ -724,7 +723,7 @@ public class ReactInstanceManager { // automatically when creation completes, as root view is part of the attached root view list. ReactContext currentContext = getCurrentReactContext(); if (mCreateReactContextThread == null && currentContext != null) { - attachRootViewToInstance(rootView, currentContext.getCatalystInstance()); + attachRootViewToInstance(rootView); } } @@ -987,7 +986,7 @@ public class ReactInstanceManager { ReactMarker.logMarker(ATTACH_MEASURED_ROOT_VIEWS_START); synchronized (mAttachedRootViews) { for (ReactRootView rootView : mAttachedRootViews) { - attachRootViewToInstance(rootView, catalystInstance); + attachRootViewToInstance(rootView); } } ReactMarker.logMarker(ATTACH_MEASURED_ROOT_VIEWS_END); @@ -1025,8 +1024,7 @@ public class ReactInstanceManager { } private void attachRootViewToInstance( - final ReactRootView rootView, - CatalystInstance catalystInstance) { + final ReactRootView rootView) { Log.d(ReactConstants.TAG, "ReactInstanceManager.attachRootViewToInstance()"); Systrace.beginSection(TRACE_TAG_REACT_JAVA_BRIDGE, "attachRootViewToInstance"); UIManager uiManagerModule = UIManagerHelper.getUIManager(mCurrentReactContext, rootView.getUIManagerType());