From eef8d47a37211bf7d4978db75df1fedd9cacbde8 Mon Sep 17 00:00:00 2001 From: lukedurrant Date: Tue, 11 Sep 2018 13:23:12 -0700 Subject: [PATCH] Correct RCTAnimation import (#18050) Summary: Fixing error node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: 'RCTAnimation/RCTValueAnimatedNode.h' file not found I'm integrating react native into an existing app through cocoa pods and similar to other PRs PR https://github.com/facebook/react-native/pull/16192 PR https://github.com/facebook/react-native/pull/16271 PR https://github.com/facebook/react-native/pull/17764 When integrating with cocoa pods ``` pod 'React', :path => './node_modules/react-native', :subspecs => [ 'Core', 'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43 'RCTText', 'RCTNetwork', 'RCTWebSocket', # needed for debugging 'RCTImage', 'RCTWebSocket', 'BatchedBridge', 'RCTLinkingIOS', 'RCTActionSheet', 'RCTAnimation' ] ``` With `RCTAnimation` being the important part for this PR. Also note without this PR and the other PR's above if anyone is trying to integrate react native into an existing app i.e. through cocoa pods they won't be able too. I think the latest working version is My app wouldn't build without changing this line PR https://github.com/facebook/react-native/pull/16192 PR https://github.com/facebook/react-native/pull/16271 PR https://github.com/facebook/react-native/pull/17764 [IOS] [BREAKING] [PODS] - Fixed RCTAnimation import for integrating with cocoapods Pull Request resolved: https://github.com/facebook/react-native/pull/18050 Differential Revision: D9235162 Pulled By: hramos fbshipit-source-id: 426daccf8d8952658e262d5a0e4623c72c38542c --- Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h b/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h index ae2176684..c66de0e1d 100644 --- a/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h +++ b/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h @@ -6,11 +6,11 @@ */ #import - -#import #import #import +@protocol RCTValueAnimatedNodeObserver; + @interface RCTNativeAnimatedNodesManager : NSObject - (nonnull instancetype)initWithUIManager:(nonnull RCTUIManager *)uiManager;