status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Better error message when trying to parse a empty body in fetch 

Summary: Previously, trying to parse an empty network body would throw "Unexpected EOF" from JSON.parse. Now we explicitly call out the error and provide steps for possible mitigation.

Reviewed By: frantic

Differential Revision: D3528297

fbshipit-source-id: 3b52c9491c1504c282eb9bc12ed46069cb6cbd60
This commit is contained in:
Andy Street 2016-07-07 11:03:09 -07:00 committed by Facebook Github Bot
parent b5c3550857
commit eeb9cd8075
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Libraries/Fetch/fetch.js
View File

@ -11,6 +11,8 @@
*
* @providesModule fetch
* @nolint
*
* NOTE: This file has local changes for RN and is not a straight copy!
*/
/* eslint-disable */
'use strict';
@ -240,7 +242,26 @@ var self = {};
}
this.json = function() {
return this.text().then(JSON.parse)
var status = this.status;
return this.text().then(function(text) {
if (!text) {
var errorText =
'Trying to parse the body of a network response as JSON, but the ' +
'body is null or empty.';
if (status !== 200) {
errorText +=
'\n\nThis can be the result of not properly checking for a 200 OK ' +
'status code before trying to parse the body (the status code for ' +
'this response was ' + status + ').';
} else {
errorText +=
'\n\nThe status code for this response was 200 OK, so nothing ' +
'went obviously wrong. Is your server configured properly?';
}
throw new Error(errorText);
}
return JSON.parse(text);
});
}
return this