From e91cd2eff771bd96e1d1c075a46a92c304948e26 Mon Sep 17 00:00:00 2001 From: Beau Smith Date: Tue, 4 Apr 2017 09:38:47 -0700 Subject: [PATCH] Make clear that onSlidingComplete is called regardless whether value changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Documentation didn't clearly state when onSlidingComplete callback is called. No tests necessary… simply changing docs. Closes https://github.com/facebook/react-native/pull/13282 Differential Revision: D4823866 Pulled By: ericvicenti fbshipit-source-id: 1c3be6ee4d52b097b7558067edf0388739d3f52e --- Libraries/Components/Slider/Slider.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Libraries/Components/Slider/Slider.js b/Libraries/Components/Slider/Slider.js index 6ca9e49ae..a6e03e8e2 100644 --- a/Libraries/Components/Slider/Slider.js +++ b/Libraries/Components/Slider/Slider.js @@ -126,8 +126,9 @@ var Slider = React.createClass({ onValueChange: PropTypes.func, /** - * Callback called when the user finishes changing the value (e.g. when - * the slider is released). + * Callback that is called when the user releases the slider, + * regardless if the value has changed. The current value is passed + * as an argument to the callback handler. */ onSlidingComplete: PropTypes.func,