status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

When subscribing for network connectivity broadcasts, also query the value so we always have the most up-to-date value. 

Summary:
We've seen cases (based on logs) where NetInfo is reporting no connectivity, but network requests still work. This will keep status up to date after app foreground <-> backgrounds, since we don't listen to broadcasts when backgrounded.

This is rather difficult to test given we haven't nailed an internal repro (evidence is solely based on device/app logs).  Testing has been done to ensure that there are no behavioural changes on devices that were previously working (no regressions).
Closes https://github.com/facebook/react-native/pull/15558

Differential Revision: D6264708

Pulled By: hramos

fbshipit-source-id: 1648cadb59949103d0a595614b38024ec9236719
This commit is contained in:
Brent Erickson 2017-11-07 14:49:32 -08:00 committed by Facebook Github Bot
parent cb6ec7c321
commit e6f542d620
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ReactAndroid/src/main/java/com/facebook/react/modules/netinfo/NetInfoModule.java
View File

@ -124,6 +124,7 @@ public class NetInfoModule extends ReactContextBaseJavaModule
filter.addAction(ConnectivityManager.CONNECTIVITY_ACTION); filter.addAction(ConnectivityManager.CONNECTIVITY_ACTION);
getReactApplicationContext().registerReceiver(mConnectivityBroadcastReceiver, filter); getReactApplicationContext().registerReceiver(mConnectivityBroadcastReceiver, filter);
mConnectivityBroadcastReceiver.setRegistered(true); mConnectivityBroadcastReceiver.setRegistered(true);
updateAndSendConnectionType();
} }
private void unregisterReceiver() { private void unregisterReceiver() {