status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Bugfix: Check NodeJS version successfully even for old runtimes (Fixes #20769) (#20779) 

Summary:
Fixes #20769

Release notes
--------------
[CLI] [BUGFIX] [local-cli/server/checkNodeVersion.js] - Disable auto-formatting in `local-cli/server/checkNodeVersion.js` since it introduces ES6 and ES7 syntax (trailing comma in argument list) which in turn makes ES5 engines crash with a `SyntaxError`.
Pull Request resolved: https://github.com/facebook/react-native/pull/20779

Differential Revision: D9468346

Pulled By: hramos

fbshipit-source-id: 24761a377a5fd104e11ed6b6e86da15e96a0e38b
This commit is contained in:
Elias Toivanen 2018-08-22 20:23:43 -07:00 committed by Facebook Github Bot
parent 9a77ff593b
commit e61176d650
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
local-cli/server/checkNodeVersion.js
View File

@ -4,7 +4,10 @@
* This source code is licensed under the MIT license found in the * This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
* *
* @format * Be mindful that this script may be run by legacy NodeJS runtimes. Keep this
* script ES5 compatible (e.g. do not insert the `@format` pragma here which
* may introduce non-ES5 compatible syntax.)
*
*/ */
'use strict'; 'use strict';
@ -36,7 +39,7 @@ module.exports = function() {
marginLeft: 1, marginLeft: 1,
marginRight: 1, marginRight: 1,
paddingBottom: 1, paddingBottom: 1,
}), })
); );
process.exit(1); process.exit(1);
} }