Fixed transparent border around UIExplorer headers

Summary:
public

This was caused by the change to background color propagation, but was actually due to having an unnecessary wrapper view around the headers, which was itself a workaround for a padding bug that was fixed some time ago :-)

Reviewed By: tadeuzagallo

Differential Revision: D2830890

fb-gh-sync-id: b64e701dedb90b357ed7c463b745de021f38637b
This commit is contained in:
Nick Lockwood 2016-01-14 09:55:13 -08:00 committed by facebook-github-bot-5
parent ff6a2c3998
commit e5381072dd
2 changed files with 5 additions and 24 deletions

View File

@ -87,11 +87,9 @@ class UIExplorerListBase extends React.Component {
_renderSectionHeader(data: any, section: string) { _renderSectionHeader(data: any, section: string) {
return ( return (
<View style={styles.sectionHeader}> <Text style={styles.sectionHeader}>
<Text style={styles.sectionHeaderTitle}> {section.toUpperCase()}
{section.toUpperCase()} </Text>
</Text>
</View>
); );
} }
@ -148,14 +146,12 @@ var styles = StyleSheet.create({
}, },
sectionHeader: { sectionHeader: {
padding: 5, padding: 5,
fontWeight: '500',
fontSize: 11,
}, },
group: { group: {
backgroundColor: 'white', backgroundColor: 'white',
}, },
sectionHeaderTitle: {
fontWeight: '500',
fontSize: 11,
},
row: { row: {
backgroundColor: 'white', backgroundColor: 'white',
justifyContent: 'center', justifyContent: 'center',

View File

@ -70,19 +70,4 @@ var TextStylePropTypes = Object.assign(Object.create(ViewStylePropTypes), {
), ),
}); });
// Text doesn't support padding correctly (#4841912)
var unsupportedProps = Object.keys({
padding: null,
paddingTop: null,
paddingLeft: null,
paddingRight: null,
paddingBottom: null,
paddingVertical: null,
paddingHorizontal: null,
});
for (var ii = 0; ii < unsupportedProps.length; ii++) {
delete TextStylePropTypes[unsupportedProps[ii]];
}
module.exports = TextStylePropTypes; module.exports = TextStylePropTypes;