status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Always log exception in DevSupportManager 

Reviewed By: andreicoman11

Differential Revision: D3741763

fbshipit-source-id: b4cc32e4d237955ec4a67af323024acd0d19106a
This commit is contained in:
Alexander Blom 2016-08-19 07:09:32 -07:00 committed by Facebook Github Bot 5
parent 2a7f4be8f8
commit e4d5dcb15b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java
View File

@ -234,8 +234,8 @@ public class DevSupportManagerImpl implements DevSupportManager {
@Override
public void handleException(Exception e) {
if (mIsDevSupportEnabled) {
FLog.e(ReactConstants.TAG, "Exception in native call from JS", e);
if (e instanceof JSException) {
FLog.e(ReactConstants.TAG, "Exception in native call from JS", e);
// TODO #11638796: convert the stack into something useful
showNewError(e.getMessage() + "\n\n" + ((JSException) e).getStack(), new StackFrame[] {},
JSEXCEPTION_ERROR_COOKIE, ErrorType.JS);
@ -249,6 +249,7 @@ public class DevSupportManagerImpl implements DevSupportManager {
@Override
public void showNewJavaError(String message, Throwable e) {
FLog.e(ReactConstants.TAG, "Exception in native call", e);
showNewError(message, StackTraceHelper.convertJavaStackTrace(e), JAVA_ERROR_COOKIE, ErrorType.NATIVE);
}