From e34dd4f9385d20a1596a7b970ce3a7eb82d9c2cc Mon Sep 17 00:00:00 2001 From: Gabe Levi Date: Tue, 2 Aug 2016 20:46:16 -0700 Subject: [PATCH] Deploy v0.30.0 Reviewed By: avikchaudhuri Differential Revision: D3654213 fbshipit-source-id: b03879345ad9beae73a055c1b2e7211d074a08f0 --- .flowconfig | 6 +++--- .../Initialization/ExceptionsManager.js | 9 ++++++--- package.json | 2 +- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.flowconfig b/.flowconfig index 1eb8b65b4..43acd4c9d 100644 --- a/.flowconfig +++ b/.flowconfig @@ -47,11 +47,11 @@ suppress_type=$FlowIssue suppress_type=$FlowFixMe suppress_type=$FixMe -suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-9]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\) -suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(2[0-9]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+ +suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(30\\|[1-2][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\) +suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(30\\|1[0-9]\\|[1-2][0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy unsafe.enable_getters_and_setters=true [version] -^0.29.0 +^0.30.0 diff --git a/Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js b/Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js index 699228de4..b104b98fe 100644 --- a/Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js +++ b/Libraries/JavaScriptAppEngine/Initialization/ExceptionsManager.js @@ -71,9 +71,11 @@ function installConsoleErrorReporter() { if (console._errorOriginal) { return; // already installed } - console._errorOriginal = console.error.bind(console); + // Flow doesn't like it when you set arbitrary values on a global object + (console: any)._errorOriginal = console.error.bind(console); console.error = function reactConsoleError() { - console._errorOriginal.apply(null, arguments); + // Flow doesn't like it when you set arbitrary values on a global object + (console: any)._errorOriginal.apply(null, arguments); if (!console.reportErrorsAsExceptions) { return; } @@ -95,7 +97,8 @@ function installConsoleErrorReporter() { } }; if (console.reportErrorsAsExceptions === undefined) { - console.reportErrorsAsExceptions = true; // Individual apps can disable this + // Flow doesn't like it when you set arbitrary values on a global object + (console: any).reportErrorsAsExceptions = true; // Individual apps can disable this } } diff --git a/package.json b/package.json index 933ee1989..e530e5e59 100644 --- a/package.json +++ b/package.json @@ -201,7 +201,7 @@ "eslint-plugin-babel": "^3.2.0", "eslint-plugin-flow-vars": "^0.2.1", "eslint-plugin-react": "^4.2.1", - "flow-bin": "^0.29.0", + "flow-bin": "^0.30.0", "jest": "latest", "jest-repl": "latest", "jest-runtime": "latest",