status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix typo in ReadableMapKeySetIterator. 

Differential Revision: D2564759

fb-gh-sync-id: 6a57fb71d4da1d467661a3ae786f637172b21e73
This commit is contained in:
Krzysztof Magiera 2015-10-21 04:11:37 -07:00 committed by facebook-github-bot-5
parent f1ab581337
commit e1b2c84a81
7 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactAndroid/src/main/java/com/facebook/react/bridge/InvalidIteratorException.java
View File

@ -12,7 +12,7 @@ package com.facebook.react.bridge;
import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.proguard.annotations.DoNotStrip;
/** /**
* Exception thrown by {@link ReadableMapKeySeyIterator#nextKey()} when the iterator tries * Exception thrown by {@link ReadableMapKeySetIterator#nextKey()} when the iterator tries
* to iterate over elements after the end of the key set. * to iterate over elements after the end of the key set.
*/ */
@DoNotStrip @DoNotStrip

2
ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableMap.java
View File

@ -24,5 +24,5 @@ public interface ReadableMap {
ReadableArray getArray(String name); ReadableArray getArray(String name);
ReadableMap getMap(String name); ReadableMap getMap(String name);
ReadableType getType(String name); ReadableType getType(String name);
ReadableMapKeySeyIterator keySetIterator(); ReadableMapKeySetIterator keySetIterator();
} }

2
ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableMapKeySeyIterator.java → ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableMapKeySetIterator.java
View File

@ -15,7 +15,7 @@ import com.facebook.proguard.annotations.DoNotStrip;
* Interface of a iterator for a {@link NativeMap}'s key set. * Interface of a iterator for a {@link NativeMap}'s key set.
*/ */
@DoNotStrip @DoNotStrip
public interface ReadableMapKeySeyIterator { public interface ReadableMapKeySetIterator {
boolean hasNextKey(); boolean hasNextKey();
String nextKey(); String nextKey();

10
ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeMap.java
View File

@ -44,20 +44,20 @@ public class ReadableNativeMap extends NativeMap implements ReadableMap {
public native ReadableType getType(String name); public native ReadableType getType(String name);
@Override @Override
public ReadableMapKeySeyIterator keySetIterator() { public ReadableMapKeySetIterator keySetIterator() {
return new ReadableNativeMapKeySeyIterator(this); return new ReadableNativeMapKeySetIterator(this);
} }
/** /**
* Implementation of a {@link ReadableNativeMap} iterator in native memory. * Implementation of a {@link ReadableNativeMap} iterator in native memory.
*/ */
@DoNotStrip @DoNotStrip
private static class ReadableNativeMapKeySeyIterator extends Countable private static class ReadableNativeMapKeySetIterator extends Countable
implements ReadableMapKeySeyIterator { implements ReadableMapKeySetIterator {
private final ReadableNativeMap mReadableNativeMap; private final ReadableNativeMap mReadableNativeMap;
public ReadableNativeMapKeySeyIterator(ReadableNativeMap readableNativeMap) { public ReadableNativeMapKeySetIterator(ReadableNativeMap readableNativeMap) {
mReadableNativeMap = readableNativeMap; mReadableNativeMap = readableNativeMap;
initialize(mReadableNativeMap); initialize(mReadableNativeMap);
} }

4
ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyOptimizer.java
View File

@ -14,7 +14,7 @@ import javax.annotation.Nullable;
import android.util.SparseBooleanArray; import android.util.SparseBooleanArray;
import com.facebook.infer.annotation.Assertions; import com.facebook.infer.annotation.Assertions;
import com.facebook.react.bridge.ReadableMapKeySeyIterator; import com.facebook.react.bridge.ReadableMapKeySetIterator;
/** /**
* Class responsible for optimizing the native view hierarchy while still respecting the final UI * Class responsible for optimizing the native view hierarchy while still respecting the final UI
@ -417,7 +417,7 @@ public class NativeViewHierarchyOptimizer {
return false; return false;
} }
ReadableMapKeySeyIterator keyIterator = props.mBackingMap.keySetIterator(); ReadableMapKeySetIterator keyIterator = props.mBackingMap.keySetIterator();
while (keyIterator.hasNextKey()) { while (keyIterator.hasNextKey()) {
if (!ViewProps.isLayoutOnly(keyIterator.nextKey())) { if (!ViewProps.isLayoutOnly(keyIterator.nextKey())) {
return false; return false;

4
ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactShadowNode.java
View File

@ -17,7 +17,7 @@ import java.util.Map;
import com.facebook.csslayout.CSSNode; import com.facebook.csslayout.CSSNode;
import com.facebook.infer.annotation.Assertions; import com.facebook.infer.annotation.Assertions;
import com.facebook.react.bridge.ReadableMap; import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.ReadableMapKeySeyIterator; import com.facebook.react.bridge.ReadableMapKeySetIterator;
/** /**
* Base node class for representing virtual tree of React nodes. Shadow nodes are used primarily * Base node class for representing virtual tree of React nodes. Shadow nodes are used primarily
@ -166,7 +166,7 @@ public class ReactShadowNode extends CSSNode {
Map<String, ViewManagersPropertyCache.PropSetter> propSetters = Map<String, ViewManagersPropertyCache.PropSetter> propSetters =
ViewManagersPropertyCache.getNativePropSettersForShadowNodeClass(getClass()); ViewManagersPropertyCache.getNativePropSettersForShadowNodeClass(getClass());
ReadableMap propMap = props.mBackingMap; ReadableMap propMap = props.mBackingMap;
ReadableMapKeySeyIterator iterator = propMap.keySetIterator(); ReadableMapKeySetIterator iterator = propMap.keySetIterator();
while (iterator.hasNextKey()) { while (iterator.hasNextKey()) {
String key = iterator.nextKey(); String key = iterator.nextKey();
ViewManagersPropertyCache.PropSetter setter = propSetters.get(key); ViewManagersPropertyCache.PropSetter setter = propSetters.get(key);

4
ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java
View File

@ -19,7 +19,7 @@ import android.view.View;
import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap; import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.ReadableMapKeySeyIterator; import com.facebook.react.bridge.ReadableMapKeySetIterator;
import com.facebook.react.touch.CatalystInterceptingViewGroup; import com.facebook.react.touch.CatalystInterceptingViewGroup;
import com.facebook.react.touch.JSResponderHandler; import com.facebook.react.touch.JSResponderHandler;
@ -36,7 +36,7 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode> {
Map<String, ViewManagersPropertyCache.PropSetter> propSetters = Map<String, ViewManagersPropertyCache.PropSetter> propSetters =
ViewManagersPropertyCache.getNativePropSettersForViewManagerClass(getClass()); ViewManagersPropertyCache.getNativePropSettersForViewManagerClass(getClass());
ReadableMap propMap = props.mBackingMap; ReadableMap propMap = props.mBackingMap;
ReadableMapKeySeyIterator iterator = propMap.keySetIterator(); ReadableMapKeySetIterator iterator = propMap.keySetIterator();
// TODO(krzysztof): Remove missingSetters code once all views are migrated to @ReactProp // TODO(krzysztof): Remove missingSetters code once all views are migrated to @ReactProp
boolean missingSetters = false; boolean missingSetters = false;
while (iterator.hasNextKey()) { while (iterator.hasNextKey()) {