status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-28 02:04:55 +00:00
Code Issues Projects Releases Wiki Activity

Fabric: Fixed incorrect usage of Undefined (instead of kFloatUndefined) in yogaValuesConversions

Browse Source 
Summary: `Undefined` is actually equal `0` (becasuse it is `LayoutDirection::Undefined`), whereas `kFloatUndefined` is a magic huge number.

Reviewed By: fkgozali

Differential Revision: D7554550

fbshipit-source-id: 3ea37f0b8b6a59b4b0e00d205b75cd7252247d03
This commit is contained in:
Valentin Shergin 2018-04-10 16:37:16 -07:00 committed by Facebook Github Bot
parent 568529e1ec
commit dd49f9e0bc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactCommon/fabric/view/yoga/yogaValuesConversions.cpp
View File

@ -16,14 +16,14 @@ namespace react {
Float fabricFloatFromYogaFloat(float value) {
if (value == YGUndefined) {
return Undefined;
return kFloatUndefined;
}
return (Float)value;
}
float yogaFloatFromFabricFloat(Float value) {
if (value == Undefined) {
if (value == kFloatUndefined) {
return YGUndefined;
}