status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Redbox on DrawImageWithDrawee exception 

Summary:
DrawImageWithDrawee has caused NPEs when using Nodes in various cases
in RNFeed. This patch explicitly throws a RuntimeException, so that we can
debug as to whether this is coming from bad sources or a bad size for the
image.

Differential Revision: D3574998
This commit is contained in:
Ahmed El-Helw 2016-07-19 16:54:55 -07:00
parent bb5ba3d295
commit d89e7475fb
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
ReactAndroid/src/main/java/com/facebook/react/flat/DrawImageWithDrawee.java
View File

@ -142,14 +142,25 @@ import com.facebook.react.views.imagehelper.MultiSourceHelper.MultiSourceResult;
@Override
public void onDraw(Canvas canvas) {
Assertions.assumeNotNull(mRequestHelper).getDrawable().draw(canvas);
if (mRequestHelper != null) {
mRequestHelper.getDrawable().draw(canvas);
}
}
@Override
public void onAttached(FlatViewGroup.InvalidateCallback callback) {
mCallback = callback;
GenericDraweeHierarchy hierarchy = Assertions.assumeNotNull(mRequestHelper).getHierarchy();
if (mRequestHelper == null) {
// this is here to help us debug t12048319, in which we have a null request helper on attach
throw new RuntimeException(
"No DraweeRequestHelper - width: " +
(getRight() - getLeft()) +
" - height: " + (getBottom() - getTop() +
" - number of sources: " + mSources.size()));
}
GenericDraweeHierarchy hierarchy = mRequestHelper.getHierarchy();
RoundingParams roundingParams = hierarchy.getRoundingParams();
if (shouldDisplayBorder()) {
@ -182,7 +193,9 @@ import com.facebook.react.views.imagehelper.MultiSourceHelper.MultiSourceResult;
@Override
public void onDetached() {
Assertions.assumeNotNull(mRequestHelper).detach();
if (mRequestHelper != null) {
mRequestHelper.detach();
}
}
@Override